escape variable in bash script curl request











up vote
-1
down vote

favorite












I am trying to curl via bash script but unable to pass the value of var1 in curl request and getting error upon execution ...



 #!/bin/bash
var1="some test message"
curl 'https://link'
-H 'Content-Type: application/json'
-d '
{"msgtype": "text",
"text": {
"content": $var1
}
}'









share|improve this question




























    up vote
    -1
    down vote

    favorite












    I am trying to curl via bash script but unable to pass the value of var1 in curl request and getting error upon execution ...



     #!/bin/bash
    var1="some test message"
    curl 'https://link'
    -H 'Content-Type: application/json'
    -d '
    {"msgtype": "text",
    "text": {
    "content": $var1
    }
    }'









    share|improve this question


























      up vote
      -1
      down vote

      favorite









      up vote
      -1
      down vote

      favorite











      I am trying to curl via bash script but unable to pass the value of var1 in curl request and getting error upon execution ...



       #!/bin/bash
      var1="some test message"
      curl 'https://link'
      -H 'Content-Type: application/json'
      -d '
      {"msgtype": "text",
      "text": {
      "content": $var1
      }
      }'









      share|improve this question















      I am trying to curl via bash script but unable to pass the value of var1 in curl request and getting error upon execution ...



       #!/bin/bash
      var1="some test message"
      curl 'https://link'
      -H 'Content-Type: application/json'
      -d '
      {"msgtype": "text",
      "text": {
      "content": $var1
      }
      }'






      linux bash shell curl






      share|improve this question















      share|improve this question













      share|improve this question




      share|improve this question








      edited Nov 8 at 11:17









      RavinderSingh13

      23.6k41337




      23.6k41337










      asked Nov 8 at 11:16









      tj59

      64




      64
























          3 Answers
          3






          active

          oldest

          votes

















          up vote
          -1
          down vote



          accepted










          Use below script.



          https://aaa.com' -H 'Content-Type: application/json' -d '{"msgtype": "text", "text": {      "content": '"'$var1'"'   }}'





          share|improve this answer























          • This produces invalid JSON that uses single quotes to quote the value of the content key. Using parameter expansion to create JSON is not in general safe anyway.
            – chepner
            Nov 8 at 14:01


















          up vote
          0
          down vote













          Your variable $var1 doesn't get expanded by the shell because it is inside single quote '.



          You need to use double quote to let bash do the parameter expansion, and escape your json data:



          #!/bin/bash
          var1="some test message"
          curl 'https://link'
          -H 'Content-Type: application/json'
          -d "
          {
          "msgtype": "text",
          "text": {
          "content": "$var1"
          }
          }"


          Or you can use inline document (without the escaping hell, but the command becomes awkward):



          #!/bin/bash
          var1="some test message"
          curl 'https://link'
          -H 'Content-Type: application/json'
          -d "$(cat <<EOT
          {
          "msgtype": "text",
          "text": {
          "content": "$var1"
          }
          }
          EOT
          )"





          share|improve this answer




























            up vote
            0
            down vote













            In general, don't use parameter expansion to define JSON dynamically like this. There is no guarantee that your template, combined with the contents of the variable, produces well-formed JSON. (This is for the same reasons you don't use string interpolation to create dynamic SQL queries.) Use a tool like jq instead.



            curl 'https://link' ... 
            -d "$(jq --argjson x "$var"
            -n '{msgtype: "text", text: {content: $x}}')"





            share|improve this answer





















              Your Answer






              StackExchange.ifUsing("editor", function () {
              StackExchange.using("externalEditor", function () {
              StackExchange.using("snippets", function () {
              StackExchange.snippets.init();
              });
              });
              }, "code-snippets");

              StackExchange.ready(function() {
              var channelOptions = {
              tags: "".split(" "),
              id: "1"
              };
              initTagRenderer("".split(" "), "".split(" "), channelOptions);

              StackExchange.using("externalEditor", function() {
              // Have to fire editor after snippets, if snippets enabled
              if (StackExchange.settings.snippets.snippetsEnabled) {
              StackExchange.using("snippets", function() {
              createEditor();
              });
              }
              else {
              createEditor();
              }
              });

              function createEditor() {
              StackExchange.prepareEditor({
              heartbeatType: 'answer',
              convertImagesToLinks: true,
              noModals: true,
              showLowRepImageUploadWarning: true,
              reputationToPostImages: 10,
              bindNavPrevention: true,
              postfix: "",
              imageUploader: {
              brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
              contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
              allowUrls: true
              },
              onDemand: true,
              discardSelector: ".discard-answer"
              ,immediatelyShowMarkdownHelp:true
              });


              }
              });














               

              draft saved


              draft discarded


















              StackExchange.ready(
              function () {
              StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53206654%2fescape-variable-in-bash-script-curl-request%23new-answer', 'question_page');
              }
              );

              Post as a guest















              Required, but never shown

























              3 Answers
              3






              active

              oldest

              votes








              3 Answers
              3






              active

              oldest

              votes









              active

              oldest

              votes






              active

              oldest

              votes








              up vote
              -1
              down vote



              accepted










              Use below script.



              https://aaa.com' -H 'Content-Type: application/json' -d '{"msgtype": "text", "text": {      "content": '"'$var1'"'   }}'





              share|improve this answer























              • This produces invalid JSON that uses single quotes to quote the value of the content key. Using parameter expansion to create JSON is not in general safe anyway.
                – chepner
                Nov 8 at 14:01















              up vote
              -1
              down vote



              accepted










              Use below script.



              https://aaa.com' -H 'Content-Type: application/json' -d '{"msgtype": "text", "text": {      "content": '"'$var1'"'   }}'





              share|improve this answer























              • This produces invalid JSON that uses single quotes to quote the value of the content key. Using parameter expansion to create JSON is not in general safe anyway.
                – chepner
                Nov 8 at 14:01













              up vote
              -1
              down vote



              accepted







              up vote
              -1
              down vote



              accepted






              Use below script.



              https://aaa.com' -H 'Content-Type: application/json' -d '{"msgtype": "text", "text": {      "content": '"'$var1'"'   }}'





              share|improve this answer














              Use below script.



              https://aaa.com' -H 'Content-Type: application/json' -d '{"msgtype": "text", "text": {      "content": '"'$var1'"'   }}'






              share|improve this answer














              share|improve this answer



              share|improve this answer








              edited Nov 8 at 14:00









              chepner

              238k29223318




              238k29223318










              answered Nov 8 at 11:48









              AqeelNawazDBA

              141




              141












              • This produces invalid JSON that uses single quotes to quote the value of the content key. Using parameter expansion to create JSON is not in general safe anyway.
                – chepner
                Nov 8 at 14:01


















              • This produces invalid JSON that uses single quotes to quote the value of the content key. Using parameter expansion to create JSON is not in general safe anyway.
                – chepner
                Nov 8 at 14:01
















              This produces invalid JSON that uses single quotes to quote the value of the content key. Using parameter expansion to create JSON is not in general safe anyway.
              – chepner
              Nov 8 at 14:01




              This produces invalid JSON that uses single quotes to quote the value of the content key. Using parameter expansion to create JSON is not in general safe anyway.
              – chepner
              Nov 8 at 14:01












              up vote
              0
              down vote













              Your variable $var1 doesn't get expanded by the shell because it is inside single quote '.



              You need to use double quote to let bash do the parameter expansion, and escape your json data:



              #!/bin/bash
              var1="some test message"
              curl 'https://link'
              -H 'Content-Type: application/json'
              -d "
              {
              "msgtype": "text",
              "text": {
              "content": "$var1"
              }
              }"


              Or you can use inline document (without the escaping hell, but the command becomes awkward):



              #!/bin/bash
              var1="some test message"
              curl 'https://link'
              -H 'Content-Type: application/json'
              -d "$(cat <<EOT
              {
              "msgtype": "text",
              "text": {
              "content": "$var1"
              }
              }
              EOT
              )"





              share|improve this answer

























                up vote
                0
                down vote













                Your variable $var1 doesn't get expanded by the shell because it is inside single quote '.



                You need to use double quote to let bash do the parameter expansion, and escape your json data:



                #!/bin/bash
                var1="some test message"
                curl 'https://link'
                -H 'Content-Type: application/json'
                -d "
                {
                "msgtype": "text",
                "text": {
                "content": "$var1"
                }
                }"


                Or you can use inline document (without the escaping hell, but the command becomes awkward):



                #!/bin/bash
                var1="some test message"
                curl 'https://link'
                -H 'Content-Type: application/json'
                -d "$(cat <<EOT
                {
                "msgtype": "text",
                "text": {
                "content": "$var1"
                }
                }
                EOT
                )"





                share|improve this answer























                  up vote
                  0
                  down vote










                  up vote
                  0
                  down vote









                  Your variable $var1 doesn't get expanded by the shell because it is inside single quote '.



                  You need to use double quote to let bash do the parameter expansion, and escape your json data:



                  #!/bin/bash
                  var1="some test message"
                  curl 'https://link'
                  -H 'Content-Type: application/json'
                  -d "
                  {
                  "msgtype": "text",
                  "text": {
                  "content": "$var1"
                  }
                  }"


                  Or you can use inline document (without the escaping hell, but the command becomes awkward):



                  #!/bin/bash
                  var1="some test message"
                  curl 'https://link'
                  -H 'Content-Type: application/json'
                  -d "$(cat <<EOT
                  {
                  "msgtype": "text",
                  "text": {
                  "content": "$var1"
                  }
                  }
                  EOT
                  )"





                  share|improve this answer












                  Your variable $var1 doesn't get expanded by the shell because it is inside single quote '.



                  You need to use double quote to let bash do the parameter expansion, and escape your json data:



                  #!/bin/bash
                  var1="some test message"
                  curl 'https://link'
                  -H 'Content-Type: application/json'
                  -d "
                  {
                  "msgtype": "text",
                  "text": {
                  "content": "$var1"
                  }
                  }"


                  Or you can use inline document (without the escaping hell, but the command becomes awkward):



                  #!/bin/bash
                  var1="some test message"
                  curl 'https://link'
                  -H 'Content-Type: application/json'
                  -d "$(cat <<EOT
                  {
                  "msgtype": "text",
                  "text": {
                  "content": "$var1"
                  }
                  }
                  EOT
                  )"






                  share|improve this answer












                  share|improve this answer



                  share|improve this answer










                  answered Nov 8 at 11:42









                  oliv

                  8,1931130




                  8,1931130






















                      up vote
                      0
                      down vote













                      In general, don't use parameter expansion to define JSON dynamically like this. There is no guarantee that your template, combined with the contents of the variable, produces well-formed JSON. (This is for the same reasons you don't use string interpolation to create dynamic SQL queries.) Use a tool like jq instead.



                      curl 'https://link' ... 
                      -d "$(jq --argjson x "$var"
                      -n '{msgtype: "text", text: {content: $x}}')"





                      share|improve this answer

























                        up vote
                        0
                        down vote













                        In general, don't use parameter expansion to define JSON dynamically like this. There is no guarantee that your template, combined with the contents of the variable, produces well-formed JSON. (This is for the same reasons you don't use string interpolation to create dynamic SQL queries.) Use a tool like jq instead.



                        curl 'https://link' ... 
                        -d "$(jq --argjson x "$var"
                        -n '{msgtype: "text", text: {content: $x}}')"





                        share|improve this answer























                          up vote
                          0
                          down vote










                          up vote
                          0
                          down vote









                          In general, don't use parameter expansion to define JSON dynamically like this. There is no guarantee that your template, combined with the contents of the variable, produces well-formed JSON. (This is for the same reasons you don't use string interpolation to create dynamic SQL queries.) Use a tool like jq instead.



                          curl 'https://link' ... 
                          -d "$(jq --argjson x "$var"
                          -n '{msgtype: "text", text: {content: $x}}')"





                          share|improve this answer












                          In general, don't use parameter expansion to define JSON dynamically like this. There is no guarantee that your template, combined with the contents of the variable, produces well-formed JSON. (This is for the same reasons you don't use string interpolation to create dynamic SQL queries.) Use a tool like jq instead.



                          curl 'https://link' ... 
                          -d "$(jq --argjson x "$var"
                          -n '{msgtype: "text", text: {content: $x}}')"






                          share|improve this answer












                          share|improve this answer



                          share|improve this answer










                          answered Nov 8 at 13:58









                          chepner

                          238k29223318




                          238k29223318






























                               

                              draft saved


                              draft discarded



















































                               


                              draft saved


                              draft discarded














                              StackExchange.ready(
                              function () {
                              StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53206654%2fescape-variable-in-bash-script-curl-request%23new-answer', 'question_page');
                              }
                              );

                              Post as a guest















                              Required, but never shown





















































                              Required, but never shown














                              Required, but never shown












                              Required, but never shown







                              Required, but never shown

































                              Required, but never shown














                              Required, but never shown












                              Required, but never shown







                              Required, but never shown







                              Popular posts from this blog

                              Guess what letter conforming each word

                              Port of Spain

                              Run scheduled task as local user group (not BUILTIN)