MapStruct - How to ignore the unnecessary methods/non-getter-setter methods in the POJO











up vote
0
down vote

favorite












Below is the POJO:



public class TransferObjectListTO {

private List<A> transferList;

public List<A> getTransferList() {
return transferList;
}

public void setList(List<A> transferList) {
this.transferList= transferList;
}

public List<A> getList() {
return getTransferList();
}

public void incrementList(List<A> transferList) {
getTransferList().addAll(transferList);
}

}


It has a kind of adder method -




incrementList




along with duplicate to getter method -




getList




The Mapstruct generated code has below unnecessary stuff, which adds list, one more time of source type:



if ( targetTypeTransferObjectListTO.getList() != null ) {
List sourceTypeList = sourceTypeTransferObjectListTO.getList();
if ( sourceTypeList != null ) {
targetTypeTransferObjectListTO.getList().addAll( sourceTypeList );
}
}


We cannot remove these methods - incrementList() and getList() in above POJO because it is used in many places. Now, how can we ignore these methods when mapstruct is generating implementation for mapping?










share|improve this question


























    up vote
    0
    down vote

    favorite












    Below is the POJO:



    public class TransferObjectListTO {

    private List<A> transferList;

    public List<A> getTransferList() {
    return transferList;
    }

    public void setList(List<A> transferList) {
    this.transferList= transferList;
    }

    public List<A> getList() {
    return getTransferList();
    }

    public void incrementList(List<A> transferList) {
    getTransferList().addAll(transferList);
    }

    }


    It has a kind of adder method -




    incrementList




    along with duplicate to getter method -




    getList




    The Mapstruct generated code has below unnecessary stuff, which adds list, one more time of source type:



    if ( targetTypeTransferObjectListTO.getList() != null ) {
    List sourceTypeList = sourceTypeTransferObjectListTO.getList();
    if ( sourceTypeList != null ) {
    targetTypeTransferObjectListTO.getList().addAll( sourceTypeList );
    }
    }


    We cannot remove these methods - incrementList() and getList() in above POJO because it is used in many places. Now, how can we ignore these methods when mapstruct is generating implementation for mapping?










    share|improve this question
























      up vote
      0
      down vote

      favorite









      up vote
      0
      down vote

      favorite











      Below is the POJO:



      public class TransferObjectListTO {

      private List<A> transferList;

      public List<A> getTransferList() {
      return transferList;
      }

      public void setList(List<A> transferList) {
      this.transferList= transferList;
      }

      public List<A> getList() {
      return getTransferList();
      }

      public void incrementList(List<A> transferList) {
      getTransferList().addAll(transferList);
      }

      }


      It has a kind of adder method -




      incrementList




      along with duplicate to getter method -




      getList




      The Mapstruct generated code has below unnecessary stuff, which adds list, one more time of source type:



      if ( targetTypeTransferObjectListTO.getList() != null ) {
      List sourceTypeList = sourceTypeTransferObjectListTO.getList();
      if ( sourceTypeList != null ) {
      targetTypeTransferObjectListTO.getList().addAll( sourceTypeList );
      }
      }


      We cannot remove these methods - incrementList() and getList() in above POJO because it is used in many places. Now, how can we ignore these methods when mapstruct is generating implementation for mapping?










      share|improve this question













      Below is the POJO:



      public class TransferObjectListTO {

      private List<A> transferList;

      public List<A> getTransferList() {
      return transferList;
      }

      public void setList(List<A> transferList) {
      this.transferList= transferList;
      }

      public List<A> getList() {
      return getTransferList();
      }

      public void incrementList(List<A> transferList) {
      getTransferList().addAll(transferList);
      }

      }


      It has a kind of adder method -




      incrementList




      along with duplicate to getter method -




      getList




      The Mapstruct generated code has below unnecessary stuff, which adds list, one more time of source type:



      if ( targetTypeTransferObjectListTO.getList() != null ) {
      List sourceTypeList = sourceTypeTransferObjectListTO.getList();
      if ( sourceTypeList != null ) {
      targetTypeTransferObjectListTO.getList().addAll( sourceTypeList );
      }
      }


      We cannot remove these methods - incrementList() and getList() in above POJO because it is used in many places. Now, how can we ignore these methods when mapstruct is generating implementation for mapping?







      java list mapping pojo mapstruct






      share|improve this question













      share|improve this question











      share|improve this question




      share|improve this question










      asked Nov 8 at 13:20









      Tushar Ahirrao

      4,488155590




      4,488155590
























          1 Answer
          1






          active

          oldest

          votes

















          up vote
          1
          down vote



          accepted










          There are multiple ways that you can achieve what you are looking for. The problem is only with the getList() method, the incrementList() is already ignored by MapStruct.



          Ignore the mapping



          If you don't have a lot of POJOs that have this pattern and you have few mappers that use this you can just add



          @Mapping(target = "list", ignore = true)


          Write your own AccessorNamingStrategy



          In case you have a lot of POJOs and a lot of mappers then I would suggest you to write your own custom AccessorNamingStrategy that would mark the getList() method as OTHER method.



          public class CustomAccessorNamingStrategy extends DefaultAccessorNamingStrategy {

          @Override
          public boolean isGetterMethod(ExecutableElement method) {
          if (method.getSimpleName().toString().equals("getList")) {
          return false;
          } else {
          return super.isGetterMethod(method);
          }
          }
          }





          share|improve this answer





















          • Thank you Filip! It worked.
            – Tushar Ahirrao
            Nov 9 at 9:28











          Your Answer






          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "1"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          convertImagesToLinks: true,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: 10,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });














           

          draft saved


          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53208604%2fmapstruct-how-to-ignore-the-unnecessary-methods-non-getter-setter-methods-in-t%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown

























          1 Answer
          1






          active

          oldest

          votes








          1 Answer
          1






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes








          up vote
          1
          down vote



          accepted










          There are multiple ways that you can achieve what you are looking for. The problem is only with the getList() method, the incrementList() is already ignored by MapStruct.



          Ignore the mapping



          If you don't have a lot of POJOs that have this pattern and you have few mappers that use this you can just add



          @Mapping(target = "list", ignore = true)


          Write your own AccessorNamingStrategy



          In case you have a lot of POJOs and a lot of mappers then I would suggest you to write your own custom AccessorNamingStrategy that would mark the getList() method as OTHER method.



          public class CustomAccessorNamingStrategy extends DefaultAccessorNamingStrategy {

          @Override
          public boolean isGetterMethod(ExecutableElement method) {
          if (method.getSimpleName().toString().equals("getList")) {
          return false;
          } else {
          return super.isGetterMethod(method);
          }
          }
          }





          share|improve this answer





















          • Thank you Filip! It worked.
            – Tushar Ahirrao
            Nov 9 at 9:28















          up vote
          1
          down vote



          accepted










          There are multiple ways that you can achieve what you are looking for. The problem is only with the getList() method, the incrementList() is already ignored by MapStruct.



          Ignore the mapping



          If you don't have a lot of POJOs that have this pattern and you have few mappers that use this you can just add



          @Mapping(target = "list", ignore = true)


          Write your own AccessorNamingStrategy



          In case you have a lot of POJOs and a lot of mappers then I would suggest you to write your own custom AccessorNamingStrategy that would mark the getList() method as OTHER method.



          public class CustomAccessorNamingStrategy extends DefaultAccessorNamingStrategy {

          @Override
          public boolean isGetterMethod(ExecutableElement method) {
          if (method.getSimpleName().toString().equals("getList")) {
          return false;
          } else {
          return super.isGetterMethod(method);
          }
          }
          }





          share|improve this answer





















          • Thank you Filip! It worked.
            – Tushar Ahirrao
            Nov 9 at 9:28













          up vote
          1
          down vote



          accepted







          up vote
          1
          down vote



          accepted






          There are multiple ways that you can achieve what you are looking for. The problem is only with the getList() method, the incrementList() is already ignored by MapStruct.



          Ignore the mapping



          If you don't have a lot of POJOs that have this pattern and you have few mappers that use this you can just add



          @Mapping(target = "list", ignore = true)


          Write your own AccessorNamingStrategy



          In case you have a lot of POJOs and a lot of mappers then I would suggest you to write your own custom AccessorNamingStrategy that would mark the getList() method as OTHER method.



          public class CustomAccessorNamingStrategy extends DefaultAccessorNamingStrategy {

          @Override
          public boolean isGetterMethod(ExecutableElement method) {
          if (method.getSimpleName().toString().equals("getList")) {
          return false;
          } else {
          return super.isGetterMethod(method);
          }
          }
          }





          share|improve this answer












          There are multiple ways that you can achieve what you are looking for. The problem is only with the getList() method, the incrementList() is already ignored by MapStruct.



          Ignore the mapping



          If you don't have a lot of POJOs that have this pattern and you have few mappers that use this you can just add



          @Mapping(target = "list", ignore = true)


          Write your own AccessorNamingStrategy



          In case you have a lot of POJOs and a lot of mappers then I would suggest you to write your own custom AccessorNamingStrategy that would mark the getList() method as OTHER method.



          public class CustomAccessorNamingStrategy extends DefaultAccessorNamingStrategy {

          @Override
          public boolean isGetterMethod(ExecutableElement method) {
          if (method.getSimpleName().toString().equals("getList")) {
          return false;
          } else {
          return super.isGetterMethod(method);
          }
          }
          }






          share|improve this answer












          share|improve this answer



          share|improve this answer










          answered Nov 8 at 14:15









          Filip

          2,81921026




          2,81921026












          • Thank you Filip! It worked.
            – Tushar Ahirrao
            Nov 9 at 9:28


















          • Thank you Filip! It worked.
            – Tushar Ahirrao
            Nov 9 at 9:28
















          Thank you Filip! It worked.
          – Tushar Ahirrao
          Nov 9 at 9:28




          Thank you Filip! It worked.
          – Tushar Ahirrao
          Nov 9 at 9:28


















           

          draft saved


          draft discarded



















































           


          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53208604%2fmapstruct-how-to-ignore-the-unnecessary-methods-non-getter-setter-methods-in-t%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          Guess what letter conforming each word

          Port of Spain

          Run scheduled task as local user group (not BUILTIN)