ReactJS createRef for N components, all point to the final one in the list












1














I have 3 components, App, Parent and Child. The App uses a method provided by Parent and registers the children into Parent. This is for the Parent to collect the Refs (create a dependency map) of the Children it encompasses.



Child has a method named Animate which will be invoked by Parent via refs created.



When I try to print the dependencyMap I can see an array is being generated, the way I expect.



But when I try to access the child components from Parent using the dependencyMap, it always invokes the last on on the list of children.



That is to say, when I try to animate < CustomComponent > using animateDependentChildren within Parent.js, the CustomComponent2 only gets animated, even if I pass the correctId for CustomComponent1.



App.js
export default class App extends React.Component {
render(){
return(
<Parent>
{
(props)=>{
return(
<View>
<CustomComponent1 ref={props.register('s1')} key={1}>Text</CustomComponent1>
<CustomComponent2 ref={props.register('s2')} key={2}>Text2</CustomComponent2>
<ListComponent id={'s1'} key={3}/>
<ListComponent id={'s2'} key={3}/>
</View>
)
}
}
</Parent>
);
}
}


Parent.js
class Parent extends React.Component{
constructor(props) {
super(props);
this.dependencyMap = {}
}

render() {
return (
<View>
{this.props.children({
register: this.register.bind(this)
})}
</View>
);
}

register(dependentOn){
let dependentRef = React.createRef();

if(!this.dependencyMap[dependentOn]){
this.dependencyMap[dependentOn] = ;
}
this.dependencyMap[dependentOn].push(dependentRef);

return dependentRef;
}

animateDependentChildren(listId){
let subscribers = this.dependencyMap[listId];

subscribers.forEach(subscriber => {
console.log('subscriber', subscriber);
console.log('subscriber dom', subscriber.current);
this.refs[subscriber].animate(scrollObj); // <-This function always animates the last of the list of children (ie CustomComponent2)
});
}
}


Any idea what Im doing wrong here? Cant React.createRef be used to create multiple references and then invoke them later individually?










share|improve this question
























  • There's no such problem with multiple references. They are independent. Consider providing stackoverflow.com/help/mcve with a demo. The problem is likely elsewhere.
    – estus
    Nov 15 '18 at 8:26
















1














I have 3 components, App, Parent and Child. The App uses a method provided by Parent and registers the children into Parent. This is for the Parent to collect the Refs (create a dependency map) of the Children it encompasses.



Child has a method named Animate which will be invoked by Parent via refs created.



When I try to print the dependencyMap I can see an array is being generated, the way I expect.



But when I try to access the child components from Parent using the dependencyMap, it always invokes the last on on the list of children.



That is to say, when I try to animate < CustomComponent > using animateDependentChildren within Parent.js, the CustomComponent2 only gets animated, even if I pass the correctId for CustomComponent1.



App.js
export default class App extends React.Component {
render(){
return(
<Parent>
{
(props)=>{
return(
<View>
<CustomComponent1 ref={props.register('s1')} key={1}>Text</CustomComponent1>
<CustomComponent2 ref={props.register('s2')} key={2}>Text2</CustomComponent2>
<ListComponent id={'s1'} key={3}/>
<ListComponent id={'s2'} key={3}/>
</View>
)
}
}
</Parent>
);
}
}


Parent.js
class Parent extends React.Component{
constructor(props) {
super(props);
this.dependencyMap = {}
}

render() {
return (
<View>
{this.props.children({
register: this.register.bind(this)
})}
</View>
);
}

register(dependentOn){
let dependentRef = React.createRef();

if(!this.dependencyMap[dependentOn]){
this.dependencyMap[dependentOn] = ;
}
this.dependencyMap[dependentOn].push(dependentRef);

return dependentRef;
}

animateDependentChildren(listId){
let subscribers = this.dependencyMap[listId];

subscribers.forEach(subscriber => {
console.log('subscriber', subscriber);
console.log('subscriber dom', subscriber.current);
this.refs[subscriber].animate(scrollObj); // <-This function always animates the last of the list of children (ie CustomComponent2)
});
}
}


Any idea what Im doing wrong here? Cant React.createRef be used to create multiple references and then invoke them later individually?










share|improve this question
























  • There's no such problem with multiple references. They are independent. Consider providing stackoverflow.com/help/mcve with a demo. The problem is likely elsewhere.
    – estus
    Nov 15 '18 at 8:26














1












1








1


1





I have 3 components, App, Parent and Child. The App uses a method provided by Parent and registers the children into Parent. This is for the Parent to collect the Refs (create a dependency map) of the Children it encompasses.



Child has a method named Animate which will be invoked by Parent via refs created.



When I try to print the dependencyMap I can see an array is being generated, the way I expect.



But when I try to access the child components from Parent using the dependencyMap, it always invokes the last on on the list of children.



That is to say, when I try to animate < CustomComponent > using animateDependentChildren within Parent.js, the CustomComponent2 only gets animated, even if I pass the correctId for CustomComponent1.



App.js
export default class App extends React.Component {
render(){
return(
<Parent>
{
(props)=>{
return(
<View>
<CustomComponent1 ref={props.register('s1')} key={1}>Text</CustomComponent1>
<CustomComponent2 ref={props.register('s2')} key={2}>Text2</CustomComponent2>
<ListComponent id={'s1'} key={3}/>
<ListComponent id={'s2'} key={3}/>
</View>
)
}
}
</Parent>
);
}
}


Parent.js
class Parent extends React.Component{
constructor(props) {
super(props);
this.dependencyMap = {}
}

render() {
return (
<View>
{this.props.children({
register: this.register.bind(this)
})}
</View>
);
}

register(dependentOn){
let dependentRef = React.createRef();

if(!this.dependencyMap[dependentOn]){
this.dependencyMap[dependentOn] = ;
}
this.dependencyMap[dependentOn].push(dependentRef);

return dependentRef;
}

animateDependentChildren(listId){
let subscribers = this.dependencyMap[listId];

subscribers.forEach(subscriber => {
console.log('subscriber', subscriber);
console.log('subscriber dom', subscriber.current);
this.refs[subscriber].animate(scrollObj); // <-This function always animates the last of the list of children (ie CustomComponent2)
});
}
}


Any idea what Im doing wrong here? Cant React.createRef be used to create multiple references and then invoke them later individually?










share|improve this question















I have 3 components, App, Parent and Child. The App uses a method provided by Parent and registers the children into Parent. This is for the Parent to collect the Refs (create a dependency map) of the Children it encompasses.



Child has a method named Animate which will be invoked by Parent via refs created.



When I try to print the dependencyMap I can see an array is being generated, the way I expect.



But when I try to access the child components from Parent using the dependencyMap, it always invokes the last on on the list of children.



That is to say, when I try to animate < CustomComponent > using animateDependentChildren within Parent.js, the CustomComponent2 only gets animated, even if I pass the correctId for CustomComponent1.



App.js
export default class App extends React.Component {
render(){
return(
<Parent>
{
(props)=>{
return(
<View>
<CustomComponent1 ref={props.register('s1')} key={1}>Text</CustomComponent1>
<CustomComponent2 ref={props.register('s2')} key={2}>Text2</CustomComponent2>
<ListComponent id={'s1'} key={3}/>
<ListComponent id={'s2'} key={3}/>
</View>
)
}
}
</Parent>
);
}
}


Parent.js
class Parent extends React.Component{
constructor(props) {
super(props);
this.dependencyMap = {}
}

render() {
return (
<View>
{this.props.children({
register: this.register.bind(this)
})}
</View>
);
}

register(dependentOn){
let dependentRef = React.createRef();

if(!this.dependencyMap[dependentOn]){
this.dependencyMap[dependentOn] = ;
}
this.dependencyMap[dependentOn].push(dependentRef);

return dependentRef;
}

animateDependentChildren(listId){
let subscribers = this.dependencyMap[listId];

subscribers.forEach(subscriber => {
console.log('subscriber', subscriber);
console.log('subscriber dom', subscriber.current);
this.refs[subscriber].animate(scrollObj); // <-This function always animates the last of the list of children (ie CustomComponent2)
});
}
}


Any idea what Im doing wrong here? Cant React.createRef be used to create multiple references and then invoke them later individually?







reactjs react-native react-ref






share|improve this question















share|improve this question













share|improve this question




share|improve this question








edited Nov 15 '18 at 7:47







phoenix

















asked Nov 15 '18 at 7:29









phoenixphoenix

1,00152848




1,00152848












  • There's no such problem with multiple references. They are independent. Consider providing stackoverflow.com/help/mcve with a demo. The problem is likely elsewhere.
    – estus
    Nov 15 '18 at 8:26


















  • There's no such problem with multiple references. They are independent. Consider providing stackoverflow.com/help/mcve with a demo. The problem is likely elsewhere.
    – estus
    Nov 15 '18 at 8:26
















There's no such problem with multiple references. They are independent. Consider providing stackoverflow.com/help/mcve with a demo. The problem is likely elsewhere.
– estus
Nov 15 '18 at 8:26




There's no such problem with multiple references. They are independent. Consider providing stackoverflow.com/help/mcve with a demo. The problem is likely elsewhere.
– estus
Nov 15 '18 at 8:26












1 Answer
1






active

oldest

votes


















0














As subscriber is the component ref, try changing this line:



this.refs[subscriber].animate(scrollObj);


...to:



subscriber.animate(scrollObj);


I hope this helps.






share|improve this answer





















    Your Answer






    StackExchange.ifUsing("editor", function () {
    StackExchange.using("externalEditor", function () {
    StackExchange.using("snippets", function () {
    StackExchange.snippets.init();
    });
    });
    }, "code-snippets");

    StackExchange.ready(function() {
    var channelOptions = {
    tags: "".split(" "),
    id: "1"
    };
    initTagRenderer("".split(" "), "".split(" "), channelOptions);

    StackExchange.using("externalEditor", function() {
    // Have to fire editor after snippets, if snippets enabled
    if (StackExchange.settings.snippets.snippetsEnabled) {
    StackExchange.using("snippets", function() {
    createEditor();
    });
    }
    else {
    createEditor();
    }
    });

    function createEditor() {
    StackExchange.prepareEditor({
    heartbeatType: 'answer',
    autoActivateHeartbeat: false,
    convertImagesToLinks: true,
    noModals: true,
    showLowRepImageUploadWarning: true,
    reputationToPostImages: 10,
    bindNavPrevention: true,
    postfix: "",
    imageUploader: {
    brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
    contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
    allowUrls: true
    },
    onDemand: true,
    discardSelector: ".discard-answer"
    ,immediatelyShowMarkdownHelp:true
    });


    }
    });














    draft saved

    draft discarded


















    StackExchange.ready(
    function () {
    StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53314384%2freactjs-createref-for-n-components-all-point-to-the-final-one-in-the-list%23new-answer', 'question_page');
    }
    );

    Post as a guest















    Required, but never shown

























    1 Answer
    1






    active

    oldest

    votes








    1 Answer
    1






    active

    oldest

    votes









    active

    oldest

    votes






    active

    oldest

    votes









    0














    As subscriber is the component ref, try changing this line:



    this.refs[subscriber].animate(scrollObj);


    ...to:



    subscriber.animate(scrollObj);


    I hope this helps.






    share|improve this answer


























      0














      As subscriber is the component ref, try changing this line:



      this.refs[subscriber].animate(scrollObj);


      ...to:



      subscriber.animate(scrollObj);


      I hope this helps.






      share|improve this answer
























        0












        0








        0






        As subscriber is the component ref, try changing this line:



        this.refs[subscriber].animate(scrollObj);


        ...to:



        subscriber.animate(scrollObj);


        I hope this helps.






        share|improve this answer












        As subscriber is the component ref, try changing this line:



        this.refs[subscriber].animate(scrollObj);


        ...to:



        subscriber.animate(scrollObj);


        I hope this helps.







        share|improve this answer












        share|improve this answer



        share|improve this answer










        answered Nov 15 '18 at 8:50









        Steve HolgadoSteve Holgado

        3,281249




        3,281249






























            draft saved

            draft discarded




















































            Thanks for contributing an answer to Stack Overflow!


            • Please be sure to answer the question. Provide details and share your research!

            But avoid



            • Asking for help, clarification, or responding to other answers.

            • Making statements based on opinion; back them up with references or personal experience.


            To learn more, see our tips on writing great answers.





            Some of your past answers have not been well-received, and you're in danger of being blocked from answering.


            Please pay close attention to the following guidance:


            • Please be sure to answer the question. Provide details and share your research!

            But avoid



            • Asking for help, clarification, or responding to other answers.

            • Making statements based on opinion; back them up with references or personal experience.


            To learn more, see our tips on writing great answers.




            draft saved


            draft discarded














            StackExchange.ready(
            function () {
            StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53314384%2freactjs-createref-for-n-components-all-point-to-the-final-one-in-the-list%23new-answer', 'question_page');
            }
            );

            Post as a guest















            Required, but never shown





















































            Required, but never shown














            Required, but never shown












            Required, but never shown







            Required, but never shown

































            Required, but never shown














            Required, but never shown












            Required, but never shown







            Required, but never shown







            Popular posts from this blog

            Guess what letter conforming each word

            Port of Spain

            Run scheduled task as local user group (not BUILTIN)