conditionally rendered elements that use ref












0















I have a component that renders a child <ul/> conditionally based on if data is fetched from the backend.



class groupInfo extends Component {
constructor(props) {
super(props);
this.setSubGroupRef = this.setSubGroupRef.bind(this);
this.checkSubgroupOverflow = this.checkSubgroupOverflow.bind(this);
this.state = {
data: null,
overflowingSubgroups: false,
}
}
componentDidMount() {
//fetch data from backend
this.setState({data})
}
setSubGroupRef(node){
this.subGroupRef = node;
node.addEventListener("resize", this.checkSubgroupOverflow);
}
componentWillUnmount() {
if (this.subGroupRef) {
this.subGroupRef.removeEventListener("resize", this.checkSubgroupOverflow);
}
}
checkSubgroupOverflow() {
const element = this.subGroupContainer;
if (element) {
// Check against baseline rendered height of our subgroup container, plus a few safe pixels.
// Magic number here because we know what the height *should* be when its collapsed by CSS.
this.setState({
overflowingSubgroups: (element.scrollHeight > 36),
});
}
}
render() {
const {overflowingSubgroups, data} = this.state
return (
<div>
<div>
some information
</div>
{
data.type === "group" ?
<div ref={this.setSubGroupRef}>
<ul>
{
data.subGroups.map((subData) => {
return (
<li>
// display sub-data info
</li>
)
})
}
</ul>
{
overflowingSubgroups ?
<span
className="iconMore"
onClick={this.toggleSubgroupExpansion}
>
<img
src={`${iconPath}icon-arrow.svg`}
alt="more"
/>
</span> :
null
}
</div>
}
</div>
)
}
}


What i'm trying to achieve here is if the <ul/> is over flowing id like to add a toggle switch based on if my containing div is overflowing or not.
The issue is that as i'm navigating between these subGroups for the first time it also re-renders groupInfo causing a re-fetch of the data that is then stored in the redux store for later use but this also causes a new node instance to be spawned and I'm unable to kill my old eventListener. Now componentWillUnmount is not called since the component is just being re-rendered with new data.



Im trying to avoid creating a child React component for the <ul/> based on the data.type since this will involve a major refactor.










share|improve this question



























    0















    I have a component that renders a child <ul/> conditionally based on if data is fetched from the backend.



    class groupInfo extends Component {
    constructor(props) {
    super(props);
    this.setSubGroupRef = this.setSubGroupRef.bind(this);
    this.checkSubgroupOverflow = this.checkSubgroupOverflow.bind(this);
    this.state = {
    data: null,
    overflowingSubgroups: false,
    }
    }
    componentDidMount() {
    //fetch data from backend
    this.setState({data})
    }
    setSubGroupRef(node){
    this.subGroupRef = node;
    node.addEventListener("resize", this.checkSubgroupOverflow);
    }
    componentWillUnmount() {
    if (this.subGroupRef) {
    this.subGroupRef.removeEventListener("resize", this.checkSubgroupOverflow);
    }
    }
    checkSubgroupOverflow() {
    const element = this.subGroupContainer;
    if (element) {
    // Check against baseline rendered height of our subgroup container, plus a few safe pixels.
    // Magic number here because we know what the height *should* be when its collapsed by CSS.
    this.setState({
    overflowingSubgroups: (element.scrollHeight > 36),
    });
    }
    }
    render() {
    const {overflowingSubgroups, data} = this.state
    return (
    <div>
    <div>
    some information
    </div>
    {
    data.type === "group" ?
    <div ref={this.setSubGroupRef}>
    <ul>
    {
    data.subGroups.map((subData) => {
    return (
    <li>
    // display sub-data info
    </li>
    )
    })
    }
    </ul>
    {
    overflowingSubgroups ?
    <span
    className="iconMore"
    onClick={this.toggleSubgroupExpansion}
    >
    <img
    src={`${iconPath}icon-arrow.svg`}
    alt="more"
    />
    </span> :
    null
    }
    </div>
    }
    </div>
    )
    }
    }


    What i'm trying to achieve here is if the <ul/> is over flowing id like to add a toggle switch based on if my containing div is overflowing or not.
    The issue is that as i'm navigating between these subGroups for the first time it also re-renders groupInfo causing a re-fetch of the data that is then stored in the redux store for later use but this also causes a new node instance to be spawned and I'm unable to kill my old eventListener. Now componentWillUnmount is not called since the component is just being re-rendered with new data.



    Im trying to avoid creating a child React component for the <ul/> based on the data.type since this will involve a major refactor.










    share|improve this question

























      0












      0








      0








      I have a component that renders a child <ul/> conditionally based on if data is fetched from the backend.



      class groupInfo extends Component {
      constructor(props) {
      super(props);
      this.setSubGroupRef = this.setSubGroupRef.bind(this);
      this.checkSubgroupOverflow = this.checkSubgroupOverflow.bind(this);
      this.state = {
      data: null,
      overflowingSubgroups: false,
      }
      }
      componentDidMount() {
      //fetch data from backend
      this.setState({data})
      }
      setSubGroupRef(node){
      this.subGroupRef = node;
      node.addEventListener("resize", this.checkSubgroupOverflow);
      }
      componentWillUnmount() {
      if (this.subGroupRef) {
      this.subGroupRef.removeEventListener("resize", this.checkSubgroupOverflow);
      }
      }
      checkSubgroupOverflow() {
      const element = this.subGroupContainer;
      if (element) {
      // Check against baseline rendered height of our subgroup container, plus a few safe pixels.
      // Magic number here because we know what the height *should* be when its collapsed by CSS.
      this.setState({
      overflowingSubgroups: (element.scrollHeight > 36),
      });
      }
      }
      render() {
      const {overflowingSubgroups, data} = this.state
      return (
      <div>
      <div>
      some information
      </div>
      {
      data.type === "group" ?
      <div ref={this.setSubGroupRef}>
      <ul>
      {
      data.subGroups.map((subData) => {
      return (
      <li>
      // display sub-data info
      </li>
      )
      })
      }
      </ul>
      {
      overflowingSubgroups ?
      <span
      className="iconMore"
      onClick={this.toggleSubgroupExpansion}
      >
      <img
      src={`${iconPath}icon-arrow.svg`}
      alt="more"
      />
      </span> :
      null
      }
      </div>
      }
      </div>
      )
      }
      }


      What i'm trying to achieve here is if the <ul/> is over flowing id like to add a toggle switch based on if my containing div is overflowing or not.
      The issue is that as i'm navigating between these subGroups for the first time it also re-renders groupInfo causing a re-fetch of the data that is then stored in the redux store for later use but this also causes a new node instance to be spawned and I'm unable to kill my old eventListener. Now componentWillUnmount is not called since the component is just being re-rendered with new data.



      Im trying to avoid creating a child React component for the <ul/> based on the data.type since this will involve a major refactor.










      share|improve this question














      I have a component that renders a child <ul/> conditionally based on if data is fetched from the backend.



      class groupInfo extends Component {
      constructor(props) {
      super(props);
      this.setSubGroupRef = this.setSubGroupRef.bind(this);
      this.checkSubgroupOverflow = this.checkSubgroupOverflow.bind(this);
      this.state = {
      data: null,
      overflowingSubgroups: false,
      }
      }
      componentDidMount() {
      //fetch data from backend
      this.setState({data})
      }
      setSubGroupRef(node){
      this.subGroupRef = node;
      node.addEventListener("resize", this.checkSubgroupOverflow);
      }
      componentWillUnmount() {
      if (this.subGroupRef) {
      this.subGroupRef.removeEventListener("resize", this.checkSubgroupOverflow);
      }
      }
      checkSubgroupOverflow() {
      const element = this.subGroupContainer;
      if (element) {
      // Check against baseline rendered height of our subgroup container, plus a few safe pixels.
      // Magic number here because we know what the height *should* be when its collapsed by CSS.
      this.setState({
      overflowingSubgroups: (element.scrollHeight > 36),
      });
      }
      }
      render() {
      const {overflowingSubgroups, data} = this.state
      return (
      <div>
      <div>
      some information
      </div>
      {
      data.type === "group" ?
      <div ref={this.setSubGroupRef}>
      <ul>
      {
      data.subGroups.map((subData) => {
      return (
      <li>
      // display sub-data info
      </li>
      )
      })
      }
      </ul>
      {
      overflowingSubgroups ?
      <span
      className="iconMore"
      onClick={this.toggleSubgroupExpansion}
      >
      <img
      src={`${iconPath}icon-arrow.svg`}
      alt="more"
      />
      </span> :
      null
      }
      </div>
      }
      </div>
      )
      }
      }


      What i'm trying to achieve here is if the <ul/> is over flowing id like to add a toggle switch based on if my containing div is overflowing or not.
      The issue is that as i'm navigating between these subGroups for the first time it also re-renders groupInfo causing a re-fetch of the data that is then stored in the redux store for later use but this also causes a new node instance to be spawned and I'm unable to kill my old eventListener. Now componentWillUnmount is not called since the component is just being re-rendered with new data.



      Im trying to avoid creating a child React component for the <ul/> based on the data.type since this will involve a major refactor.







      javascript reactjs ref






      share|improve this question













      share|improve this question











      share|improve this question




      share|improve this question










      asked Nov 20 '18 at 0:12









      joshua ferminjoshua fermin

      394212




      394212
























          0






          active

          oldest

          votes











          Your Answer






          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "1"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: true,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: 10,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });














          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53384439%2fconditionally-rendered-elements-that-use-ref%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown

























          0






          active

          oldest

          votes








          0






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes
















          draft saved

          draft discarded




















































          Thanks for contributing an answer to Stack Overflow!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53384439%2fconditionally-rendered-elements-that-use-ref%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          Guess what letter conforming each word

          Run scheduled task as local user group (not BUILTIN)

          Port of Spain