Instantiated class with “new” keyword is null after Start method has ended and button is pressed. Unity3d












0















I have a SaveController, it looks like this:



enter image description here



In the Start method of a MainMenuLogic class, I instantiate an instance of SaveController:



enter image description here



When the game starts, MusicOn method has been called before the Start method is called so the soundController is null...



enter image description here



public void MusicOn(bool on)

{

    saveController.MusicOn(on);

}


I've obviously not understood the application flow, so wondered if anyone has an idea on what might be going wrong. Which method should i instantiate the SaveController?



P.S I know, GameObject.Find, bleurgh... i'm refactoring, no wuckers.






c# unity3d







share|improve this question

























  • Please don't add code as image but as text to your question.

    – derHugo
    Nov 20 '18 at 4:52











  • Thanks for the tip derHugo

    – Jimmyt1988
    Nov 28 '18 at 17:00
















0















I have a SaveController, it looks like this:



enter image description here



In the Start method of a MainMenuLogic class, I instantiate an instance of SaveController:



enter image description here



When the game starts, MusicOn method has been called before the Start method is called so the soundController is null...



enter image description here



public void MusicOn(bool on)

{

    saveController.MusicOn(on);

}


I've obviously not understood the application flow, so wondered if anyone has an idea on what might be going wrong. Which method should i instantiate the SaveController?



P.S I know, GameObject.Find, bleurgh... i'm refactoring, no wuckers.






c# unity3d







share|improve this question

























  • Please don't add code as image but as text to your question.

    – derHugo
    Nov 20 '18 at 4:52











  • Thanks for the tip derHugo

    – Jimmyt1988
    Nov 28 '18 at 17:00














0












0








0








I have a SaveController, it looks like this:



enter image description here



In the Start method of a MainMenuLogic class, I instantiate an instance of SaveController:



enter image description here



When the game starts, MusicOn method has been called before the Start method is called so the soundController is null...



enter image description here



public void MusicOn(bool on)

{

    saveController.MusicOn(on);

}


I've obviously not understood the application flow, so wondered if anyone has an idea on what might be going wrong. Which method should i instantiate the SaveController?



P.S I know, GameObject.Find, bleurgh... i'm refactoring, no wuckers.






c# unity3d







share|improve this question
















I have a SaveController, it looks like this:



enter image description here



In the Start method of a MainMenuLogic class, I instantiate an instance of SaveController:



enter image description here



When the game starts, MusicOn method has been called before the Start method is called so the soundController is null...



enter image description here



public void MusicOn(bool on)

{

    saveController.MusicOn(on);

}


I've obviously not understood the application flow, so wondered if anyone has an idea on what might be going wrong. Which method should i instantiate the SaveController?



P.S I know, GameObject.Find, bleurgh... i'm refactoring, no wuckers.






c# unity3d




c# unity3d






share|improve this question















share|improve this question













share|improve this question




share|improve this question








edited Nov 19 '18 at 19:22









Ruzihm

3,70611627




3,70611627










asked Nov 19 '18 at 19:12









Jimmyt1988Jimmyt1988

9,1362791164




9,1362791164













  • Please don't add code as image but as text to your question.

    – derHugo
    Nov 20 '18 at 4:52











  • Thanks for the tip derHugo

    – Jimmyt1988
    Nov 28 '18 at 17:00



















  • Please don't add code as image but as text to your question.

    – derHugo
    Nov 20 '18 at 4:52











  • Thanks for the tip derHugo

    – Jimmyt1988
    Nov 28 '18 at 17:00

















Please don't add code as image but as text to your question.

– derHugo
Nov 20 '18 at 4:52





Please don't add code as image but as text to your question.

– derHugo
Nov 20 '18 at 4:52













Thanks for the tip derHugo

– Jimmyt1988
Nov 28 '18 at 17:00





Thanks for the tip derHugo

– Jimmyt1988
Nov 28 '18 at 17:00












1 Answer
1






active

oldest

votes


















1














Looks like Awake was the method i was looking for.



Awake is called before Start, so doing the saveController instantiation in Awake allows for the instantiation to happen before MusicOn is called.



void Awake() 

{

    saveController = new SaveController();

}


source: https://unity3d.com/learn/tutorials/topics/scripting/awake-and-start






share|improve this answer





















  • 2





    Also check out the Script Execution Order: docs.unity3d.com/Manual/class-MonoManager.html

    – Mathias Siig Nørregaard
    Nov 19 '18 at 20:07











  • Another option is also wrapping saveController in a property that checks if saveController is null, then constructing an instance if it is and returning saveController.

    – Mathias Siig Nørregaard
    Nov 19 '18 at 20:08






  • 1





    Thanks guys. And you'll be happy to know i've removed almost all instances of GameObject.Find. :)

    – Jimmyt1988
    Nov 19 '18 at 21:04











Your Answer






StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");

StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);

StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});

function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});


}
});














draft saved

draft discarded


















StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53381164%2finstantiated-class-with-new-keyword-is-null-after-start-method-has-ended-and-b%23new-answer', 'question_page');
}
);

Post as a guest















Required, but never shown

























1 Answer
1






active

oldest

votes








1 Answer
1






active

oldest

votes









active

oldest

votes






active

oldest

votes









1














Looks like Awake was the method i was looking for.



Awake is called before Start, so doing the saveController instantiation in Awake allows for the instantiation to happen before MusicOn is called.



void Awake() 

{

    saveController = new SaveController();

}


source: https://unity3d.com/learn/tutorials/topics/scripting/awake-and-start






share|improve this answer





















  • 2





    Also check out the Script Execution Order: docs.unity3d.com/Manual/class-MonoManager.html

    – Mathias Siig Nørregaard
    Nov 19 '18 at 20:07











  • Another option is also wrapping saveController in a property that checks if saveController is null, then constructing an instance if it is and returning saveController.

    – Mathias Siig Nørregaard
    Nov 19 '18 at 20:08






  • 1





    Thanks guys. And you'll be happy to know i've removed almost all instances of GameObject.Find. :)

    – Jimmyt1988
    Nov 19 '18 at 21:04
















1














Looks like Awake was the method i was looking for.



Awake is called before Start, so doing the saveController instantiation in Awake allows for the instantiation to happen before MusicOn is called.



void Awake() 

{

    saveController = new SaveController();

}


source: https://unity3d.com/learn/tutorials/topics/scripting/awake-and-start






share|improve this answer





















  • 2





    Also check out the Script Execution Order: docs.unity3d.com/Manual/class-MonoManager.html

    – Mathias Siig Nørregaard
    Nov 19 '18 at 20:07











  • Another option is also wrapping saveController in a property that checks if saveController is null, then constructing an instance if it is and returning saveController.

    – Mathias Siig Nørregaard
    Nov 19 '18 at 20:08






  • 1





    Thanks guys. And you'll be happy to know i've removed almost all instances of GameObject.Find. :)

    – Jimmyt1988
    Nov 19 '18 at 21:04














1












1








1







Looks like Awake was the method i was looking for.



Awake is called before Start, so doing the saveController instantiation in Awake allows for the instantiation to happen before MusicOn is called.



void Awake() 

{

    saveController = new SaveController();

}


source: https://unity3d.com/learn/tutorials/topics/scripting/awake-and-start






share|improve this answer















Looks like Awake was the method i was looking for.



Awake is called before Start, so doing the saveController instantiation in Awake allows for the instantiation to happen before MusicOn is called.



void Awake() 

{

    saveController = new SaveController();

}


source: https://unity3d.com/learn/tutorials/topics/scripting/awake-and-start







share|improve this answer














share|improve this answer



share|improve this answer








edited Nov 19 '18 at 19:31









Ruzihm

3,70611627




3,70611627










answered Nov 19 '18 at 19:28









Jimmyt1988Jimmyt1988

9,1362791164




9,1362791164








  • 2





    Also check out the Script Execution Order: docs.unity3d.com/Manual/class-MonoManager.html

    – Mathias Siig Nørregaard
    Nov 19 '18 at 20:07











  • Another option is also wrapping saveController in a property that checks if saveController is null, then constructing an instance if it is and returning saveController.

    – Mathias Siig Nørregaard
    Nov 19 '18 at 20:08






  • 1





    Thanks guys. And you'll be happy to know i've removed almost all instances of GameObject.Find. :)

    – Jimmyt1988
    Nov 19 '18 at 21:04














  • 2





    Also check out the Script Execution Order: docs.unity3d.com/Manual/class-MonoManager.html

    – Mathias Siig Nørregaard
    Nov 19 '18 at 20:07











  • Another option is also wrapping saveController in a property that checks if saveController is null, then constructing an instance if it is and returning saveController.

    – Mathias Siig Nørregaard
    Nov 19 '18 at 20:08






  • 1





    Thanks guys. And you'll be happy to know i've removed almost all instances of GameObject.Find. :)

    – Jimmyt1988
    Nov 19 '18 at 21:04








2




2





Also check out the Script Execution Order: docs.unity3d.com/Manual/class-MonoManager.html

– Mathias Siig Nørregaard
Nov 19 '18 at 20:07





Also check out the Script Execution Order: docs.unity3d.com/Manual/class-MonoManager.html

– Mathias Siig Nørregaard
Nov 19 '18 at 20:07













Another option is also wrapping saveController in a property that checks if saveController is null, then constructing an instance if it is and returning saveController.

– Mathias Siig Nørregaard
Nov 19 '18 at 20:08





Another option is also wrapping saveController in a property that checks if saveController is null, then constructing an instance if it is and returning saveController.

– Mathias Siig Nørregaard
Nov 19 '18 at 20:08




1




1





Thanks guys. And you'll be happy to know i've removed almost all instances of GameObject.Find. :)

– Jimmyt1988
Nov 19 '18 at 21:04





Thanks guys. And you'll be happy to know i've removed almost all instances of GameObject.Find. :)

– Jimmyt1988
Nov 19 '18 at 21:04




















draft saved

draft discarded




















































Thanks for contributing an answer to Stack Overflow!


  • Please be sure to answer the question. Provide details and share your research!

But avoid …



  • Asking for help, clarification, or responding to other answers.

  • Making statements based on opinion; back them up with references or personal experience.


To learn more, see our tips on writing great answers.




draft saved


draft discarded














StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53381164%2finstantiated-class-with-new-keyword-is-null-after-start-method-has-ended-and-b%23new-answer', 'question_page');
}
);

Post as a guest















Required, but never shown





















































Required, but never shown














Required, but never shown












Required, but never shown







Required, but never shown

































Required, but never shown














Required, but never shown












Required, but never shown







Required, but never shown







-

Popular posts from this blog

Guess what letter conforming each word

Image
6 $begingroup$ This is an entry in the Fortnightly Topic Challenge #41: Short and Sweet. 1 letter only could be mean anything . With an additional letter in front , could be used as medicine component and something you definitely learn or at least heard once. Add another letter in front , you would possibly hear that many times . Add an additional letter in front , you would found an independent country . With an additional letter, in the end , you would found something related to apple . Add another letter in the end , you would found something bad . Hint: Each letter is unique . word knowledge letters chemistry share | improve this question ...
Read more

Port of Spain

Image
For ports in the country of Spain, see List of ports in Spain. City in City of Port of Spain, Trinidad and Tobago Port of Spain City City of Port of Spain Top to bottom (left to right): Skyline of Port of Spain from Gulf of Paria; National Academy for the Performing Arts, Independence Square, Eric Williams Plaza; MovieTowne, Port of Port of Spain Motto(s):  "We Gather Strength As We Go Along" Port of Spain Coordinates: 10°40′N 61°31′W  /  10.667°N 61.517°W  / 10.667; -61.517 Coordinates: 10°40′N 61°31′W  /  10.667°N 61.517°W  / 10.667; -61.517 Country   Trinidad and Tobago Jurisdiction City of Port of Spain Settled 1560 Incorporated (town) 1853 Incorporated (city) 1914 Government  • Mayor Joel Martinez  • Governing body City Corporation Area [1]  • City 12 km 2 (5 sq mi) Elevation [2] 66 m (217 ft) Population (2011) [1]  • City 37,074  • Rank 3rd  • Density 3,090/km 2 (8,000/sq mi)...
Read more

Run scheduled task as local user group (not BUILTIN)

Image
0 I am trying to run a scheduled task with User Group (not a single user). This is working fine when I in the field "when running a task, use the following user account:" insert BUILTIN User Group (for example: Administrators or Users). But when I try it with the created Local User Group (example: TestGroup) it is not working. The Users in the TestGroup are the same as in the Administrators group. What could be the problem? Are there some restrictions to the Created User Group compared to BUILTINUsers? scheduled-tasks taskscheduler windowstaskschedule share | improve this question asked Nov 15 '18 at 15:36 Far...
Read more