Rails: How to update all through ActiveRecord_Relation











up vote
0
down vote

favorite












I have two related models through has_one like this:



class Asset

  has_one :device



class Device

  belongs_to :asset


I have an ActiveRecord_Relation of assets like this:



assets = Asset.all


I need to update a field in every Device for every asset. I do NOT want to create an array of every associated device since it will be very inefficient. I have tried things like:



assets.joins(:device).update_all( {:device=>{:my_field=>6} )





ruby-on-rails ruby-on-rails-5 rails-activerecord







share|improve this question


















  • 1




    Is there a reason you can't update the Device directly with Device.update_all? Are there devices that don't belong to assets?
    – Mike Gorski
    Nov 8 at 18:26










  • The Asset.all is a simplified example. In reality, the ActiveRecord_Relation is calculated through a large series of scopes based on a wide variety of search criteria. When the search is done, I am left with 100k Asset models in an ActiveRecord_Relation.
    – Elijah Hall
    Nov 8 at 21:59















up vote
0
down vote

favorite












I have two related models through has_one like this:



class Asset

  has_one :device



class Device

  belongs_to :asset


I have an ActiveRecord_Relation of assets like this:



assets = Asset.all


I need to update a field in every Device for every asset. I do NOT want to create an array of every associated device since it will be very inefficient. I have tried things like:



assets.joins(:device).update_all( {:device=>{:my_field=>6} )





ruby-on-rails ruby-on-rails-5 rails-activerecord







share|improve this question


















  • 1




    Is there a reason you can't update the Device directly with Device.update_all? Are there devices that don't belong to assets?
    – Mike Gorski
    Nov 8 at 18:26










  • The Asset.all is a simplified example. In reality, the ActiveRecord_Relation is calculated through a large series of scopes based on a wide variety of search criteria. When the search is done, I am left with 100k Asset models in an ActiveRecord_Relation.
    – Elijah Hall
    Nov 8 at 21:59













up vote
0
down vote

favorite









up vote
0
down vote

favorite











I have two related models through has_one like this:



class Asset

  has_one :device



class Device

  belongs_to :asset


I have an ActiveRecord_Relation of assets like this:



assets = Asset.all


I need to update a field in every Device for every asset. I do NOT want to create an array of every associated device since it will be very inefficient. I have tried things like:



assets.joins(:device).update_all( {:device=>{:my_field=>6} )





ruby-on-rails ruby-on-rails-5 rails-activerecord







share|improve this question













I have two related models through has_one like this:



class Asset

  has_one :device



class Device

  belongs_to :asset


I have an ActiveRecord_Relation of assets like this:



assets = Asset.all


I need to update a field in every Device for every asset. I do NOT want to create an array of every associated device since it will be very inefficient. I have tried things like:



assets.joins(:device).update_all( {:device=>{:my_field=>6} )





ruby-on-rails ruby-on-rails-5 rails-activerecord




ruby-on-rails ruby-on-rails-5 rails-activerecord






share|improve this question













share|improve this question











share|improve this question




share|improve this question










asked Nov 8 at 17:53









Elijah Hall

326




326








  • 1




    Is there a reason you can't update the Device directly with Device.update_all? Are there devices that don't belong to assets?
    – Mike Gorski
    Nov 8 at 18:26










  • The Asset.all is a simplified example. In reality, the ActiveRecord_Relation is calculated through a large series of scopes based on a wide variety of search criteria. When the search is done, I am left with 100k Asset models in an ActiveRecord_Relation.
    – Elijah Hall
    Nov 8 at 21:59














  • 1




    Is there a reason you can't update the Device directly with Device.update_all? Are there devices that don't belong to assets?
    – Mike Gorski
    Nov 8 at 18:26










  • The Asset.all is a simplified example. In reality, the ActiveRecord_Relation is calculated through a large series of scopes based on a wide variety of search criteria. When the search is done, I am left with 100k Asset models in an ActiveRecord_Relation.
    – Elijah Hall
    Nov 8 at 21:59








1




1




Is there a reason you can't update the Device directly with Device.update_all? Are there devices that don't belong to assets?
– Mike Gorski
Nov 8 at 18:26




Is there a reason you can't update the Device directly with Device.update_all? Are there devices that don't belong to assets?
– Mike Gorski
Nov 8 at 18:26












The Asset.all is a simplified example. In reality, the ActiveRecord_Relation is calculated through a large series of scopes based on a wide variety of search criteria. When the search is done, I am left with 100k Asset models in an ActiveRecord_Relation.
– Elijah Hall
Nov 8 at 21:59




The Asset.all is a simplified example. In reality, the ActiveRecord_Relation is calculated through a large series of scopes based on a wide variety of search criteria. When the search is done, I am left with 100k Asset models in an ActiveRecord_Relation.
– Elijah Hall
Nov 8 at 21:59












2 Answers
2






active

oldest

votes

















up vote
1
down vote













You can use SQL:



assets.joins(:device).update_all(["devices.my_field=?", 6])


or if that field depends on others:



assets.joins(:device).update_all("devices.my_field=assets.other_field")





share|improve this answer





















  • Your first suggestion results in: ActiveRecord::StatementInvalid: PG::UndefinedColumn: ERROR: column "devices" of relation "assets" does not exist. It used this SQL: UPDATE "assets" SET devices.os_id=6 WHERE "assets"."id" IN (SELECT "assets"."id" FROM "assets" INNER JOIN "devices" ON "devices"."asset_id" = "assets"."id")
    – Elijah Hall
    Nov 8 at 21:58




















up vote
0
down vote



accepted










The solution is this:



assets = Asset.some_scope.some_other_scope

devices = Device.where("devices.asset_id IN (?)", assets.select(:id))

devices.update_all("devices.my_field=?", 6)


This uses a single database query to update all associated devices through their relationship with assets.






share|improve this answer





















    Your Answer






    StackExchange.ifUsing("editor", function () {
    StackExchange.using("externalEditor", function () {
    StackExchange.using("snippets", function () {
    StackExchange.snippets.init();
    });
    });
    }, "code-snippets");

    StackExchange.ready(function() {
    var channelOptions = {
    tags: "".split(" "),
    id: "1"
    };
    initTagRenderer("".split(" "), "".split(" "), channelOptions);

    StackExchange.using("externalEditor", function() {
    // Have to fire editor after snippets, if snippets enabled
    if (StackExchange.settings.snippets.snippetsEnabled) {
    StackExchange.using("snippets", function() {
    createEditor();
    });
    }
    else {
    createEditor();
    }
    });

    function createEditor() {
    StackExchange.prepareEditor({
    heartbeatType: 'answer',
    convertImagesToLinks: true,
    noModals: true,
    showLowRepImageUploadWarning: true,
    reputationToPostImages: 10,
    bindNavPrevention: true,
    postfix: "",
    imageUploader: {
    brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
    contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
    allowUrls: true
    },
    onDemand: true,
    discardSelector: ".discard-answer"
    ,immediatelyShowMarkdownHelp:true
    });


    }
    });














     

    draft saved


    draft discarded


















    StackExchange.ready(
    function () {
    StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53213496%2frails-how-to-update-all-through-activerecord-relation%23new-answer', 'question_page');
    }
    );

    Post as a guest















    Required, but never shown

























    2 Answers
    2






    active

    oldest

    votes








    2 Answers
    2






    active

    oldest

    votes









    active

    oldest

    votes






    active

    oldest

    votes








    up vote
    1
    down vote













    You can use SQL:



    assets.joins(:device).update_all(["devices.my_field=?", 6])


    or if that field depends on others:



    assets.joins(:device).update_all("devices.my_field=assets.other_field")





    share|improve this answer





















    • Your first suggestion results in: ActiveRecord::StatementInvalid: PG::UndefinedColumn: ERROR: column "devices" of relation "assets" does not exist. It used this SQL: UPDATE "assets" SET devices.os_id=6 WHERE "assets"."id" IN (SELECT "assets"."id" FROM "assets" INNER JOIN "devices" ON "devices"."asset_id" = "assets"."id")
      – Elijah Hall
      Nov 8 at 21:58

















    up vote
    1
    down vote













    You can use SQL:



    assets.joins(:device).update_all(["devices.my_field=?", 6])


    or if that field depends on others:



    assets.joins(:device).update_all("devices.my_field=assets.other_field")





    share|improve this answer





















    • Your first suggestion results in: ActiveRecord::StatementInvalid: PG::UndefinedColumn: ERROR: column "devices" of relation "assets" does not exist. It used this SQL: UPDATE "assets" SET devices.os_id=6 WHERE "assets"."id" IN (SELECT "assets"."id" FROM "assets" INNER JOIN "devices" ON "devices"."asset_id" = "assets"."id")
      – Elijah Hall
      Nov 8 at 21:58















    up vote
    1
    down vote










    up vote
    1
    down vote









    You can use SQL:



    assets.joins(:device).update_all(["devices.my_field=?", 6])


    or if that field depends on others:



    assets.joins(:device).update_all("devices.my_field=assets.other_field")





    share|improve this answer












    You can use SQL:



    assets.joins(:device).update_all(["devices.my_field=?", 6])


    or if that field depends on others:



    assets.joins(:device).update_all("devices.my_field=assets.other_field")






    share|improve this answer












    share|improve this answer



    share|improve this answer










    answered Nov 8 at 18:00









    Vasfed

    7,530102633




    7,530102633












    • Your first suggestion results in: ActiveRecord::StatementInvalid: PG::UndefinedColumn: ERROR: column "devices" of relation "assets" does not exist. It used this SQL: UPDATE "assets" SET devices.os_id=6 WHERE "assets"."id" IN (SELECT "assets"."id" FROM "assets" INNER JOIN "devices" ON "devices"."asset_id" = "assets"."id")
      – Elijah Hall
      Nov 8 at 21:58




















    • Your first suggestion results in: ActiveRecord::StatementInvalid: PG::UndefinedColumn: ERROR: column "devices" of relation "assets" does not exist. It used this SQL: UPDATE "assets" SET devices.os_id=6 WHERE "assets"."id" IN (SELECT "assets"."id" FROM "assets" INNER JOIN "devices" ON "devices"."asset_id" = "assets"."id")
      – Elijah Hall
      Nov 8 at 21:58


















    Your first suggestion results in: ActiveRecord::StatementInvalid: PG::UndefinedColumn: ERROR: column "devices" of relation "assets" does not exist. It used this SQL: UPDATE "assets" SET devices.os_id=6 WHERE "assets"."id" IN (SELECT "assets"."id" FROM "assets" INNER JOIN "devices" ON "devices"."asset_id" = "assets"."id")
    – Elijah Hall
    Nov 8 at 21:58






    Your first suggestion results in: ActiveRecord::StatementInvalid: PG::UndefinedColumn: ERROR: column "devices" of relation "assets" does not exist. It used this SQL: UPDATE "assets" SET devices.os_id=6 WHERE "assets"."id" IN (SELECT "assets"."id" FROM "assets" INNER JOIN "devices" ON "devices"."asset_id" = "assets"."id")
    – Elijah Hall
    Nov 8 at 21:58














    up vote
    0
    down vote



    accepted










    The solution is this:



    assets = Asset.some_scope.some_other_scope
    
devices = Device.where("devices.asset_id IN (?)", assets.select(:id))
    
devices.update_all("devices.my_field=?", 6)


    This uses a single database query to update all associated devices through their relationship with assets.






    share|improve this answer

























      up vote
      0
      down vote



      accepted










      The solution is this:



      assets = Asset.some_scope.some_other_scope
      
devices = Device.where("devices.asset_id IN (?)", assets.select(:id))
      
devices.update_all("devices.my_field=?", 6)


      This uses a single database query to update all associated devices through their relationship with assets.






      share|improve this answer























        up vote
        0
        down vote



        accepted







        up vote
        0
        down vote



        accepted






        The solution is this:



        assets = Asset.some_scope.some_other_scope
        
devices = Device.where("devices.asset_id IN (?)", assets.select(:id))
        
devices.update_all("devices.my_field=?", 6)


        This uses a single database query to update all associated devices through their relationship with assets.






        share|improve this answer












        The solution is this:



        assets = Asset.some_scope.some_other_scope
        
devices = Device.where("devices.asset_id IN (?)", assets.select(:id))
        
devices.update_all("devices.my_field=?", 6)


        This uses a single database query to update all associated devices through their relationship with assets.







        share|improve this answer












        share|improve this answer



        share|improve this answer










        answered Nov 9 at 17:26









        Elijah Hall

        326




        326






























             

            draft saved


            draft discarded



















































             


            draft saved


            draft discarded














            StackExchange.ready(
            function () {
            StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53213496%2frails-how-to-update-all-through-activerecord-relation%23new-answer', 'question_page');
            }
            );

            Post as a guest















            Required, but never shown





















































            Required, but never shown














            Required, but never shown












            Required, but never shown







            Required, but never shown

































            Required, but never shown














            Required, but never shown












            Required, but never shown







            Required, but never shown







            -

            Popular posts from this blog

            Guess what letter conforming each word

            Image
            6 $begingroup$ This is an entry in the Fortnightly Topic Challenge #41: Short and Sweet. 1 letter only could be mean anything . With an additional letter in front , could be used as medicine component and something you definitely learn or at least heard once. Add another letter in front , you would possibly hear that many times . Add an additional letter in front , you would found an independent country . With an additional letter, in the end , you would found something related to apple . Add another letter in the end , you would found something bad . Hint: Each letter is unique . word knowledge letters chemistry share | improve this question ...
            Read more

            Port of Spain

            Image
            For ports in the country of Spain, see List of ports in Spain. City in City of Port of Spain, Trinidad and Tobago Port of Spain City City of Port of Spain Top to bottom (left to right): Skyline of Port of Spain from Gulf of Paria; National Academy for the Performing Arts, Independence Square, Eric Williams Plaza; MovieTowne, Port of Port of Spain Motto(s):  "We Gather Strength As We Go Along" Port of Spain Coordinates: 10°40′N 61°31′W  /  10.667°N 61.517°W  / 10.667; -61.517 Coordinates: 10°40′N 61°31′W  /  10.667°N 61.517°W  / 10.667; -61.517 Country   Trinidad and Tobago Jurisdiction City of Port of Spain Settled 1560 Incorporated (town) 1853 Incorporated (city) 1914 Government  • Mayor Joel Martinez  • Governing body City Corporation Area [1]  • City 12 km 2 (5 sq mi) Elevation [2] 66 m (217 ft) Population (2011) [1]  • City 37,074  • Rank 3rd  • Density 3,090/km 2 (8,000/sq mi)...
            Read more

            Run scheduled task as local user group (not BUILTIN)

            Image
            0 I am trying to run a scheduled task with User Group (not a single user). This is working fine when I in the field "when running a task, use the following user account:" insert BUILTIN User Group (for example: Administrators or Users). But when I try it with the created Local User Group (example: TestGroup) it is not working. The Users in the TestGroup are the same as in the Administrators group. What could be the problem? Are there some restrictions to the Created User Group compared to BUILTINUsers? scheduled-tasks taskscheduler windowstaskschedule share | improve this question asked Nov 15 '18 at 15:36 Far...
            Read more