Validate only when value is changing
1
I'm using Sequelize 4.38.0 and have the custom validation for email on the User model.
The way the custom validation is constructed (see below), I need to skip the validation if the email property hasn't changed. Otherwise it halts the whole update operation (as it thinks the email address is already taken).
How can I run validation for a property only when the value is changing?
email: {
type: DataTypes.STRING,
allowNull: false,
validate: {
isEmail: {
msg: 'Wrong email format',
},
notEmpty: {
msg: 'Email has to be present',
},
isUnique: function(value, next) {
User.find({
where: {
email: value,
organizationId: this.organizationId,
},
})
.then(function(result) {
if (result === null) {
return next()
} else {
return next(' Email address already in use')
}
})
.catch(err => {
return next()
})
},
},
},
node.js validation sequelize.js
asked Nov 13 at 14:40
Fellow Stranger
6,17995584
add a comment |
1
I'm using Sequelize 4.38.0 and have the custom validation for email on the User model.
The way the custom validation is constructed (see below), I need to skip the validation if the email property hasn't changed. Otherwise it halts the whole update operation (as it thinks the email address is already taken).
How can I run validation for a property only when the value is changing?
email: {
type: DataTypes.STRING,
allowNull: false,
validate: {
isEmail: {
msg: 'Wrong email format',
},
notEmpty: {
msg: 'Email has to be present',
},
isUnique: function(value, next) {
User.find({
where: {
email: value,
organizationId: this.organizationId,
},
})
.then(function(result) {
if (result === null) {
return next()
} else {
return next(' Email address already in use')
}
})
.catch(err => {
return next()
})
},
},
},
node.js validation sequelize.js
asked Nov 13 at 14:40
Fellow Stranger
6,17995584
what do you mean by "it's run all the time" ?
– mihai
Nov 13 at 19:52
@mihai I've updated the description. The custom email validation is run on every update operation of an user instance. And I wonder if it's possible to skip that custom validation when the email value isn't changing?
– Fellow Stranger
Nov 13 at 21:35
add a comment |
1
1
1
I'm using Sequelize 4.38.0 and have the custom validation for email on the User model.
The way the custom validation is constructed (see below), I need to skip the validation if the email property hasn't changed. Otherwise it halts the whole update operation (as it thinks the email address is already taken).
How can I run validation for a property only when the value is changing?
email: {
type: DataTypes.STRING,
allowNull: false,
validate: {
isEmail: {
msg: 'Wrong email format',
},
notEmpty: {
msg: 'Email has to be present',
},
isUnique: function(value, next) {
User.find({
where: {
email: value,
organizationId: this.organizationId,
},
})
.then(function(result) {
if (result === null) {
return next()
} else {
return next(' Email address already in use')
}
})
.catch(err => {
return next()
})
},
},
},
node.js validation sequelize.js
asked Nov 13 at 14:40
Fellow Stranger
6,17995584
I'm using Sequelize 4.38.0 and have the custom validation for email on the User model.
The way the custom validation is constructed (see below), I need to skip the validation if the email property hasn't changed. Otherwise it halts the whole update operation (as it thinks the email address is already taken).
How can I run validation for a property only when the value is changing?
email: {
type: DataTypes.STRING,
allowNull: false,
validate: {
isEmail: {
msg: 'Wrong email format',
},
notEmpty: {
msg: 'Email has to be present',
},
isUnique: function(value, next) {
User.find({
where: {
email: value,
organizationId: this.organizationId,
},
})
.then(function(result) {
if (result === null) {
return next()
} else {
return next(' Email address already in use')
}
})
.catch(err => {
return next()
})
},
},
},
node.js validation sequelize.js
node.js validation sequelize.js
asked Nov 13 at 14:40
Fellow Stranger
6,17995584
asked Nov 13 at 14:40
Fellow Stranger
6,17995584
edited Nov 13 at 21:33
asked Nov 13 at 14:40
Fellow Stranger
6,17995584
asked Nov 13 at 14:40
Fellow Stranger
6,17995584
asked Nov 13 at 14:40
Fellow Stranger
6,17995584
6,17995584
what do you mean by "it's run all the time" ?
– mihai
Nov 13 at 19:52
@mihai I've updated the description. The custom email validation is run on every update operation of an user instance. And I wonder if it's possible to skip that custom validation when the email value isn't changing?
– Fellow Stranger
Nov 13 at 21:35
add a comment |
what do you mean by "it's run all the time" ?
– mihai
Nov 13 at 19:52
@mihai I've updated the description. The custom email validation is run on every update operation of an user instance. And I wonder if it's possible to skip that custom validation when the email value isn't changing?
– Fellow Stranger
Nov 13 at 21:35
what do you mean by "it's run all the time" ?
– mihai
Nov 13 at 19:52
what do you mean by "it's run all the time" ?
– mihai
Nov 13 at 19:52
@mihai I've updated the description. The custom email validation is run on every update operation of an user instance. And I wonder if it's possible to skip that custom validation when the email value isn't changing?
– Fellow Stranger
Nov 13 at 21:35
@mihai I've updated the description. The custom email validation is run on every update operation of an user instance. And I wonder if it's possible to skip that custom validation when the email value isn't changing?
– Fellow Stranger
Nov 13 at 21:35
add a comment |
1 Answer
1
active
oldest
votes
0
Solved it with a conditional like this:
isUnique: function(value, next) {
if (this.changed('email')) {
User.find({
where: {
email: value,
organizationId: this.organizationId,
},
})
.then(function(result) {
if (result === null) {
return next()
} else {
return next(' Email address already in use')
}
})
.catch(err => {
return next()
})
} else {
next()
}
},
answered Nov 14 at 9:21
Fellow Stranger
6,17995584
add a comment |
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53283446%2fvalidate-only-when-value-is-changing%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
1 Answer
1
active
oldest
votes
1 Answer
1
active
oldest
votes
active
oldest
votes
active
oldest
votes
0
Solved it with a conditional like this:
isUnique: function(value, next) {
if (this.changed('email')) {
User.find({
where: {
email: value,
organizationId: this.organizationId,
},
})
.then(function(result) {
if (result === null) {
return next()
} else {
return next(' Email address already in use')
}
})
.catch(err => {
return next()
})
} else {
next()
}
},
answered Nov 14 at 9:21
Fellow Stranger
6,17995584
add a comment |
0
Solved it with a conditional like this:
isUnique: function(value, next) {
if (this.changed('email')) {
User.find({
where: {
email: value,
organizationId: this.organizationId,
},
})
.then(function(result) {
if (result === null) {
return next()
} else {
return next(' Email address already in use')
}
})
.catch(err => {
return next()
})
} else {
next()
}
},
answered Nov 14 at 9:21
Fellow Stranger
6,17995584
add a comment |
0
0
0
Solved it with a conditional like this:
isUnique: function(value, next) {
if (this.changed('email')) {
User.find({
where: {
email: value,
organizationId: this.organizationId,
},
})
.then(function(result) {
if (result === null) {
return next()
} else {
return next(' Email address already in use')
}
})
.catch(err => {
return next()
})
} else {
next()
}
},
answered Nov 14 at 9:21
Fellow Stranger
6,17995584
Solved it with a conditional like this:
isUnique: function(value, next) {
if (this.changed('email')) {
User.find({
where: {
email: value,
organizationId: this.organizationId,
},
})
.then(function(result) {
if (result === null) {
return next()
} else {
return next(' Email address already in use')
}
})
.catch(err => {
return next()
})
} else {
next()
}
},
answered Nov 14 at 9:21
Fellow Stranger
6,17995584
answered Nov 14 at 9:21
Fellow Stranger
6,17995584
answered Nov 14 at 9:21
Fellow Stranger
6,17995584
answered Nov 14 at 9:21
Fellow Stranger
6,17995584
6,17995584
add a comment |
add a comment |
draft saved
draft discarded
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Some of your past answers have not been well-received, and you're in danger of being blocked from answering.
Please pay close attention to the following guidance:
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53283446%2fvalidate-only-when-value-is-changing%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
what do you mean by "it's run all the time" ?
– mihai
Nov 13 at 19:52
@mihai I've updated the description. The custom email validation is run on every update operation of an user instance. And I wonder if it's possible to skip that custom validation when the email value isn't changing?
– Fellow Stranger
Nov 13 at 21:35