JavaScript variable value gets overwritten when checking for “undefined”
I have a function that gets called in two different scenarios.
Scenario 1 gets triggered by a dropbown selection, and I set the variable "sheetName" based on the selected value.
Scenario 2 doesn't have a trigger event, so I want to set the variable further down in my code when I gathered the other information I need in order to set the value.
Now here's my problem: When Scenario 1 occurs, sheetName gets defined and the function proceeds. But with the code below, sheetName appears to be undefined as soon as it reaches the if condition for the second code. So the value gets overwritten here because the program thinks, sheetName is undefined.
Whenever I remove the if condition for the second scenario everything works fine and sheetName has the correct value I defined earlier in the code.
I can't define the two values within an if/else statement because for the first scenario I need the oEvent and for the second scenario I need the wb data..
Why does the if condition remove the value of my variable? Am I checking incorrectly?
Please let me know if you need anything else!
onSheetSelected : function(oEvent) {
var file = sap.ui.getCore()._file;
var oTable = this.getView().byId('uploadData');
// Sheet name gets defined for Scenario 1
if(oEvent !== undefined) {
var sheetName = oEvent.getSource().getSelectedItem().getText();
}
if(file && window.FileReader){
var reader = new FileReader();
var result = {}, data;
reader.readAsBinaryString(file);
reader.onload = function(e) {
var rawLog = reader.result;
data = e.target.result;
var wb = XLSX.read(data, {type: 'binary', cellDates: true, cellText: false, cellNF: true});
// Sheetname gets defined for Scenario 2
if(sheetName === undefined) {
var sheetName = wb.SheetNames[0];
}
var worksheet = wb.Sheets[sheetName];
... some other stuff going on...
}.bind(this);
};
},
javascript if-statement override undefined variable-declaration
asked Nov 21 '18 at 14:30
sonjasonja
388217
add a comment |
I have a function that gets called in two different scenarios.
Scenario 1 gets triggered by a dropbown selection, and I set the variable "sheetName" based on the selected value.
Scenario 2 doesn't have a trigger event, so I want to set the variable further down in my code when I gathered the other information I need in order to set the value.
Now here's my problem: When Scenario 1 occurs, sheetName gets defined and the function proceeds. But with the code below, sheetName appears to be undefined as soon as it reaches the if condition for the second code. So the value gets overwritten here because the program thinks, sheetName is undefined.
Whenever I remove the if condition for the second scenario everything works fine and sheetName has the correct value I defined earlier in the code.
I can't define the two values within an if/else statement because for the first scenario I need the oEvent and for the second scenario I need the wb data..
Why does the if condition remove the value of my variable? Am I checking incorrectly?
Please let me know if you need anything else!
onSheetSelected : function(oEvent) {
var file = sap.ui.getCore()._file;
var oTable = this.getView().byId('uploadData');
// Sheet name gets defined for Scenario 1
if(oEvent !== undefined) {
var sheetName = oEvent.getSource().getSelectedItem().getText();
}
if(file && window.FileReader){
var reader = new FileReader();
var result = {}, data;
reader.readAsBinaryString(file);
reader.onload = function(e) {
var rawLog = reader.result;
data = e.target.result;
var wb = XLSX.read(data, {type: 'binary', cellDates: true, cellText: false, cellNF: true});
// Sheetname gets defined for Scenario 2
if(sheetName === undefined) {
var sheetName = wb.SheetNames[0];
}
var worksheet = wb.Sheets[sheetName];
... some other stuff going on...
}.bind(this);
};
},
javascript if-statement override undefined variable-declaration
asked Nov 21 '18 at 14:30
sonjasonja
388217
1
You're re-declaring the variable, in Scenario 2, remove thevar
– George
Nov 21 '18 at 14:34
add a comment |
I have a function that gets called in two different scenarios.
Scenario 1 gets triggered by a dropbown selection, and I set the variable "sheetName" based on the selected value.
Scenario 2 doesn't have a trigger event, so I want to set the variable further down in my code when I gathered the other information I need in order to set the value.
Now here's my problem: When Scenario 1 occurs, sheetName gets defined and the function proceeds. But with the code below, sheetName appears to be undefined as soon as it reaches the if condition for the second code. So the value gets overwritten here because the program thinks, sheetName is undefined.
Whenever I remove the if condition for the second scenario everything works fine and sheetName has the correct value I defined earlier in the code.
I can't define the two values within an if/else statement because for the first scenario I need the oEvent and for the second scenario I need the wb data..
Why does the if condition remove the value of my variable? Am I checking incorrectly?
Please let me know if you need anything else!
onSheetSelected : function(oEvent) {
var file = sap.ui.getCore()._file;
var oTable = this.getView().byId('uploadData');
// Sheet name gets defined for Scenario 1
if(oEvent !== undefined) {
var sheetName = oEvent.getSource().getSelectedItem().getText();
}
if(file && window.FileReader){
var reader = new FileReader();
var result = {}, data;
reader.readAsBinaryString(file);
reader.onload = function(e) {
var rawLog = reader.result;
data = e.target.result;
var wb = XLSX.read(data, {type: 'binary', cellDates: true, cellText: false, cellNF: true});
// Sheetname gets defined for Scenario 2
if(sheetName === undefined) {
var sheetName = wb.SheetNames[0];
}
var worksheet = wb.Sheets[sheetName];
... some other stuff going on...
}.bind(this);
};
},
javascript if-statement override undefined variable-declaration
asked Nov 21 '18 at 14:30
sonjasonja
388217
I have a function that gets called in two different scenarios.
Scenario 1 gets triggered by a dropbown selection, and I set the variable "sheetName" based on the selected value.
Scenario 2 doesn't have a trigger event, so I want to set the variable further down in my code when I gathered the other information I need in order to set the value.
Now here's my problem: When Scenario 1 occurs, sheetName gets defined and the function proceeds. But with the code below, sheetName appears to be undefined as soon as it reaches the if condition for the second code. So the value gets overwritten here because the program thinks, sheetName is undefined.
Whenever I remove the if condition for the second scenario everything works fine and sheetName has the correct value I defined earlier in the code.
I can't define the two values within an if/else statement because for the first scenario I need the oEvent and for the second scenario I need the wb data..
Why does the if condition remove the value of my variable? Am I checking incorrectly?
Please let me know if you need anything else!
onSheetSelected : function(oEvent) {
var file = sap.ui.getCore()._file;
var oTable = this.getView().byId('uploadData');
// Sheet name gets defined for Scenario 1
if(oEvent !== undefined) {
var sheetName = oEvent.getSource().getSelectedItem().getText();
}
if(file && window.FileReader){
var reader = new FileReader();
var result = {}, data;
reader.readAsBinaryString(file);
reader.onload = function(e) {
var rawLog = reader.result;
data = e.target.result;
var wb = XLSX.read(data, {type: 'binary', cellDates: true, cellText: false, cellNF: true});
// Sheetname gets defined for Scenario 2
if(sheetName === undefined) {
var sheetName = wb.SheetNames[0];
}
var worksheet = wb.Sheets[sheetName];
... some other stuff going on...
}.bind(this);
};
},
javascript if-statement override undefined variable-declaration
javascript if-statement override undefined variable-declaration
asked Nov 21 '18 at 14:30
sonjasonja
388217
asked Nov 21 '18 at 14:30
sonjasonja
388217
asked Nov 21 '18 at 14:30
sonjasonja
388217
asked Nov 21 '18 at 14:30
sonjasonja
388217
asked Nov 21 '18 at 14:30
sonjasonja
388217
388217
1
You're re-declaring the variable, in Scenario 2, remove thevar
– George
Nov 21 '18 at 14:34
add a comment |
1
You're re-declaring the variable, in Scenario 2, remove thevar
– George
Nov 21 '18 at 14:34
1
1
You're re-declaring the variable, in Scenario 2, remove the
var– George
Nov 21 '18 at 14:34
You're re-declaring the variable, in Scenario 2, remove the
var– George
Nov 21 '18 at 14:34
add a comment |
1 Answer
1
active
oldest
votes
You're running into this issue due to JavaScript Hoisting the variable where you're re-declaring it in the second scenario
function thing1() {
var sheetname = "this"
//this will look at thing1.sheetname
console.log(sheetname)
function thing2() {
// this will look at thing2.sheetname
if (sheetname === undefined) {
var sheetname = "that"
}
console.log(sheetname)
}
thing2()
}
thing1()But by removing the var it will look up until it can find a variable called sheetname
function thing1() {
var sheetname = "this"
//this will look at thing1.sheetname
console.log(sheetname)
function thing2() {
// this will look at thing1.sheetname
if (sheetname === undefined) {
sheetname = "that"
}
console.log(sheetname)
}
thing2()
}
thing1()answered Nov 21 '18 at 14:41
GeorgeGeorge
4,56811832
thanks a lot I knew it must be something like this!
– sonja
Nov 21 '18 at 15:24
add a comment |
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53414330%2fjavascript-variable-value-gets-overwritten-when-checking-for-undefined%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
1 Answer
1
active
oldest
votes
1 Answer
1
active
oldest
votes
active
oldest
votes
active
oldest
votes
You're running into this issue due to JavaScript Hoisting the variable where you're re-declaring it in the second scenario
function thing1() {
var sheetname = "this"
//this will look at thing1.sheetname
console.log(sheetname)
function thing2() {
// this will look at thing2.sheetname
if (sheetname === undefined) {
var sheetname = "that"
}
console.log(sheetname)
}
thing2()
}
thing1()But by removing the var it will look up until it can find a variable called sheetname
function thing1() {
var sheetname = "this"
//this will look at thing1.sheetname
console.log(sheetname)
function thing2() {
// this will look at thing1.sheetname
if (sheetname === undefined) {
sheetname = "that"
}
console.log(sheetname)
}
thing2()
}
thing1()answered Nov 21 '18 at 14:41
GeorgeGeorge
4,56811832
thanks a lot I knew it must be something like this!
– sonja
Nov 21 '18 at 15:24
add a comment |
You're running into this issue due to JavaScript Hoisting the variable where you're re-declaring it in the second scenario
function thing1() {
var sheetname = "this"
//this will look at thing1.sheetname
console.log(sheetname)
function thing2() {
// this will look at thing2.sheetname
if (sheetname === undefined) {
var sheetname = "that"
}
console.log(sheetname)
}
thing2()
}
thing1()But by removing the var it will look up until it can find a variable called sheetname
function thing1() {
var sheetname = "this"
//this will look at thing1.sheetname
console.log(sheetname)
function thing2() {
// this will look at thing1.sheetname
if (sheetname === undefined) {
sheetname = "that"
}
console.log(sheetname)
}
thing2()
}
thing1()answered Nov 21 '18 at 14:41
GeorgeGeorge
4,56811832
thanks a lot I knew it must be something like this!
– sonja
Nov 21 '18 at 15:24
add a comment |
You're running into this issue due to JavaScript Hoisting the variable where you're re-declaring it in the second scenario
function thing1() {
var sheetname = "this"
//this will look at thing1.sheetname
console.log(sheetname)
function thing2() {
// this will look at thing2.sheetname
if (sheetname === undefined) {
var sheetname = "that"
}
console.log(sheetname)
}
thing2()
}
thing1()But by removing the var it will look up until it can find a variable called sheetname
function thing1() {
var sheetname = "this"
//this will look at thing1.sheetname
console.log(sheetname)
function thing2() {
// this will look at thing1.sheetname
if (sheetname === undefined) {
sheetname = "that"
}
console.log(sheetname)
}
thing2()
}
thing1()answered Nov 21 '18 at 14:41
GeorgeGeorge
4,56811832
You're running into this issue due to JavaScript Hoisting the variable where you're re-declaring it in the second scenario
function thing1() {
var sheetname = "this"
//this will look at thing1.sheetname
console.log(sheetname)
function thing2() {
// this will look at thing2.sheetname
if (sheetname === undefined) {
var sheetname = "that"
}
console.log(sheetname)
}
thing2()
}
thing1()But by removing the var it will look up until it can find a variable called sheetname
function thing1() {
var sheetname = "this"
//this will look at thing1.sheetname
console.log(sheetname)
function thing2() {
// this will look at thing1.sheetname
if (sheetname === undefined) {
sheetname = "that"
}
console.log(sheetname)
}
thing2()
}
thing1()function thing1() {
var sheetname = "this"
//this will look at thing1.sheetname
console.log(sheetname)
function thing2() {
// this will look at thing2.sheetname
if (sheetname === undefined) {
var sheetname = "that"
}
console.log(sheetname)
}
thing2()
}
thing1()function thing1() {
var sheetname = "this"
//this will look at thing1.sheetname
console.log(sheetname)
function thing2() {
// this will look at thing2.sheetname
if (sheetname === undefined) {
var sheetname = "that"
}
console.log(sheetname)
}
thing2()
}
thing1()function thing1() {
var sheetname = "this"
//this will look at thing1.sheetname
console.log(sheetname)
function thing2() {
// this will look at thing1.sheetname
if (sheetname === undefined) {
sheetname = "that"
}
console.log(sheetname)
}
thing2()
}
thing1()function thing1() {
var sheetname = "this"
//this will look at thing1.sheetname
console.log(sheetname)
function thing2() {
// this will look at thing1.sheetname
if (sheetname === undefined) {
sheetname = "that"
}
console.log(sheetname)
}
thing2()
}
thing1()answered Nov 21 '18 at 14:41
GeorgeGeorge
4,56811832
answered Nov 21 '18 at 14:41
GeorgeGeorge
4,56811832
answered Nov 21 '18 at 14:41
GeorgeGeorge
4,56811832
answered Nov 21 '18 at 14:41
GeorgeGeorge
4,56811832
4,56811832
thanks a lot I knew it must be something like this!
– sonja
Nov 21 '18 at 15:24
add a comment |
thanks a lot I knew it must be something like this!
– sonja
Nov 21 '18 at 15:24
thanks a lot I knew it must be something like this!
– sonja
Nov 21 '18 at 15:24
thanks a lot I knew it must be something like this!
– sonja
Nov 21 '18 at 15:24
add a comment |
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53414330%2fjavascript-variable-value-gets-overwritten-when-checking-for-undefined%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
1
You're re-declaring the variable, in Scenario 2, remove the
var– George
Nov 21 '18 at 14:34