How to properly mock queue operation in unit test with Mockito?












0















I have a class like this. The start method will be called in another class(like pre-load class)



public class Processor implements Runnable{

private PersistantQueue<object> m_persistentQueue;
private Thread m_thread;

//this class is a singleton class

protected int getQueueSize() {
return m_persistentQueue.size();
}


protected void addToQueue(Object object) {
m_persistentQueue.add(object);
}


public void start() {
m_persistentQueue = new PersistantQueue<object>("queueName");
m_thread = new Thread(new Processor());
m_thread.start();
}
//run method......
}


And this is the unit test



  public class AuditEventProcessorTest {

private Processor m_processor

@Before
public void setup() {
m_Processor = Processor.getProcessorInstance();
m_Processor.start();
}
@After
//some cleanup after adding items to the queue


@Test
public void addToQueue_addSuccessfully() {
m_Processor.addToQueue(someMockObject);
assertEquals(1, m_Processor.getQueueSize());
}
}


I call the real method to add items to the queue. But now I want to mock the queue just test logic. I don't want to add items to the queue in the unit test. How can I properly mock the queue? Try to mock but get null pointer exception. I can only use Mockito. Please help me. Thanks!










share|improve this question























  • I think the answer to your question might be contained in my article here

    – Dawood ibn Kareem
    Nov 21 '18 at 18:41











  • You can extract the behaviour of Processor class into an interface and mock its methods if it is the requirement. Remember that, unit test is mostly about the concept of testing business requirements.

    – Emre Savcı
    Nov 21 '18 at 19:04
















0















I have a class like this. The start method will be called in another class(like pre-load class)



public class Processor implements Runnable{

private PersistantQueue<object> m_persistentQueue;
private Thread m_thread;

//this class is a singleton class

protected int getQueueSize() {
return m_persistentQueue.size();
}


protected void addToQueue(Object object) {
m_persistentQueue.add(object);
}


public void start() {
m_persistentQueue = new PersistantQueue<object>("queueName");
m_thread = new Thread(new Processor());
m_thread.start();
}
//run method......
}


And this is the unit test



  public class AuditEventProcessorTest {

private Processor m_processor

@Before
public void setup() {
m_Processor = Processor.getProcessorInstance();
m_Processor.start();
}
@After
//some cleanup after adding items to the queue


@Test
public void addToQueue_addSuccessfully() {
m_Processor.addToQueue(someMockObject);
assertEquals(1, m_Processor.getQueueSize());
}
}


I call the real method to add items to the queue. But now I want to mock the queue just test logic. I don't want to add items to the queue in the unit test. How can I properly mock the queue? Try to mock but get null pointer exception. I can only use Mockito. Please help me. Thanks!










share|improve this question























  • I think the answer to your question might be contained in my article here

    – Dawood ibn Kareem
    Nov 21 '18 at 18:41











  • You can extract the behaviour of Processor class into an interface and mock its methods if it is the requirement. Remember that, unit test is mostly about the concept of testing business requirements.

    – Emre Savcı
    Nov 21 '18 at 19:04














0












0








0








I have a class like this. The start method will be called in another class(like pre-load class)



public class Processor implements Runnable{

private PersistantQueue<object> m_persistentQueue;
private Thread m_thread;

//this class is a singleton class

protected int getQueueSize() {
return m_persistentQueue.size();
}


protected void addToQueue(Object object) {
m_persistentQueue.add(object);
}


public void start() {
m_persistentQueue = new PersistantQueue<object>("queueName");
m_thread = new Thread(new Processor());
m_thread.start();
}
//run method......
}


And this is the unit test



  public class AuditEventProcessorTest {

private Processor m_processor

@Before
public void setup() {
m_Processor = Processor.getProcessorInstance();
m_Processor.start();
}
@After
//some cleanup after adding items to the queue


@Test
public void addToQueue_addSuccessfully() {
m_Processor.addToQueue(someMockObject);
assertEquals(1, m_Processor.getQueueSize());
}
}


I call the real method to add items to the queue. But now I want to mock the queue just test logic. I don't want to add items to the queue in the unit test. How can I properly mock the queue? Try to mock but get null pointer exception. I can only use Mockito. Please help me. Thanks!










share|improve this question














I have a class like this. The start method will be called in another class(like pre-load class)



public class Processor implements Runnable{

private PersistantQueue<object> m_persistentQueue;
private Thread m_thread;

//this class is a singleton class

protected int getQueueSize() {
return m_persistentQueue.size();
}


protected void addToQueue(Object object) {
m_persistentQueue.add(object);
}


public void start() {
m_persistentQueue = new PersistantQueue<object>("queueName");
m_thread = new Thread(new Processor());
m_thread.start();
}
//run method......
}


And this is the unit test



  public class AuditEventProcessorTest {

private Processor m_processor

@Before
public void setup() {
m_Processor = Processor.getProcessorInstance();
m_Processor.start();
}
@After
//some cleanup after adding items to the queue


@Test
public void addToQueue_addSuccessfully() {
m_Processor.addToQueue(someMockObject);
assertEquals(1, m_Processor.getQueueSize());
}
}


I call the real method to add items to the queue. But now I want to mock the queue just test logic. I don't want to add items to the queue in the unit test. How can I properly mock the queue? Try to mock but get null pointer exception. I can only use Mockito. Please help me. Thanks!







java unit-testing junit mockito






share|improve this question













share|improve this question











share|improve this question




share|improve this question










asked Nov 21 '18 at 18:24









HenlenLeeHenlenLee

958




958













  • I think the answer to your question might be contained in my article here

    – Dawood ibn Kareem
    Nov 21 '18 at 18:41











  • You can extract the behaviour of Processor class into an interface and mock its methods if it is the requirement. Remember that, unit test is mostly about the concept of testing business requirements.

    – Emre Savcı
    Nov 21 '18 at 19:04



















  • I think the answer to your question might be contained in my article here

    – Dawood ibn Kareem
    Nov 21 '18 at 18:41











  • You can extract the behaviour of Processor class into an interface and mock its methods if it is the requirement. Remember that, unit test is mostly about the concept of testing business requirements.

    – Emre Savcı
    Nov 21 '18 at 19:04

















I think the answer to your question might be contained in my article here

– Dawood ibn Kareem
Nov 21 '18 at 18:41





I think the answer to your question might be contained in my article here

– Dawood ibn Kareem
Nov 21 '18 at 18:41













You can extract the behaviour of Processor class into an interface and mock its methods if it is the requirement. Remember that, unit test is mostly about the concept of testing business requirements.

– Emre Savcı
Nov 21 '18 at 19:04





You can extract the behaviour of Processor class into an interface and mock its methods if it is the requirement. Remember that, unit test is mostly about the concept of testing business requirements.

– Emre Savcı
Nov 21 '18 at 19:04












1 Answer
1






active

oldest

votes


















0














SingleTon pattern are kind of complex to unit-test. In your case it is more complex as you have completely hidden queue creation logic. Would suggest to do some refactoring and allow injection and use spring(if using spring) managed singleton(if you need singleton only) beans. Dependency Injection makes unit testing much easier.



If you want to carry on with same implementation as in question then below is the example but you need to use PowerMockito.



@RunWith(PowerMockRunner.class)
@PrepareForTest(Processor.class)
public class ProcessorTest {

private Processor processor;
@Test
public void test() throws Exception {
Processor processor = Processor.getInstance();
ArrayBlockingQueue arrayBlockingQueue = Mockito.mock(ArrayBlockingQueue.class);

PowerMockito.whenNew(ArrayBlockingQueue.class).withAnyArguments().thenReturn(arrayBlockingQueue);

processor.start();

//now you have successfully inject mocked arrayBlockQueue in Processor and can play around with it as usual with any mock object.
}
}


Just ArrayBlockingQueue with your PersistantQueue.



Hope this helps.






share|improve this answer
























    Your Answer






    StackExchange.ifUsing("editor", function () {
    StackExchange.using("externalEditor", function () {
    StackExchange.using("snippets", function () {
    StackExchange.snippets.init();
    });
    });
    }, "code-snippets");

    StackExchange.ready(function() {
    var channelOptions = {
    tags: "".split(" "),
    id: "1"
    };
    initTagRenderer("".split(" "), "".split(" "), channelOptions);

    StackExchange.using("externalEditor", function() {
    // Have to fire editor after snippets, if snippets enabled
    if (StackExchange.settings.snippets.snippetsEnabled) {
    StackExchange.using("snippets", function() {
    createEditor();
    });
    }
    else {
    createEditor();
    }
    });

    function createEditor() {
    StackExchange.prepareEditor({
    heartbeatType: 'answer',
    autoActivateHeartbeat: false,
    convertImagesToLinks: true,
    noModals: true,
    showLowRepImageUploadWarning: true,
    reputationToPostImages: 10,
    bindNavPrevention: true,
    postfix: "",
    imageUploader: {
    brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
    contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
    allowUrls: true
    },
    onDemand: true,
    discardSelector: ".discard-answer"
    ,immediatelyShowMarkdownHelp:true
    });


    }
    });














    draft saved

    draft discarded


















    StackExchange.ready(
    function () {
    StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53418366%2fhow-to-properly-mock-queue-operation-in-unit-test-with-mockito%23new-answer', 'question_page');
    }
    );

    Post as a guest















    Required, but never shown

























    1 Answer
    1






    active

    oldest

    votes








    1 Answer
    1






    active

    oldest

    votes









    active

    oldest

    votes






    active

    oldest

    votes









    0














    SingleTon pattern are kind of complex to unit-test. In your case it is more complex as you have completely hidden queue creation logic. Would suggest to do some refactoring and allow injection and use spring(if using spring) managed singleton(if you need singleton only) beans. Dependency Injection makes unit testing much easier.



    If you want to carry on with same implementation as in question then below is the example but you need to use PowerMockito.



    @RunWith(PowerMockRunner.class)
    @PrepareForTest(Processor.class)
    public class ProcessorTest {

    private Processor processor;
    @Test
    public void test() throws Exception {
    Processor processor = Processor.getInstance();
    ArrayBlockingQueue arrayBlockingQueue = Mockito.mock(ArrayBlockingQueue.class);

    PowerMockito.whenNew(ArrayBlockingQueue.class).withAnyArguments().thenReturn(arrayBlockingQueue);

    processor.start();

    //now you have successfully inject mocked arrayBlockQueue in Processor and can play around with it as usual with any mock object.
    }
    }


    Just ArrayBlockingQueue with your PersistantQueue.



    Hope this helps.






    share|improve this answer




























      0














      SingleTon pattern are kind of complex to unit-test. In your case it is more complex as you have completely hidden queue creation logic. Would suggest to do some refactoring and allow injection and use spring(if using spring) managed singleton(if you need singleton only) beans. Dependency Injection makes unit testing much easier.



      If you want to carry on with same implementation as in question then below is the example but you need to use PowerMockito.



      @RunWith(PowerMockRunner.class)
      @PrepareForTest(Processor.class)
      public class ProcessorTest {

      private Processor processor;
      @Test
      public void test() throws Exception {
      Processor processor = Processor.getInstance();
      ArrayBlockingQueue arrayBlockingQueue = Mockito.mock(ArrayBlockingQueue.class);

      PowerMockito.whenNew(ArrayBlockingQueue.class).withAnyArguments().thenReturn(arrayBlockingQueue);

      processor.start();

      //now you have successfully inject mocked arrayBlockQueue in Processor and can play around with it as usual with any mock object.
      }
      }


      Just ArrayBlockingQueue with your PersistantQueue.



      Hope this helps.






      share|improve this answer


























        0












        0








        0







        SingleTon pattern are kind of complex to unit-test. In your case it is more complex as you have completely hidden queue creation logic. Would suggest to do some refactoring and allow injection and use spring(if using spring) managed singleton(if you need singleton only) beans. Dependency Injection makes unit testing much easier.



        If you want to carry on with same implementation as in question then below is the example but you need to use PowerMockito.



        @RunWith(PowerMockRunner.class)
        @PrepareForTest(Processor.class)
        public class ProcessorTest {

        private Processor processor;
        @Test
        public void test() throws Exception {
        Processor processor = Processor.getInstance();
        ArrayBlockingQueue arrayBlockingQueue = Mockito.mock(ArrayBlockingQueue.class);

        PowerMockito.whenNew(ArrayBlockingQueue.class).withAnyArguments().thenReturn(arrayBlockingQueue);

        processor.start();

        //now you have successfully inject mocked arrayBlockQueue in Processor and can play around with it as usual with any mock object.
        }
        }


        Just ArrayBlockingQueue with your PersistantQueue.



        Hope this helps.






        share|improve this answer













        SingleTon pattern are kind of complex to unit-test. In your case it is more complex as you have completely hidden queue creation logic. Would suggest to do some refactoring and allow injection and use spring(if using spring) managed singleton(if you need singleton only) beans. Dependency Injection makes unit testing much easier.



        If you want to carry on with same implementation as in question then below is the example but you need to use PowerMockito.



        @RunWith(PowerMockRunner.class)
        @PrepareForTest(Processor.class)
        public class ProcessorTest {

        private Processor processor;
        @Test
        public void test() throws Exception {
        Processor processor = Processor.getInstance();
        ArrayBlockingQueue arrayBlockingQueue = Mockito.mock(ArrayBlockingQueue.class);

        PowerMockito.whenNew(ArrayBlockingQueue.class).withAnyArguments().thenReturn(arrayBlockingQueue);

        processor.start();

        //now you have successfully inject mocked arrayBlockQueue in Processor and can play around with it as usual with any mock object.
        }
        }


        Just ArrayBlockingQueue with your PersistantQueue.



        Hope this helps.







        share|improve this answer












        share|improve this answer



        share|improve this answer










        answered Nov 23 '18 at 20:23









        bittubittu

        407212




        407212
































            draft saved

            draft discarded




















































            Thanks for contributing an answer to Stack Overflow!


            • Please be sure to answer the question. Provide details and share your research!

            But avoid



            • Asking for help, clarification, or responding to other answers.

            • Making statements based on opinion; back them up with references or personal experience.


            To learn more, see our tips on writing great answers.




            draft saved


            draft discarded














            StackExchange.ready(
            function () {
            StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53418366%2fhow-to-properly-mock-queue-operation-in-unit-test-with-mockito%23new-answer', 'question_page');
            }
            );

            Post as a guest















            Required, but never shown





















































            Required, but never shown














            Required, but never shown












            Required, but never shown







            Required, but never shown

































            Required, but never shown














            Required, but never shown












            Required, but never shown







            Required, but never shown







            Popular posts from this blog

            Guess what letter conforming each word

            Port of Spain

            Run scheduled task as local user group (not BUILTIN)