SpringFramework DeferredResult and Hystrix
I was wondering is there any difference when using the @HysterixCommand annotation on a method that returns a DeferredResult over a method that returns an object straight away? Here is a sample of my code
@HystrixCommand(fallbackMethod = "getAlertsFallbackMethod")
public DeferredResult<List<AlertsBodyVO>> getAlerts(String userId) {
LOGGER.info("Entered getAlerts - userId:{}", userId);
final DeferredResult<List<AlertsBodyVO>> alertsDeferredResult = new DeferredResult<>();
try {
String requestURI = alertsEndpoint + userId.toUpperCase();
LOGGER.info("requestURI:{}", requestURI);
HttpHeaders headers = buildHttpHeader(userName, password);
LOGGER.info("headers:{}", headers);
HttpEntity<String> request = new HttpEntity<>(headers);
LOGGER.info("request:{}", request);
ResponseEntity<AlertsResponseVO> responseEntity = syncRestTemplate.exchange(requestURI, HttpMethod.GET, request, AlertsResponseVO.class);
LOGGER.info("responseEntity:" + responseEntity);
List<AlertsBodyVO> alertsBodyList = Arrays.asList(responseEntity.getBody().getAlertsBody());
alertsDeferredResult.setResult(alertsBodyList);
} catch (final RestClientException rce) {
LOGGER.error("ServiceImpl::getAlerts: failed for user__{}, --Cause::", userId, rce);
ErrorResponseVO alertsResponse = new ErrorResponseVO();
alertsResponse.setErrorMessage("ServiceImpl::getAlerts: failed for user__" + userId );
alertsDeferredResult.setErrorResult(alertsResponse);
}
LOGGER.info("Exiting:{}", alertsDeferredResult);
return alertsDeferredResult;
}
public DeferredResult<List<AlertsBodyVO>> getAlertsFallbackMethod(String userId) {
final DeferredResult<List<AlertsBodyVO>> alertsDeferredResult = new DeferredResult<>();
LOGGER.info("CircuitBreaker:Fallback method for getAlerts returning empty object::userId: {}",userId);
return alertsDeferredResult;
}
Right after this line
ResponseEntity<AlertsResponseVO> responseEntity = syncRestTemplate.exchange(requestURI, HttpMethod.GET, request, AlertsResponseVO.class)
The fallback method is called after 1 second.
I can see in the logs that the restTemplate completes successfully.
For Hysterix - I am using the default settings and this has worked fine for me in other methods that return objects.
If anyone can offer any insights into this behaviour it would be much appreciated.
java spring-boot netflix-eureka spring-cloud-netflix
asked Nov 12 at 18:36
Damien
1,49184282
add a comment |
I was wondering is there any difference when using the @HysterixCommand annotation on a method that returns a DeferredResult over a method that returns an object straight away? Here is a sample of my code
@HystrixCommand(fallbackMethod = "getAlertsFallbackMethod")
public DeferredResult<List<AlertsBodyVO>> getAlerts(String userId) {
LOGGER.info("Entered getAlerts - userId:{}", userId);
final DeferredResult<List<AlertsBodyVO>> alertsDeferredResult = new DeferredResult<>();
try {
String requestURI = alertsEndpoint + userId.toUpperCase();
LOGGER.info("requestURI:{}", requestURI);
HttpHeaders headers = buildHttpHeader(userName, password);
LOGGER.info("headers:{}", headers);
HttpEntity<String> request = new HttpEntity<>(headers);
LOGGER.info("request:{}", request);
ResponseEntity<AlertsResponseVO> responseEntity = syncRestTemplate.exchange(requestURI, HttpMethod.GET, request, AlertsResponseVO.class);
LOGGER.info("responseEntity:" + responseEntity);
List<AlertsBodyVO> alertsBodyList = Arrays.asList(responseEntity.getBody().getAlertsBody());
alertsDeferredResult.setResult(alertsBodyList);
} catch (final RestClientException rce) {
LOGGER.error("ServiceImpl::getAlerts: failed for user__{}, --Cause::", userId, rce);
ErrorResponseVO alertsResponse = new ErrorResponseVO();
alertsResponse.setErrorMessage("ServiceImpl::getAlerts: failed for user__" + userId );
alertsDeferredResult.setErrorResult(alertsResponse);
}
LOGGER.info("Exiting:{}", alertsDeferredResult);
return alertsDeferredResult;
}
public DeferredResult<List<AlertsBodyVO>> getAlertsFallbackMethod(String userId) {
final DeferredResult<List<AlertsBodyVO>> alertsDeferredResult = new DeferredResult<>();
LOGGER.info("CircuitBreaker:Fallback method for getAlerts returning empty object::userId: {}",userId);
return alertsDeferredResult;
}
Right after this line
ResponseEntity<AlertsResponseVO> responseEntity = syncRestTemplate.exchange(requestURI, HttpMethod.GET, request, AlertsResponseVO.class)
The fallback method is called after 1 second.
I can see in the logs that the restTemplate completes successfully.
For Hysterix - I am using the default settings and this has worked fine for me in other methods that return objects.
If anyone can offer any insights into this behaviour it would be much appreciated.
java spring-boot netflix-eureka spring-cloud-netflix
asked Nov 12 at 18:36
Damien
1,49184282
add a comment |
I was wondering is there any difference when using the @HysterixCommand annotation on a method that returns a DeferredResult over a method that returns an object straight away? Here is a sample of my code
@HystrixCommand(fallbackMethod = "getAlertsFallbackMethod")
public DeferredResult<List<AlertsBodyVO>> getAlerts(String userId) {
LOGGER.info("Entered getAlerts - userId:{}", userId);
final DeferredResult<List<AlertsBodyVO>> alertsDeferredResult = new DeferredResult<>();
try {
String requestURI = alertsEndpoint + userId.toUpperCase();
LOGGER.info("requestURI:{}", requestURI);
HttpHeaders headers = buildHttpHeader(userName, password);
LOGGER.info("headers:{}", headers);
HttpEntity<String> request = new HttpEntity<>(headers);
LOGGER.info("request:{}", request);
ResponseEntity<AlertsResponseVO> responseEntity = syncRestTemplate.exchange(requestURI, HttpMethod.GET, request, AlertsResponseVO.class);
LOGGER.info("responseEntity:" + responseEntity);
List<AlertsBodyVO> alertsBodyList = Arrays.asList(responseEntity.getBody().getAlertsBody());
alertsDeferredResult.setResult(alertsBodyList);
} catch (final RestClientException rce) {
LOGGER.error("ServiceImpl::getAlerts: failed for user__{}, --Cause::", userId, rce);
ErrorResponseVO alertsResponse = new ErrorResponseVO();
alertsResponse.setErrorMessage("ServiceImpl::getAlerts: failed for user__" + userId );
alertsDeferredResult.setErrorResult(alertsResponse);
}
LOGGER.info("Exiting:{}", alertsDeferredResult);
return alertsDeferredResult;
}
public DeferredResult<List<AlertsBodyVO>> getAlertsFallbackMethod(String userId) {
final DeferredResult<List<AlertsBodyVO>> alertsDeferredResult = new DeferredResult<>();
LOGGER.info("CircuitBreaker:Fallback method for getAlerts returning empty object::userId: {}",userId);
return alertsDeferredResult;
}
Right after this line
ResponseEntity<AlertsResponseVO> responseEntity = syncRestTemplate.exchange(requestURI, HttpMethod.GET, request, AlertsResponseVO.class)
The fallback method is called after 1 second.
I can see in the logs that the restTemplate completes successfully.
For Hysterix - I am using the default settings and this has worked fine for me in other methods that return objects.
If anyone can offer any insights into this behaviour it would be much appreciated.
java spring-boot netflix-eureka spring-cloud-netflix
asked Nov 12 at 18:36
Damien
1,49184282
I was wondering is there any difference when using the @HysterixCommand annotation on a method that returns a DeferredResult over a method that returns an object straight away? Here is a sample of my code
@HystrixCommand(fallbackMethod = "getAlertsFallbackMethod")
public DeferredResult<List<AlertsBodyVO>> getAlerts(String userId) {
LOGGER.info("Entered getAlerts - userId:{}", userId);
final DeferredResult<List<AlertsBodyVO>> alertsDeferredResult = new DeferredResult<>();
try {
String requestURI = alertsEndpoint + userId.toUpperCase();
LOGGER.info("requestURI:{}", requestURI);
HttpHeaders headers = buildHttpHeader(userName, password);
LOGGER.info("headers:{}", headers);
HttpEntity<String> request = new HttpEntity<>(headers);
LOGGER.info("request:{}", request);
ResponseEntity<AlertsResponseVO> responseEntity = syncRestTemplate.exchange(requestURI, HttpMethod.GET, request, AlertsResponseVO.class);
LOGGER.info("responseEntity:" + responseEntity);
List<AlertsBodyVO> alertsBodyList = Arrays.asList(responseEntity.getBody().getAlertsBody());
alertsDeferredResult.setResult(alertsBodyList);
} catch (final RestClientException rce) {
LOGGER.error("ServiceImpl::getAlerts: failed for user__{}, --Cause::", userId, rce);
ErrorResponseVO alertsResponse = new ErrorResponseVO();
alertsResponse.setErrorMessage("ServiceImpl::getAlerts: failed for user__" + userId );
alertsDeferredResult.setErrorResult(alertsResponse);
}
LOGGER.info("Exiting:{}", alertsDeferredResult);
return alertsDeferredResult;
}
public DeferredResult<List<AlertsBodyVO>> getAlertsFallbackMethod(String userId) {
final DeferredResult<List<AlertsBodyVO>> alertsDeferredResult = new DeferredResult<>();
LOGGER.info("CircuitBreaker:Fallback method for getAlerts returning empty object::userId: {}",userId);
return alertsDeferredResult;
}
Right after this line
ResponseEntity<AlertsResponseVO> responseEntity = syncRestTemplate.exchange(requestURI, HttpMethod.GET, request, AlertsResponseVO.class)
The fallback method is called after 1 second.
I can see in the logs that the restTemplate completes successfully.
For Hysterix - I am using the default settings and this has worked fine for me in other methods that return objects.
If anyone can offer any insights into this behaviour it would be much appreciated.
java spring-boot netflix-eureka spring-cloud-netflix
java spring-boot netflix-eureka spring-cloud-netflix
asked Nov 12 at 18:36
Damien
1,49184282
asked Nov 12 at 18:36
Damien
1,49184282
edited Nov 13 at 8:16
asked Nov 12 at 18:36
Damien
1,49184282
asked Nov 12 at 18:36
Damien
1,49184282
asked Nov 12 at 18:36
Damien
1,49184282
1,49184282
add a comment |
add a comment |
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53268148%2fspringframework-deferredresult-and-hystrix%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
active
oldest
votes
active
oldest
votes
active
oldest
votes
active
oldest
votes
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Some of your past answers have not been well-received, and you're in danger of being blocked from answering.
Please pay close attention to the following guidance:
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53268148%2fspringframework-deferredresult-and-hystrix%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
