Alert,Toast controller in Service rather than separate pages

I have a general question regarding the possible efficiency of calling an Ionic Component from a service rather than importing each Component separately in each .ts file.

For example, I use the ToastController and AlertController quite a bit and I recently started putting the function in my service for simplicity, but I'm not sure if that would ideally be better or worse for my app.

Sample Code:

service.ts

import { Injectable } from '@angular/core';

import { Observable } from 'rxjs/Observable';

import 'rxjs/add/observable/interval';

import { Subscription } from 'rxjs/Subscription';

import {ToastController, LoadingController } from 'ionic-angular';

import { AppVersion } from '@ionic-native/app-version';



@Injectable()

export class ReapService {

  constructor(public loadingCtrl:LoadingController,

              public toast: ToastController,

              public network: Network,

              public storage: Storage,

              public appVersion: AppVersion){}





presentToast(msg) {

      let toast = this.toast.create({

        message: msg,

        duration: 3000,

        position: 'bottom',

        dismissOnPageChange: false,

        cssClass: 'customToast'

      });



      toast.onDidDismiss(() => {

        //console.log('Dismissed toast');

      });



      toast.present();

      }

 }

another .ts file

onLogout(){

          this.reap.formStart = null;

          this.reap.token = "";

          this.storage.clear();

          const loading = this.loadingCtrl.create({

            content: 'Logging Out...'

          });

          loading.present();

             setTimeout(() => {

                this.reap.removeConnections();

                

                

                //Where I call the toast controller

                this.reap.presentToast('Logged Out');

                

                

                this.navCtrl.popToRoot();

                loading.dismiss();

            }, 2000);

          

     }

I just wanted to make sure that is feasible for the app and possible even more efficient if I started using other Components similar to Toast.I know so far it's saved time from having to import the component in each .ts file I want to use it.

edited Jan 27 at 16:08

asked Nov 19 '18 at 18:11

Stephen Romero

3561416

add a comment |

I have a general question regarding the possible efficiency of calling an Ionic Component from a service rather than importing each Component separately in each .ts file.

Sample Code:

service.ts

import { Injectable } from '@angular/core';

import { Observable } from 'rxjs/Observable';

import 'rxjs/add/observable/interval';

import { Subscription } from 'rxjs/Subscription';

import {ToastController, LoadingController } from 'ionic-angular';

import { AppVersion } from '@ionic-native/app-version';



@Injectable()

export class ReapService {

  constructor(public loadingCtrl:LoadingController,

              public toast: ToastController,

              public network: Network,

              public storage: Storage,

              public appVersion: AppVersion){}





presentToast(msg) {

      let toast = this.toast.create({

        message: msg,

        duration: 3000,

        position: 'bottom',

        dismissOnPageChange: false,

        cssClass: 'customToast'

      });



      toast.onDidDismiss(() => {

        //console.log('Dismissed toast');

      });



      toast.present();

      }

 }

another .ts file

onLogout(){

          this.reap.formStart = null;

          this.reap.token = "";

          this.storage.clear();

          const loading = this.loadingCtrl.create({

            content: 'Logging Out...'

          });

          loading.present();

             setTimeout(() => {

                this.reap.removeConnections();

                

                

                //Where I call the toast controller

                this.reap.presentToast('Logged Out');

                

                

                this.navCtrl.popToRoot();

                loading.dismiss();

            }, 2000);

          

     }

edited Jan 27 at 16:08

asked Nov 19 '18 at 18:11

Stephen Romero

3561416

add a comment |

I have a general question regarding the possible efficiency of calling an Ionic Component from a service rather than importing each Component separately in each .ts file.

Sample Code:

service.ts

import { Injectable } from '@angular/core';

import { Observable } from 'rxjs/Observable';

import 'rxjs/add/observable/interval';

import { Subscription } from 'rxjs/Subscription';

import {ToastController, LoadingController } from 'ionic-angular';

import { AppVersion } from '@ionic-native/app-version';



@Injectable()

export class ReapService {

  constructor(public loadingCtrl:LoadingController,

              public toast: ToastController,

              public network: Network,

              public storage: Storage,

              public appVersion: AppVersion){}





presentToast(msg) {

      let toast = this.toast.create({

        message: msg,

        duration: 3000,

        position: 'bottom',

        dismissOnPageChange: false,

        cssClass: 'customToast'

      });



      toast.onDidDismiss(() => {

        //console.log('Dismissed toast');

      });



      toast.present();

      }

 }

another .ts file

onLogout(){

          this.reap.formStart = null;

          this.reap.token = "";

          this.storage.clear();

          const loading = this.loadingCtrl.create({

            content: 'Logging Out...'

          });

          loading.present();

             setTimeout(() => {

                this.reap.removeConnections();

                

                

                //Where I call the toast controller

                this.reap.presentToast('Logged Out');

                

                

                this.navCtrl.popToRoot();

                loading.dismiss();

            }, 2000);

          

     }

edited Jan 27 at 16:08

asked Nov 19 '18 at 18:11

Stephen Romero

3561416

I have a general question regarding the possible efficiency of calling an Ionic Component from a service rather than importing each Component separately in each .ts file.

Sample Code:

service.ts

import { Injectable } from '@angular/core';

import { Observable } from 'rxjs/Observable';

import 'rxjs/add/observable/interval';

import { Subscription } from 'rxjs/Subscription';

import {ToastController, LoadingController } from 'ionic-angular';

import { AppVersion } from '@ionic-native/app-version';



@Injectable()

export class ReapService {

  constructor(public loadingCtrl:LoadingController,

              public toast: ToastController,

              public network: Network,

              public storage: Storage,

              public appVersion: AppVersion){}





presentToast(msg) {

      let toast = this.toast.create({

        message: msg,

        duration: 3000,

        position: 'bottom',

        dismissOnPageChange: false,

        cssClass: 'customToast'

      });



      toast.onDidDismiss(() => {

        //console.log('Dismissed toast');

      });



      toast.present();

      }

 }

another .ts file

onLogout(){

          this.reap.formStart = null;

          this.reap.token = "";

          this.storage.clear();

          const loading = this.loadingCtrl.create({

            content: 'Logging Out...'

          });

          loading.present();

             setTimeout(() => {

                this.reap.removeConnections();

                

                

                //Where I call the toast controller

                this.reap.presentToast('Logged Out');

                

                

                this.navCtrl.popToRoot();

                loading.dismiss();

            }, 2000);

          

     }

import { Injectable } from '@angular/core';

import { Observable } from 'rxjs/Observable';

import 'rxjs/add/observable/interval';

import { Subscription } from 'rxjs/Subscription';

import {ToastController, LoadingController } from 'ionic-angular';

import { AppVersion } from '@ionic-native/app-version';



@Injectable()

export class ReapService {

  constructor(public loadingCtrl:LoadingController,

              public toast: ToastController,

              public network: Network,

              public storage: Storage,

              public appVersion: AppVersion){}





presentToast(msg) {

      let toast = this.toast.create({

        message: msg,

        duration: 3000,

        position: 'bottom',

        dismissOnPageChange: false,

        cssClass: 'customToast'

      });



      toast.onDidDismiss(() => {

        //console.log('Dismissed toast');

      });



      toast.present();

      }

 }

import { Injectable } from '@angular/core';

import { Observable } from 'rxjs/Observable';

import 'rxjs/add/observable/interval';

import { Subscription } from 'rxjs/Subscription';

import {ToastController, LoadingController } from 'ionic-angular';

import { AppVersion } from '@ionic-native/app-version';



@Injectable()

export class ReapService {

  constructor(public loadingCtrl:LoadingController,

              public toast: ToastController,

              public network: Network,

              public storage: Storage,

              public appVersion: AppVersion){}





presentToast(msg) {

      let toast = this.toast.create({

        message: msg,

        duration: 3000,

        position: 'bottom',

        dismissOnPageChange: false,

        cssClass: 'customToast'

      });



      toast.onDidDismiss(() => {

        //console.log('Dismissed toast');

      });



      toast.present();

      }

 }

onLogout(){

          this.reap.formStart = null;

          this.reap.token = "";

          this.storage.clear();

          const loading = this.loadingCtrl.create({

            content: 'Logging Out...'

          });

          loading.present();

             setTimeout(() => {

                this.reap.removeConnections();

                

                

                //Where I call the toast controller

                this.reap.presentToast('Logged Out');

                

                

                this.navCtrl.popToRoot();

                loading.dismiss();

            }, 2000);

          

     }

onLogout(){

          this.reap.formStart = null;

          this.reap.token = "";

          this.storage.clear();

          const loading = this.loadingCtrl.create({

            content: 'Logging Out...'

          });

          loading.present();

             setTimeout(() => {

                this.reap.removeConnections();

                

                

                //Where I call the toast controller

                this.reap.presentToast('Logged Out');

                

                

                this.navCtrl.popToRoot();

                loading.dismiss();

            }, 2000);

          

     }

angular ionic-framework ionic3

edited Jan 27 at 16:08

asked Nov 19 '18 at 18:11

Stephen Romero

3561416

edited Jan 27 at 16:08

asked Nov 19 '18 at 18:11

Stephen Romero

3561416

edited Jan 27 at 16:08

asked Nov 19 '18 at 18:11

Stephen Romero

3561416

asked Nov 19 '18 at 18:11

Stephen Romero

3561416

asked Nov 19 '18 at 18:11

Stephen Romero

3561416

add a comment |

0

active

oldest

votes

Your Answer

StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");

StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);

StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});

function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});

}
});

draft saved

draft discarded

Sign up or log in

StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});

Post as a guest

Name

Required, but never shown

StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53380405%2falert-toast-controller-in-service-rather-than-separate-pages%23new-answer', 'question_page');
}
);

Post as a guest

Name

Required, but never shown

0

active

oldest

votes

0

active

oldest

votes

draft saved

draft discarded

Thanks for contributing an answer to Stack Overflow!

Please be sure to answer the question. Provide details and share your research!

But avoid …

Asking for help, clarification, or responding to other answers.

Making statements based on opinion; back them up with references or personal experience.

To learn more, see our tips on writing great answers.

draft saved

draft discarded

Sign up or log in

StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});

Post as a guest

Name

Required, but never shown

Post as a guest

Name

Required, but never shown

Sign up or log in

StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});

Post as a guest

Name

Required, but never shown

Sign up or log in

StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});

Post as a guest

Name

Required, but never shown

Sign up or log in

StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});

Post as a guest

Name

Required, but never shown

Name

Required, but never shown

Name

Required, but never shown

This page is only for reference, If you need detailed information, please check here

搜尋此網誌

Agfdhyk