Does Tomcat destroy too early ServletContext on shutdown?
.everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty,.everyoneloves__bot-mid-leaderboard:empty{ height:90px;width:728px;box-sizing:border-box;
}
On shutdown, I expect that Tomcat stops accepting new requests (and it does!) and finalizes ongoing requests successfully. Unfortunately ServletContext (Servlet.destroy, ServletContextListener.contextDestroyed, ...) is destroyed before finalization of ongoing requests.
These ongoing requests which rely on ServletContext will fail and potentially corrupt data! Context should be destroyed only after ongoing requests are processed.
Diving into code, org.apache.catalina.core.StandardService.stopInternal method reveals indeed that ServletContext is destroyed (engine.stop() statement) before shutting down (connector.stop() statement) the thread pool for requests (ThreadPoolExecutor).
I did find StandardContext.unloadDelay parameter (Number of ms that the container will wait for servlets to unload. If not specified, the default value is 2000 ms.) which may be the solution...
Do you know how to get this issue fixed differently?
How to reproduce:
@WebServlet(name = "StartStopServlet", displayName = "StartStopServlet", urlPatterns = "/execute")
public class StartStopServlet extends javax.servlet.http.HttpServlet {
private ExpensiveResource resource = null;
@Override
public void init() throws ServletException {
System.out.println("----> initializing StartStopServlet ...");
super.init();
resource = new ExpensiveResource();
resource.connect();
}
@Override
protected void doGet(HttpServletRequest req, HttpServletResponse resp) throws ServletException, IOException {
// simulating time consuming operation before invoking ExpensiveService
System.out.println("----> preparing parameters for ExpensiveResource call. It will take about 6 secs");
// Now is the time to stop Tomcat: invoke shutdown.sh (or shutdown.bat)
try {
Thread.currentThread().sleep(6000);
} catch (InterruptedException e) {
e.printStackTrace();
}
// produces NullPointerException if ServletContext is destroyed
Model result = resource.doWork();
// Preparing response...
}
@Override
public void destroy() {
System.out.println("----> destroying StartStopServlet ...");
super.destroy();
resource.disconnect();
resource = null;
}
}
resource.doWork() statement is invoked after destroy() method.
java tomcat
asked Nov 21 '18 at 23:09
Petru FluerasPetru Flueras
163
add a comment |
On shutdown, I expect that Tomcat stops accepting new requests (and it does!) and finalizes ongoing requests successfully. Unfortunately ServletContext (Servlet.destroy, ServletContextListener.contextDestroyed, ...) is destroyed before finalization of ongoing requests.
These ongoing requests which rely on ServletContext will fail and potentially corrupt data! Context should be destroyed only after ongoing requests are processed.
Diving into code, org.apache.catalina.core.StandardService.stopInternal method reveals indeed that ServletContext is destroyed (engine.stop() statement) before shutting down (connector.stop() statement) the thread pool for requests (ThreadPoolExecutor).
I did find StandardContext.unloadDelay parameter (Number of ms that the container will wait for servlets to unload. If not specified, the default value is 2000 ms.) which may be the solution...
Do you know how to get this issue fixed differently?
How to reproduce:
@WebServlet(name = "StartStopServlet", displayName = "StartStopServlet", urlPatterns = "/execute")
public class StartStopServlet extends javax.servlet.http.HttpServlet {
private ExpensiveResource resource = null;
@Override
public void init() throws ServletException {
System.out.println("----> initializing StartStopServlet ...");
super.init();
resource = new ExpensiveResource();
resource.connect();
}
@Override
protected void doGet(HttpServletRequest req, HttpServletResponse resp) throws ServletException, IOException {
// simulating time consuming operation before invoking ExpensiveService
System.out.println("----> preparing parameters for ExpensiveResource call. It will take about 6 secs");
// Now is the time to stop Tomcat: invoke shutdown.sh (or shutdown.bat)
try {
Thread.currentThread().sleep(6000);
} catch (InterruptedException e) {
e.printStackTrace();
}
// produces NullPointerException if ServletContext is destroyed
Model result = resource.doWork();
// Preparing response...
}
@Override
public void destroy() {
System.out.println("----> destroying StartStopServlet ...");
super.destroy();
resource.disconnect();
resource = null;
}
}
resource.doWork() statement is invoked after destroy() method.
java tomcat
asked Nov 21 '18 at 23:09
Petru FluerasPetru Flueras
163
add a comment |
On shutdown, I expect that Tomcat stops accepting new requests (and it does!) and finalizes ongoing requests successfully. Unfortunately ServletContext (Servlet.destroy, ServletContextListener.contextDestroyed, ...) is destroyed before finalization of ongoing requests.
These ongoing requests which rely on ServletContext will fail and potentially corrupt data! Context should be destroyed only after ongoing requests are processed.
Diving into code, org.apache.catalina.core.StandardService.stopInternal method reveals indeed that ServletContext is destroyed (engine.stop() statement) before shutting down (connector.stop() statement) the thread pool for requests (ThreadPoolExecutor).
I did find StandardContext.unloadDelay parameter (Number of ms that the container will wait for servlets to unload. If not specified, the default value is 2000 ms.) which may be the solution...
Do you know how to get this issue fixed differently?
How to reproduce:
@WebServlet(name = "StartStopServlet", displayName = "StartStopServlet", urlPatterns = "/execute")
public class StartStopServlet extends javax.servlet.http.HttpServlet {
private ExpensiveResource resource = null;
@Override
public void init() throws ServletException {
System.out.println("----> initializing StartStopServlet ...");
super.init();
resource = new ExpensiveResource();
resource.connect();
}
@Override
protected void doGet(HttpServletRequest req, HttpServletResponse resp) throws ServletException, IOException {
// simulating time consuming operation before invoking ExpensiveService
System.out.println("----> preparing parameters for ExpensiveResource call. It will take about 6 secs");
// Now is the time to stop Tomcat: invoke shutdown.sh (or shutdown.bat)
try {
Thread.currentThread().sleep(6000);
} catch (InterruptedException e) {
e.printStackTrace();
}
// produces NullPointerException if ServletContext is destroyed
Model result = resource.doWork();
// Preparing response...
}
@Override
public void destroy() {
System.out.println("----> destroying StartStopServlet ...");
super.destroy();
resource.disconnect();
resource = null;
}
}
resource.doWork() statement is invoked after destroy() method.
java tomcat
asked Nov 21 '18 at 23:09
Petru FluerasPetru Flueras
163
On shutdown, I expect that Tomcat stops accepting new requests (and it does!) and finalizes ongoing requests successfully. Unfortunately ServletContext (Servlet.destroy, ServletContextListener.contextDestroyed, ...) is destroyed before finalization of ongoing requests.
These ongoing requests which rely on ServletContext will fail and potentially corrupt data! Context should be destroyed only after ongoing requests are processed.
Diving into code, org.apache.catalina.core.StandardService.stopInternal method reveals indeed that ServletContext is destroyed (engine.stop() statement) before shutting down (connector.stop() statement) the thread pool for requests (ThreadPoolExecutor).
I did find StandardContext.unloadDelay parameter (Number of ms that the container will wait for servlets to unload. If not specified, the default value is 2000 ms.) which may be the solution...
Do you know how to get this issue fixed differently?
How to reproduce:
@WebServlet(name = "StartStopServlet", displayName = "StartStopServlet", urlPatterns = "/execute")
public class StartStopServlet extends javax.servlet.http.HttpServlet {
private ExpensiveResource resource = null;
@Override
public void init() throws ServletException {
System.out.println("----> initializing StartStopServlet ...");
super.init();
resource = new ExpensiveResource();
resource.connect();
}
@Override
protected void doGet(HttpServletRequest req, HttpServletResponse resp) throws ServletException, IOException {
// simulating time consuming operation before invoking ExpensiveService
System.out.println("----> preparing parameters for ExpensiveResource call. It will take about 6 secs");
// Now is the time to stop Tomcat: invoke shutdown.sh (or shutdown.bat)
try {
Thread.currentThread().sleep(6000);
} catch (InterruptedException e) {
e.printStackTrace();
}
// produces NullPointerException if ServletContext is destroyed
Model result = resource.doWork();
// Preparing response...
}
@Override
public void destroy() {
System.out.println("----> destroying StartStopServlet ...");
super.destroy();
resource.disconnect();
resource = null;
}
}
resource.doWork() statement is invoked after destroy() method.
java tomcat
java tomcat
asked Nov 21 '18 at 23:09
Petru FluerasPetru Flueras
163
asked Nov 21 '18 at 23:09
Petru FluerasPetru Flueras
163
edited Nov 22 '18 at 19:50
Petru Flueras
asked Nov 21 '18 at 23:09
Petru FluerasPetru Flueras
163
asked Nov 21 '18 at 23:09
Petru FluerasPetru Flueras
163
asked Nov 21 '18 at 23:09
Petru FluerasPetru Flueras
163
163
add a comment |
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53421721%2fdoes-tomcat-destroy-too-early-servletcontext-on-shutdown%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53421721%2fdoes-tomcat-destroy-too-early-servletcontext-on-shutdown%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
