Repeatedly calling setState inside componentWillUpdate or componentDidUpdate?
.everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty,.everyoneloves__bot-mid-leaderboard:empty{ height:90px;width:728px;box-sizing:border-box;
}
I'm trying to figure out the orientation of background-images in a React component that are passed in as props.
I start off by creating an Image object and setting its src to the new Image:
getImage() {
const src = this.props.url;
const image = new Image();
image.src = src;
this.setState({
height: image.height,
width: image.width
});
}
After I've updated the state with the heights and widths, I try calling getOrientation() inside of componentDidUpdate():
getOrientation() {
const { height, width } = this.state;
if (height > width) {
this.setState({ orientation: "portrait" });
} else {
this.setState({ orientation: "landscape" });
}
}
I then get the following error:
Maximum update depth exceeded. This can happen when a component repeatedly calls setState inside componentWillUpdate or componentDidUpdate.
Any ideas what's going on here?
Link to Sandbox
javascript reactjs image orientation setstate
asked Nov 21 '18 at 23:05
A7DCA7DC
5081621
add a comment |
I'm trying to figure out the orientation of background-images in a React component that are passed in as props.
I start off by creating an Image object and setting its src to the new Image:
getImage() {
const src = this.props.url;
const image = new Image();
image.src = src;
this.setState({
height: image.height,
width: image.width
});
}
After I've updated the state with the heights and widths, I try calling getOrientation() inside of componentDidUpdate():
getOrientation() {
const { height, width } = this.state;
if (height > width) {
this.setState({ orientation: "portrait" });
} else {
this.setState({ orientation: "landscape" });
}
}
I then get the following error:
Maximum update depth exceeded. This can happen when a component repeatedly calls setState inside componentWillUpdate or componentDidUpdate.
Any ideas what's going on here?
Link to Sandbox
javascript reactjs image orientation setstate
asked Nov 21 '18 at 23:05
A7DCA7DC
5081621
Possible duplicate of stackoverflow.com/questions/30528348/…
– zfrisch
Nov 21 '18 at 23:10
add a comment |
I'm trying to figure out the orientation of background-images in a React component that are passed in as props.
I start off by creating an Image object and setting its src to the new Image:
getImage() {
const src = this.props.url;
const image = new Image();
image.src = src;
this.setState({
height: image.height,
width: image.width
});
}
After I've updated the state with the heights and widths, I try calling getOrientation() inside of componentDidUpdate():
getOrientation() {
const { height, width } = this.state;
if (height > width) {
this.setState({ orientation: "portrait" });
} else {
this.setState({ orientation: "landscape" });
}
}
I then get the following error:
Maximum update depth exceeded. This can happen when a component repeatedly calls setState inside componentWillUpdate or componentDidUpdate.
Any ideas what's going on here?
Link to Sandbox
javascript reactjs image orientation setstate
asked Nov 21 '18 at 23:05
A7DCA7DC
5081621
I'm trying to figure out the orientation of background-images in a React component that are passed in as props.
I start off by creating an Image object and setting its src to the new Image:
getImage() {
const src = this.props.url;
const image = new Image();
image.src = src;
this.setState({
height: image.height,
width: image.width
});
}
After I've updated the state with the heights and widths, I try calling getOrientation() inside of componentDidUpdate():
getOrientation() {
const { height, width } = this.state;
if (height > width) {
this.setState({ orientation: "portrait" });
} else {
this.setState({ orientation: "landscape" });
}
}
I then get the following error:
Maximum update depth exceeded. This can happen when a component repeatedly calls setState inside componentWillUpdate or componentDidUpdate.
Any ideas what's going on here?
Link to Sandbox
javascript reactjs image orientation setstate
javascript reactjs image orientation setstate
asked Nov 21 '18 at 23:05
A7DCA7DC
5081621
asked Nov 21 '18 at 23:05
A7DCA7DC
5081621
asked Nov 21 '18 at 23:05
A7DCA7DC
5081621
asked Nov 21 '18 at 23:05
A7DCA7DC
5081621
asked Nov 21 '18 at 23:05
A7DCA7DC
5081621
5081621
Possible duplicate of stackoverflow.com/questions/30528348/…
– zfrisch
Nov 21 '18 at 23:10
add a comment |
Possible duplicate of stackoverflow.com/questions/30528348/…
– zfrisch
Nov 21 '18 at 23:10
Possible duplicate of stackoverflow.com/questions/30528348/…
– zfrisch
Nov 21 '18 at 23:10
Possible duplicate of stackoverflow.com/questions/30528348/…
– zfrisch
Nov 21 '18 at 23:10
add a comment |
1 Answer
1
active
oldest
votes
You need to include prevProps like so:
componentDidUpdate(prevProps, prevState) {
...
}
For more see here.
answered Nov 21 '18 at 23:30
ColinColin
4,7942831
I have already? Check inside the componentDidUpdate() method in the Sandbox
– A7DC
Nov 21 '18 at 23:40
1
No, your sandbox has:componentDidUpdate(prevState). Notice there's only one parameter instead of two :)
– Colin
Nov 21 '18 at 23:41
add a comment |
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53421688%2frepeatedly-calling-setstate-inside-componentwillupdate-or-componentdidupdate%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
1 Answer
1
active
oldest
votes
1 Answer
1
active
oldest
votes
active
oldest
votes
active
oldest
votes
You need to include prevProps like so:
componentDidUpdate(prevProps, prevState) {
...
}
For more see here.
answered Nov 21 '18 at 23:30
ColinColin
4,7942831
I have already? Check inside the componentDidUpdate() method in the Sandbox
– A7DC
Nov 21 '18 at 23:40
1
No, your sandbox has:componentDidUpdate(prevState). Notice there's only one parameter instead of two :)
– Colin
Nov 21 '18 at 23:41
add a comment |
You need to include prevProps like so:
componentDidUpdate(prevProps, prevState) {
...
}
For more see here.
answered Nov 21 '18 at 23:30
ColinColin
4,7942831
I have already? Check inside the componentDidUpdate() method in the Sandbox
– A7DC
Nov 21 '18 at 23:40
1
No, your sandbox has:componentDidUpdate(prevState). Notice there's only one parameter instead of two :)
– Colin
Nov 21 '18 at 23:41
add a comment |
You need to include prevProps like so:
componentDidUpdate(prevProps, prevState) {
...
}
For more see here.
answered Nov 21 '18 at 23:30
ColinColin
4,7942831
You need to include prevProps like so:
componentDidUpdate(prevProps, prevState) {
...
}
For more see here.
answered Nov 21 '18 at 23:30
ColinColin
4,7942831
edited Nov 21 '18 at 23:57
answered Nov 21 '18 at 23:30
ColinColin
4,7942831
answered Nov 21 '18 at 23:30
ColinColin
4,7942831
answered Nov 21 '18 at 23:30
ColinColin
4,7942831
4,7942831
I have already? Check inside the componentDidUpdate() method in the Sandbox
– A7DC
Nov 21 '18 at 23:40
1
No, your sandbox has:componentDidUpdate(prevState). Notice there's only one parameter instead of two :)
– Colin
Nov 21 '18 at 23:41
add a comment |
I have already? Check inside the componentDidUpdate() method in the Sandbox
– A7DC
Nov 21 '18 at 23:40
1
No, your sandbox has:componentDidUpdate(prevState). Notice there's only one parameter instead of two :)
– Colin
Nov 21 '18 at 23:41
I have already? Check inside the componentDidUpdate() method in the Sandbox
– A7DC
Nov 21 '18 at 23:40
I have already? Check inside the componentDidUpdate() method in the Sandbox
– A7DC
Nov 21 '18 at 23:40
1
1
No, your sandbox has:
componentDidUpdate(prevState). Notice there's only one parameter instead of two :)– Colin
Nov 21 '18 at 23:41
No, your sandbox has:
componentDidUpdate(prevState). Notice there's only one parameter instead of two :)– Colin
Nov 21 '18 at 23:41
add a comment |
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53421688%2frepeatedly-calling-setstate-inside-componentwillupdate-or-componentdidupdate%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Possible duplicate of stackoverflow.com/questions/30528348/…
– zfrisch
Nov 21 '18 at 23:10