Is it good practice to call controller methods?
Lest suppose we have couple of controller in Laravel. It is logic business layer that responsibilities about process activity.
One of them is ProductController, another one is OrderController.
Is is good practice to use selectivity ProductController's methods in OrderController?
If to lean on the SOLID principies, it is not. But what if I need to use one part of logic ProductController in OrderController?
Does it mean that I should use only through HTTP request? Or better to create singleton service, that will be available for both controllers?
laravel laravel-5
asked Nov 13 '18 at 23:43
OPV
1,48821329
add a comment |
Lest suppose we have couple of controller in Laravel. It is logic business layer that responsibilities about process activity.
One of them is ProductController, another one is OrderController.
Is is good practice to use selectivity ProductController's methods in OrderController?
If to lean on the SOLID principies, it is not. But what if I need to use one part of logic ProductController in OrderController?
Does it mean that I should use only through HTTP request? Or better to create singleton service, that will be available for both controllers?
laravel laravel-5
asked Nov 13 '18 at 23:43
OPV
1,48821329
add a comment |
Lest suppose we have couple of controller in Laravel. It is logic business layer that responsibilities about process activity.
One of them is ProductController, another one is OrderController.
Is is good practice to use selectivity ProductController's methods in OrderController?
If to lean on the SOLID principies, it is not. But what if I need to use one part of logic ProductController in OrderController?
Does it mean that I should use only through HTTP request? Or better to create singleton service, that will be available for both controllers?
laravel laravel-5
asked Nov 13 '18 at 23:43
OPV
1,48821329
Lest suppose we have couple of controller in Laravel. It is logic business layer that responsibilities about process activity.
One of them is ProductController, another one is OrderController.
Is is good practice to use selectivity ProductController's methods in OrderController?
If to lean on the SOLID principies, it is not. But what if I need to use one part of logic ProductController in OrderController?
Does it mean that I should use only through HTTP request? Or better to create singleton service, that will be available for both controllers?
laravel laravel-5
laravel laravel-5
asked Nov 13 '18 at 23:43
OPV
1,48821329
asked Nov 13 '18 at 23:43
OPV
1,48821329
asked Nov 13 '18 at 23:43
OPV
1,48821329
asked Nov 13 '18 at 23:43
OPV
1,48821329
asked Nov 13 '18 at 23:43
OPV
1,48821329
1,48821329
add a comment |
add a comment |
1 Answer
1
active
oldest
votes
You're right, it's not a good idea. Depending on what functionality you want to share, you could use, for example, the repository design pattern or the presenter pattern. There are some examples around specifically for Laravel using those design patterns.
answered Nov 14 '18 at 2:56
Delena Malan
607415
add a comment |
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53291098%2fis-it-good-practice-to-call-controller-methods%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
1 Answer
1
active
oldest
votes
1 Answer
1
active
oldest
votes
active
oldest
votes
active
oldest
votes
You're right, it's not a good idea. Depending on what functionality you want to share, you could use, for example, the repository design pattern or the presenter pattern. There are some examples around specifically for Laravel using those design patterns.
answered Nov 14 '18 at 2:56
Delena Malan
607415
add a comment |
You're right, it's not a good idea. Depending on what functionality you want to share, you could use, for example, the repository design pattern or the presenter pattern. There are some examples around specifically for Laravel using those design patterns.
answered Nov 14 '18 at 2:56
Delena Malan
607415
add a comment |
You're right, it's not a good idea. Depending on what functionality you want to share, you could use, for example, the repository design pattern or the presenter pattern. There are some examples around specifically for Laravel using those design patterns.
answered Nov 14 '18 at 2:56
Delena Malan
607415
You're right, it's not a good idea. Depending on what functionality you want to share, you could use, for example, the repository design pattern or the presenter pattern. There are some examples around specifically for Laravel using those design patterns.
answered Nov 14 '18 at 2:56
Delena Malan
607415
answered Nov 14 '18 at 2:56
Delena Malan
607415
answered Nov 14 '18 at 2:56
Delena Malan
607415
answered Nov 14 '18 at 2:56
Delena Malan
607415
607415
add a comment |
add a comment |
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Some of your past answers have not been well-received, and you're in danger of being blocked from answering.
Please pay close attention to the following guidance:
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53291098%2fis-it-good-practice-to-call-controller-methods%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
