Testing NGXS states with sub states feeds wrong state into action handler
Setup:
I have a parent state defined as
@State<ParentStateModel>({
name: 'grid',
defaults: {
parentData: 'some data'
},
children: [LoadingState]
})
export class ParentState {
@Action(Action1)
action1(ctx: stateContext<ParentStateModel>, action: Action1) {
// In production this state will be ParentStateModel as expected
// but in unit test, it will be of type LoadingState
const state = ctx.getState();
}
}
And a child state defined as
@State<LoadingStateModel>({
name: 'gridLoading',
defaults: {
loading: false
}
})
export class LoadingState{
@Action(Action1)
action1(ctx: stateContext<LoadingStateModel>, action: Action1) {
ctx.setState({loading: true});
}
}
Notice that both states respond to Action1.
When running this in production, it works as it should. The loading state takes care of the LoadingStateModel and the ParentState takes care of the ParentStateModel.
But when unit testing the code, the action handler in ParentState is fed the LoadingStateModel instead of the ParentStateModel (see comment in code).
My unit test is setup as follows
TestBed.configureTestingModule({
imports: [NgxsModule.forRoot([CashflowState, LoadingState])]
});
If I do not include LoadingState in the imports array, NGXS fails with Child state not found: function LoadingState()
Am I doing something wrong, or is it a bug in NGXS?
ngxs
asked Nov 21 '18 at 11:58
rasmusvhansenrasmusvhansen
8571912
add a comment |
Setup:
I have a parent state defined as
@State<ParentStateModel>({
name: 'grid',
defaults: {
parentData: 'some data'
},
children: [LoadingState]
})
export class ParentState {
@Action(Action1)
action1(ctx: stateContext<ParentStateModel>, action: Action1) {
// In production this state will be ParentStateModel as expected
// but in unit test, it will be of type LoadingState
const state = ctx.getState();
}
}
And a child state defined as
@State<LoadingStateModel>({
name: 'gridLoading',
defaults: {
loading: false
}
})
export class LoadingState{
@Action(Action1)
action1(ctx: stateContext<LoadingStateModel>, action: Action1) {
ctx.setState({loading: true});
}
}
Notice that both states respond to Action1.
When running this in production, it works as it should. The loading state takes care of the LoadingStateModel and the ParentState takes care of the ParentStateModel.
But when unit testing the code, the action handler in ParentState is fed the LoadingStateModel instead of the ParentStateModel (see comment in code).
My unit test is setup as follows
TestBed.configureTestingModule({
imports: [NgxsModule.forRoot([CashflowState, LoadingState])]
});
If I do not include LoadingState in the imports array, NGXS fails with Child state not found: function LoadingState()
Am I doing something wrong, or is it a bug in NGXS?
ngxs
asked Nov 21 '18 at 11:58
rasmusvhansenrasmusvhansen
8571912
A simple basic question: are the imports forAction1correctly set?
– GCSDC
Dec 6 '18 at 21:34
add a comment |
Setup:
I have a parent state defined as
@State<ParentStateModel>({
name: 'grid',
defaults: {
parentData: 'some data'
},
children: [LoadingState]
})
export class ParentState {
@Action(Action1)
action1(ctx: stateContext<ParentStateModel>, action: Action1) {
// In production this state will be ParentStateModel as expected
// but in unit test, it will be of type LoadingState
const state = ctx.getState();
}
}
And a child state defined as
@State<LoadingStateModel>({
name: 'gridLoading',
defaults: {
loading: false
}
})
export class LoadingState{
@Action(Action1)
action1(ctx: stateContext<LoadingStateModel>, action: Action1) {
ctx.setState({loading: true});
}
}
Notice that both states respond to Action1.
When running this in production, it works as it should. The loading state takes care of the LoadingStateModel and the ParentState takes care of the ParentStateModel.
But when unit testing the code, the action handler in ParentState is fed the LoadingStateModel instead of the ParentStateModel (see comment in code).
My unit test is setup as follows
TestBed.configureTestingModule({
imports: [NgxsModule.forRoot([CashflowState, LoadingState])]
});
If I do not include LoadingState in the imports array, NGXS fails with Child state not found: function LoadingState()
Am I doing something wrong, or is it a bug in NGXS?
ngxs
asked Nov 21 '18 at 11:58
rasmusvhansenrasmusvhansen
8571912
Setup:
I have a parent state defined as
@State<ParentStateModel>({
name: 'grid',
defaults: {
parentData: 'some data'
},
children: [LoadingState]
})
export class ParentState {
@Action(Action1)
action1(ctx: stateContext<ParentStateModel>, action: Action1) {
// In production this state will be ParentStateModel as expected
// but in unit test, it will be of type LoadingState
const state = ctx.getState();
}
}
And a child state defined as
@State<LoadingStateModel>({
name: 'gridLoading',
defaults: {
loading: false
}
})
export class LoadingState{
@Action(Action1)
action1(ctx: stateContext<LoadingStateModel>, action: Action1) {
ctx.setState({loading: true});
}
}
Notice that both states respond to Action1.
When running this in production, it works as it should. The loading state takes care of the LoadingStateModel and the ParentState takes care of the ParentStateModel.
But when unit testing the code, the action handler in ParentState is fed the LoadingStateModel instead of the ParentStateModel (see comment in code).
My unit test is setup as follows
TestBed.configureTestingModule({
imports: [NgxsModule.forRoot([CashflowState, LoadingState])]
});
If I do not include LoadingState in the imports array, NGXS fails with Child state not found: function LoadingState()
Am I doing something wrong, or is it a bug in NGXS?
ngxs
ngxs
asked Nov 21 '18 at 11:58
rasmusvhansenrasmusvhansen
8571912
asked Nov 21 '18 at 11:58
rasmusvhansenrasmusvhansen
8571912
asked Nov 21 '18 at 11:58
rasmusvhansenrasmusvhansen
8571912
asked Nov 21 '18 at 11:58
rasmusvhansenrasmusvhansen
8571912
asked Nov 21 '18 at 11:58
rasmusvhansenrasmusvhansen
8571912
8571912
A simple basic question: are the imports forAction1correctly set?
– GCSDC
Dec 6 '18 at 21:34
add a comment |
A simple basic question: are the imports forAction1correctly set?
– GCSDC
Dec 6 '18 at 21:34
A simple basic question: are the imports for
Action1 correctly set?– GCSDC
Dec 6 '18 at 21:34
A simple basic question: are the imports for
Action1 correctly set?– GCSDC
Dec 6 '18 at 21:34
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53411562%2ftesting-ngxs-states-with-sub-states-feeds-wrong-state-into-action-handler%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53411562%2ftesting-ngxs-states-with-sub-states-feeds-wrong-state-into-action-handler%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
A simple basic question: are the imports for
Action1correctly set?– GCSDC
Dec 6 '18 at 21:34