Posts

Showing posts from November 30, 2018

understanding leaks in android MVP

Image
up vote 0 down vote favorite 2 I've read some similar questions on here but due to the lack of code presented I'm not certain my question describes the same scenarios. I hope that the following snippets and questions will help others clarify what and when something is leaked in this MVP implementation: https://github.com/frogermcs/GithubClient/tree/1bf53a2a36c8a85435e877847b987395e482ab4a BaseActivity.java: public abstract class BaseActivity extends AppCompatActivity { @Override protected void onCreate(Bundle savedInstanceState) { super.onCreate(savedInstanceState); setupActivityComponent(); } protected abstract void setupActivityComponent(); } SplashActivityModule.java: @Module public class SplashActivityModule { private SplashActivity splashActivity; public S