Agfdhyk

Im trying to look through 2 different boxes(inbox & Outbox), compare the subject and delete the message in the outbox when a match is found. What am I doing incorrectly? Do I need to create another Folder object for each box? EDIT Im getting a "runtime error 13; type mismatch"

Sub DEID()



    Dim objNS As Outlook.NameSpace

    Dim objFolder As Outlook.MAPIFolder



    Set objNS = GetNamespace("MAPI")

    Set objFolder = objNS.Folders.GetFirst

    Set objIFolder = objFolder.Folders("Inbox")

    Set objOFolder = objFolder.Folders("Outbox")



    Dim Item, OItem As Outlook.MailItem



    For Each Item In objIFolder.Items

        Set ISub = Right(CStr(Item.Subject), Len(Item.Subject) - 6)

        Set ISub = CStr(ISub)

        For Each OItem In objOFolder.Items

            Set OSub = Right(CStr(OItem.Subject), Len(OItem.Subject) - 6)

            Set ISub = CStr(OSub)

            If StrComp(ISub = OSub, 1) = 0 Then

                OItem.Delete

            End If

        Next OItem

    Next Item



End Sub

One thing that jumps out at me is you are using a set command on a value type (subject, which is a string), which you don't need and should cause an error.

Dim Item, OItem As Outlook.MailItem

Dim ISub, OSub As String



For Each Item In objIFolder.Items

    ISub = Right(CStr(Item.Subject), Len(Item.Subject) - 6)

    ISub = CStr(ISub)

    For Each OItem In objOFolder.Items

        OSub = Right(CStr(OItem.Subject), Len(OItem.Subject) - 6)

        ISub = CStr(OSub)

        If StrComp(ISub = OSub, 1) = 0 Then

            OItem.Delete

        End If

    Next OItem

Next Item

One other observation... This line:

ISub = CStr(OSub)

Seems to me like it will force the next condition to always be true. Unless I misunderstand, that seems like a mistake.

I also think the String conversion are unnecessary since subject is already a string.

This would be my final version:

Dim objNS As Outlook.NameSpace

Dim objFolder As Outlook.MAPIFolder



Set objNS = GetNamespace("MAPI")

Set objFolder = objNS.Folders.GetFirst

Set objIFolder = objFolder.Folders("Inbox")

Set objOFolder = objFolder.Folders("Outbox")



Dim Item, OItem As Outlook.MailItem

Dim ISub, OSub As String



For Each Item In objIFolder.Items

    ISub = Right(Item.Subject, Len(Item.Subject) - 6)

    For Each OItem In objOFolder.Items

        OSub = Right(OItem.Subject, Len(OItem.Subject) - 6)

        If ISub = OSub Then

            OItem.Delete

        End If

    Next OItem

Next Item

Firstly, you are dimming Item and OItem as Outlook.MailItem - you can have other items in the Inbox folder (hence the Type Mismatch error), such as ReportItem or MeetingItem. Dim these variables as a generic Object.

Secondly, you are deleting items in a collection while you are looping through it. Do not do that - use a down loop (for i = Items.Count to 1 step -1).

Thirdly, do not loop through all items in a folder - this is hugely inefficient, let Outlook do the job - for the inner use Items.Find / FindNext or Items.Restrict with a query like @SQL="http://schemas.microsoft.com/mapi/proptag/0x0E1D001F" like '%some value%'.

For the outer loop, again, dd not loop, retrieve all subjects in a single call using MAPIFolder.GetTable() / Table.Columns.Add / Table.GetArray / etc. - see https://docs.microsoft.com/en-us/dotnet/api/microsoft.office.interop.outlook.table?view=outlook-pia