Colon expected (and similar errors) in Angular Universal demo
Angular provides demo code for learning their Universal server-side rendering. In Step 5, the sample Javascript webpack code tries to declare constants and such inside a decorator, which returns errors about missing colons and commas in lines 2, 3, and 5 (see below comments).
Since I'm not familiar enough with decorators to say for sure, can you confirm this? How would this code be corrected? Would it be acceptable to reach out to the Angular website and bring this to their attention, or would that not be good etiquette?
@NgModule({
const path = require('path'); // : expected on first path, , expected on ;
const webpack = require('webpack'); // : expected on first webpack, , expected on ;
module.exports = { // : expected on .
entry: { server: './server.ts' },
resolve: { extensions: ['.js', '.ts'] },
target: 'node',
// this makes sure we include node_modules and other 3rd party libraries
externals: [/(node_modules|main..*.js)/],
output: {
path: path.join(__dirname, 'dist'),
filename: '[name].js'
},
module: {
rules: [
{ test: /.ts$/, loader: 'ts-loader' }
]
},
plugins: [
// Temporary Fix for issue: https://github.com/angular/angular/issues/11580
// for "WARNING Critical dependency: the request of a dependency is an expression"
new webpack.ContextReplacementPlugin(
/(.+)?angular(\|/)core(.+)?/,
path.join(__dirname, 'src'), // location of your src
{} // a map of your routes
),
new webpack.ContextReplacementPlugin(
/(.+)?express(\|/)(.+)?/,
path.join(__dirname, 'src'),
{}
)
]
}
})
javascript
angular decorator angular-universal angular-decorator asked Nov 20 '18 at 16:12
deadandhalloweddeadandhallowed
507
add a comment |
Angular provides demo code for learning their Universal server-side rendering. In Step 5, the sample Javascript webpack code tries to declare constants and such inside a decorator, which returns errors about missing colons and commas in lines 2, 3, and 5 (see below comments).
Since I'm not familiar enough with decorators to say for sure, can you confirm this? How would this code be corrected? Would it be acceptable to reach out to the Angular website and bring this to their attention, or would that not be good etiquette?
@NgModule({
const path = require('path'); // : expected on first path, , expected on ;
const webpack = require('webpack'); // : expected on first webpack, , expected on ;
module.exports = { // : expected on .
entry: { server: './server.ts' },
resolve: { extensions: ['.js', '.ts'] },
target: 'node',
// this makes sure we include node_modules and other 3rd party libraries
externals: [/(node_modules|main..*.js)/],
output: {
path: path.join(__dirname, 'dist'),
filename: '[name].js'
},
module: {
rules: [
{ test: /.ts$/, loader: 'ts-loader' }
]
},
plugins: [
// Temporary Fix for issue: https://github.com/angular/angular/issues/11580
// for "WARNING Critical dependency: the request of a dependency is an expression"
new webpack.ContextReplacementPlugin(
/(.+)?angular(\|/)core(.+)?/,
path.join(__dirname, 'src'), // location of your src
{} // a map of your routes
),
new webpack.ContextReplacementPlugin(
/(.+)?express(\|/)(.+)?/,
path.join(__dirname, 'src'),
{}
)
]
}
})
javascript
angular decorator angular-universal angular-decorator asked Nov 20 '18 at 16:12
deadandhalloweddeadandhallowed
507
1
remove@NgModule({decorator, it worked for me. Hope it works for you!!
– Bharathkumar kamal
Nov 20 '18 at 16:33
add a comment |
Angular provides demo code for learning their Universal server-side rendering. In Step 5, the sample Javascript webpack code tries to declare constants and such inside a decorator, which returns errors about missing colons and commas in lines 2, 3, and 5 (see below comments).
Since I'm not familiar enough with decorators to say for sure, can you confirm this? How would this code be corrected? Would it be acceptable to reach out to the Angular website and bring this to their attention, or would that not be good etiquette?
@NgModule({
const path = require('path'); // : expected on first path, , expected on ;
const webpack = require('webpack'); // : expected on first webpack, , expected on ;
module.exports = { // : expected on .
entry: { server: './server.ts' },
resolve: { extensions: ['.js', '.ts'] },
target: 'node',
// this makes sure we include node_modules and other 3rd party libraries
externals: [/(node_modules|main..*.js)/],
output: {
path: path.join(__dirname, 'dist'),
filename: '[name].js'
},
module: {
rules: [
{ test: /.ts$/, loader: 'ts-loader' }
]
},
plugins: [
// Temporary Fix for issue: https://github.com/angular/angular/issues/11580
// for "WARNING Critical dependency: the request of a dependency is an expression"
new webpack.ContextReplacementPlugin(
/(.+)?angular(\|/)core(.+)?/,
path.join(__dirname, 'src'), // location of your src
{} // a map of your routes
),
new webpack.ContextReplacementPlugin(
/(.+)?express(\|/)(.+)?/,
path.join(__dirname, 'src'),
{}
)
]
}
})
javascript
angular decorator angular-universal angular-decorator asked Nov 20 '18 at 16:12
deadandhalloweddeadandhallowed
507
Angular provides demo code for learning their Universal server-side rendering. In Step 5, the sample Javascript webpack code tries to declare constants and such inside a decorator, which returns errors about missing colons and commas in lines 2, 3, and 5 (see below comments).
Since I'm not familiar enough with decorators to say for sure, can you confirm this? How would this code be corrected? Would it be acceptable to reach out to the Angular website and bring this to their attention, or would that not be good etiquette?
@NgModule({
const path = require('path'); // : expected on first path, , expected on ;
const webpack = require('webpack'); // : expected on first webpack, , expected on ;
module.exports = { // : expected on .
entry: { server: './server.ts' },
resolve: { extensions: ['.js', '.ts'] },
target: 'node',
// this makes sure we include node_modules and other 3rd party libraries
externals: [/(node_modules|main..*.js)/],
output: {
path: path.join(__dirname, 'dist'),
filename: '[name].js'
},
module: {
rules: [
{ test: /.ts$/, loader: 'ts-loader' }
]
},
plugins: [
// Temporary Fix for issue: https://github.com/angular/angular/issues/11580
// for "WARNING Critical dependency: the request of a dependency is an expression"
new webpack.ContextReplacementPlugin(
/(.+)?angular(\|/)core(.+)?/,
path.join(__dirname, 'src'), // location of your src
{} // a map of your routes
),
new webpack.ContextReplacementPlugin(
/(.+)?express(\|/)(.+)?/,
path.join(__dirname, 'src'),
{}
)
]
}
})
javascript
angular decorator angular-universal angular-decorator javascript
angular decorator angular-universal angular-decorator asked Nov 20 '18 at 16:12
deadandhalloweddeadandhallowed
507
asked Nov 20 '18 at 16:12
deadandhalloweddeadandhallowed
507
asked Nov 20 '18 at 16:12
deadandhalloweddeadandhallowed
507
asked Nov 20 '18 at 16:12
deadandhalloweddeadandhallowed
507
asked Nov 20 '18 at 16:12
deadandhalloweddeadandhallowed
507
507
1
remove@NgModule({decorator, it worked for me. Hope it works for you!!
– Bharathkumar kamal
Nov 20 '18 at 16:33
add a comment |
1
remove@NgModule({decorator, it worked for me. Hope it works for you!!
– Bharathkumar kamal
Nov 20 '18 at 16:33
1
1
remove
@NgModule({ decorator, it worked for me. Hope it works for you!!– Bharathkumar kamal
Nov 20 '18 at 16:33
remove
@NgModule({ decorator, it worked for me. Hope it works for you!!– Bharathkumar kamal
Nov 20 '18 at 16:33
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53397110%2fcolon-expected-and-similar-errors-in-angular-universal-demo%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53397110%2fcolon-expected-and-similar-errors-in-angular-universal-demo%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
1
remove
@NgModule({decorator, it worked for me. Hope it works for you!!– Bharathkumar kamal
Nov 20 '18 at 16:33