Segmentation fault while trying to draw triangles with C
up vote
0
down vote
favorite
Continuing on a previous question in a previous thread:
Hi guys! Part 2 of my bouncing ball questions. (previous question)
I'm still getting a segmentation fault in my code, but only while drawing the last element of an array. I have put in print-statements to see exactly where the code stops, and it is in the last iteration in the for loop below:
void draw_object(object_t *object)
{
for (int i = 0; i < object->numtriangles; i++) {
/* Translate triangle into middle of screen before drawing it */
object->model[i].tx = object->surface->w/2;
object->model[i].ty = object->surface->h/2;
/* Set new rotation and scale it down */
object->model[i].rotation = object->rotation;
object->model[i].scale = object->scale;
/* And draw it */
draw_triangle(object->surface, &object->model[i]);
printf("okn %d", i+1);
}
Now there are 478 elements in the group and it goes through 477 before the segmentation fault appears. If I change the second condition in the for loop to something like this:
for(int i=0, i<200, i++)
The segmentation fault appears after 199 iterations.
I have no idea why this is happening. I would think it is very unlikely that I run out of memory, especially when I can do 400 iterations without a problem until the last iteration.
All help is greatly appreciated! Thanks in advance.
c for-loop malloc
asked Nov 12 at 20:37
Peter
112
|
show 4 more comments
up vote
0
down vote
favorite
Continuing on a previous question in a previous thread:
Hi guys! Part 2 of my bouncing ball questions. (previous question)
I'm still getting a segmentation fault in my code, but only while drawing the last element of an array. I have put in print-statements to see exactly where the code stops, and it is in the last iteration in the for loop below:
void draw_object(object_t *object)
{
for (int i = 0; i < object->numtriangles; i++) {
/* Translate triangle into middle of screen before drawing it */
object->model[i].tx = object->surface->w/2;
object->model[i].ty = object->surface->h/2;
/* Set new rotation and scale it down */
object->model[i].rotation = object->rotation;
object->model[i].scale = object->scale;
/* And draw it */
draw_triangle(object->surface, &object->model[i]);
printf("okn %d", i+1);
}
Now there are 478 elements in the group and it goes through 477 before the segmentation fault appears. If I change the second condition in the for loop to something like this:
for(int i=0, i<200, i++)
The segmentation fault appears after 199 iterations.
I have no idea why this is happening. I would think it is very unlikely that I run out of memory, especially when I can do 400 iterations without a problem until the last iteration.
All help is greatly appreciated! Thanks in advance.
c for-loop malloc
asked Nov 12 at 20:37
Peter
112
3
Run your code through valgrind. If you're mismanaging memory, which it looks like you are, it will tell you where.
– dbush
Nov 12 at 20:39
2
I see no problems in the code presented, there's probably UB elsewhere.
– yano
Nov 12 at 20:41
2
Can't tell without a Minimal, Complete, and Verifiable example.
– Fred Larson
Nov 12 at 20:43
1
OK. Then notice that the output is line-buffered, so it would print198 okn- and then 199 would remain in the buffer. Addfflush(stdout);ornat the end of the printf, and you'd notice that it totally doesn't crash there. Also, now would be a good time to learn to use a proper debugger!
– Antti Haapala
Nov 12 at 20:56
1
Is there a good reason why you're printing the number after the newline? Why notok %dn?
– Barmar
Nov 12 at 21:20
|
show 4 more comments
up vote
0
down vote
favorite
up vote
0
down vote
favorite
Continuing on a previous question in a previous thread:
Hi guys! Part 2 of my bouncing ball questions. (previous question)
I'm still getting a segmentation fault in my code, but only while drawing the last element of an array. I have put in print-statements to see exactly where the code stops, and it is in the last iteration in the for loop below:
void draw_object(object_t *object)
{
for (int i = 0; i < object->numtriangles; i++) {
/* Translate triangle into middle of screen before drawing it */
object->model[i].tx = object->surface->w/2;
object->model[i].ty = object->surface->h/2;
/* Set new rotation and scale it down */
object->model[i].rotation = object->rotation;
object->model[i].scale = object->scale;
/* And draw it */
draw_triangle(object->surface, &object->model[i]);
printf("okn %d", i+1);
}
Now there are 478 elements in the group and it goes through 477 before the segmentation fault appears. If I change the second condition in the for loop to something like this:
for(int i=0, i<200, i++)
The segmentation fault appears after 199 iterations.
I have no idea why this is happening. I would think it is very unlikely that I run out of memory, especially when I can do 400 iterations without a problem until the last iteration.
All help is greatly appreciated! Thanks in advance.
c for-loop malloc
asked Nov 12 at 20:37
Peter
112
Continuing on a previous question in a previous thread:
Hi guys! Part 2 of my bouncing ball questions. (previous question)
I'm still getting a segmentation fault in my code, but only while drawing the last element of an array. I have put in print-statements to see exactly where the code stops, and it is in the last iteration in the for loop below:
void draw_object(object_t *object)
{
for (int i = 0; i < object->numtriangles; i++) {
/* Translate triangle into middle of screen before drawing it */
object->model[i].tx = object->surface->w/2;
object->model[i].ty = object->surface->h/2;
/* Set new rotation and scale it down */
object->model[i].rotation = object->rotation;
object->model[i].scale = object->scale;
/* And draw it */
draw_triangle(object->surface, &object->model[i]);
printf("okn %d", i+1);
}
Now there are 478 elements in the group and it goes through 477 before the segmentation fault appears. If I change the second condition in the for loop to something like this:
for(int i=0, i<200, i++)
The segmentation fault appears after 199 iterations.
I have no idea why this is happening. I would think it is very unlikely that I run out of memory, especially when I can do 400 iterations without a problem until the last iteration.
All help is greatly appreciated! Thanks in advance.
c for-loop malloc
c for-loop malloc
asked Nov 12 at 20:37
Peter
112
asked Nov 12 at 20:37
Peter
112
asked Nov 12 at 20:37
Peter
112
asked Nov 12 at 20:37
Peter
112
asked Nov 12 at 20:37
Peter
112
112
3
Run your code through valgrind. If you're mismanaging memory, which it looks like you are, it will tell you where.
– dbush
Nov 12 at 20:39
2
I see no problems in the code presented, there's probably UB elsewhere.
– yano
Nov 12 at 20:41
2
Can't tell without a Minimal, Complete, and Verifiable example.
– Fred Larson
Nov 12 at 20:43
1
OK. Then notice that the output is line-buffered, so it would print198 okn- and then 199 would remain in the buffer. Addfflush(stdout);ornat the end of the printf, and you'd notice that it totally doesn't crash there. Also, now would be a good time to learn to use a proper debugger!
– Antti Haapala
Nov 12 at 20:56
1
Is there a good reason why you're printing the number after the newline? Why notok %dn?
– Barmar
Nov 12 at 21:20
|
show 4 more comments
3
Run your code through valgrind. If you're mismanaging memory, which it looks like you are, it will tell you where.
– dbush
Nov 12 at 20:39
2
I see no problems in the code presented, there's probably UB elsewhere.
– yano
Nov 12 at 20:41
2
Can't tell without a Minimal, Complete, and Verifiable example.
– Fred Larson
Nov 12 at 20:43
1
OK. Then notice that the output is line-buffered, so it would print198 okn- and then 199 would remain in the buffer. Addfflush(stdout);ornat the end of the printf, and you'd notice that it totally doesn't crash there. Also, now would be a good time to learn to use a proper debugger!
– Antti Haapala
Nov 12 at 20:56
1
Is there a good reason why you're printing the number after the newline? Why notok %dn?
– Barmar
Nov 12 at 21:20
3
3
Run your code through valgrind. If you're mismanaging memory, which it looks like you are, it will tell you where.
– dbush
Nov 12 at 20:39
Run your code through valgrind. If you're mismanaging memory, which it looks like you are, it will tell you where.
– dbush
Nov 12 at 20:39
2
2
I see no problems in the code presented, there's probably UB elsewhere.
– yano
Nov 12 at 20:41
I see no problems in the code presented, there's probably UB elsewhere.
– yano
Nov 12 at 20:41
2
2
Can't tell without a Minimal, Complete, and Verifiable example.
– Fred Larson
Nov 12 at 20:43
Can't tell without a Minimal, Complete, and Verifiable example.
– Fred Larson
Nov 12 at 20:43
1
1
OK. Then notice that the output is line-buffered, so it would print
198 okn - and then 199 would remain in the buffer. Add fflush(stdout); or n at the end of the printf, and you'd notice that it totally doesn't crash there. Also, now would be a good time to learn to use a proper debugger!– Antti Haapala
Nov 12 at 20:56
OK. Then notice that the output is line-buffered, so it would print
198 okn - and then 199 would remain in the buffer. Add fflush(stdout); or n at the end of the printf, and you'd notice that it totally doesn't crash there. Also, now would be a good time to learn to use a proper debugger!– Antti Haapala
Nov 12 at 20:56
1
1
Is there a good reason why you're printing the number after the newline? Why not
ok %dn?– Barmar
Nov 12 at 21:20
Is there a good reason why you're printing the number after the newline? Why not
ok %dn?– Barmar
Nov 12 at 21:20
|
show 4 more comments
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53269724%2fsegmentation-fault-while-trying-to-draw-triangles-with-c%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
active
oldest
votes
active
oldest
votes
active
oldest
votes
active
oldest
votes
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Some of your past answers have not been well-received, and you're in danger of being blocked from answering.
Please pay close attention to the following guidance:
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53269724%2fsegmentation-fault-while-trying-to-draw-triangles-with-c%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
3
Run your code through valgrind. If you're mismanaging memory, which it looks like you are, it will tell you where.
– dbush
Nov 12 at 20:39
2
I see no problems in the code presented, there's probably UB elsewhere.
– yano
Nov 12 at 20:41
2
Can't tell without a Minimal, Complete, and Verifiable example.
– Fred Larson
Nov 12 at 20:43
1
OK. Then notice that the output is line-buffered, so it would print
198 okn- and then 199 would remain in the buffer. Addfflush(stdout);ornat the end of the printf, and you'd notice that it totally doesn't crash there. Also, now would be a good time to learn to use a proper debugger!– Antti Haapala
Nov 12 at 20:56
1
Is there a good reason why you're printing the number after the newline? Why not
ok %dn?– Barmar
Nov 12 at 21:20