MarkFlagRequired in cobra seems to have no effect
I am trying to add a required flag in cobra and I have the a sample code below.
package commands
import (
"github.com/spf13/cobra"
)
var sampleCommand = &cobra.Command{
Use: "sample",
Run: func(ccmd *cobra.Command, args string) {
fmt.Println("Hello World")
},
}
func init() {
sampleCommand.Flags().StringP("something", "s", "", "something")
sampleCommand.MarkFlagRequired("something")
}
And I am testing this by
func TestSomething(t *testing.T) {
err := sampleCommand.Execute()
if err != nil {
t.Fail()
}
}
And I do not see any errors. Am I missing something?
EDIT :
I was using an earlier version of cobra which probably had this bug. I upgraded to the HEAD and I no longer see this issue.
go cobra
asked Nov 18 '18 at 5:49
Sanath Kumar MSanath Kumar M
12
add a comment |
I am trying to add a required flag in cobra and I have the a sample code below.
package commands
import (
"github.com/spf13/cobra"
)
var sampleCommand = &cobra.Command{
Use: "sample",
Run: func(ccmd *cobra.Command, args string) {
fmt.Println("Hello World")
},
}
func init() {
sampleCommand.Flags().StringP("something", "s", "", "something")
sampleCommand.MarkFlagRequired("something")
}
And I am testing this by
func TestSomething(t *testing.T) {
err := sampleCommand.Execute()
if err != nil {
t.Fail()
}
}
And I do not see any errors. Am I missing something?
EDIT :
I was using an earlier version of cobra which probably had this bug. I upgraded to the HEAD and I no longer see this issue.
go cobra
asked Nov 18 '18 at 5:49
Sanath Kumar MSanath Kumar M
12
MarkFlagRequiredalso returns error, check it out
– danicheeta
Nov 18 '18 at 10:18
@danicheeta Ya. I checked it. It does not throw an error.
– Sanath Kumar M
Nov 18 '18 at 15:13
add a comment |
I am trying to add a required flag in cobra and I have the a sample code below.
package commands
import (
"github.com/spf13/cobra"
)
var sampleCommand = &cobra.Command{
Use: "sample",
Run: func(ccmd *cobra.Command, args string) {
fmt.Println("Hello World")
},
}
func init() {
sampleCommand.Flags().StringP("something", "s", "", "something")
sampleCommand.MarkFlagRequired("something")
}
And I am testing this by
func TestSomething(t *testing.T) {
err := sampleCommand.Execute()
if err != nil {
t.Fail()
}
}
And I do not see any errors. Am I missing something?
EDIT :
I was using an earlier version of cobra which probably had this bug. I upgraded to the HEAD and I no longer see this issue.
go cobra
asked Nov 18 '18 at 5:49
Sanath Kumar MSanath Kumar M
12
I am trying to add a required flag in cobra and I have the a sample code below.
package commands
import (
"github.com/spf13/cobra"
)
var sampleCommand = &cobra.Command{
Use: "sample",
Run: func(ccmd *cobra.Command, args string) {
fmt.Println("Hello World")
},
}
func init() {
sampleCommand.Flags().StringP("something", "s", "", "something")
sampleCommand.MarkFlagRequired("something")
}
And I am testing this by
func TestSomething(t *testing.T) {
err := sampleCommand.Execute()
if err != nil {
t.Fail()
}
}
And I do not see any errors. Am I missing something?
EDIT :
I was using an earlier version of cobra which probably had this bug. I upgraded to the HEAD and I no longer see this issue.
go cobra
go cobra
asked Nov 18 '18 at 5:49
Sanath Kumar MSanath Kumar M
12
asked Nov 18 '18 at 5:49
Sanath Kumar MSanath Kumar M
12
edited Nov 18 '18 at 15:23
Sanath Kumar M
asked Nov 18 '18 at 5:49
Sanath Kumar MSanath Kumar M
12
asked Nov 18 '18 at 5:49
Sanath Kumar MSanath Kumar M
12
asked Nov 18 '18 at 5:49
Sanath Kumar MSanath Kumar M
12
12
MarkFlagRequiredalso returns error, check it out
– danicheeta
Nov 18 '18 at 10:18
@danicheeta Ya. I checked it. It does not throw an error.
– Sanath Kumar M
Nov 18 '18 at 15:13
add a comment |
MarkFlagRequiredalso returns error, check it out
– danicheeta
Nov 18 '18 at 10:18
@danicheeta Ya. I checked it. It does not throw an error.
– Sanath Kumar M
Nov 18 '18 at 15:13
MarkFlagRequired also returns error, check it out– danicheeta
Nov 18 '18 at 10:18
MarkFlagRequired also returns error, check it out– danicheeta
Nov 18 '18 at 10:18
@danicheeta Ya. I checked it. It does not throw an error.
– Sanath Kumar M
Nov 18 '18 at 15:13
@danicheeta Ya. I checked it. It does not throw an error.
– Sanath Kumar M
Nov 18 '18 at 15:13
add a comment |
2 Answers
2
active
oldest
votes
You didn't get any error because your simpleCommand is not runnable. A command is runnable, if following is true (ref:here) :
// Runnable determines if the command is itself runnable.
func (c *Command) Runnable() bool {
return c.Run != nil || c.RunE != nil
}
As your simpleCommand does not define any Run or RunE, your command is not runnable and that's why you didn't get any error. Define Run or RunE, you will get the required flag error.
var sampleCommand = &cobra.Command{
Use: "sample",
Run: func(cmd *cobra.Command, args string) {
fmt.Println("here")
return
},
}
answered Nov 18 '18 at 14:49
nightfury1204nightfury1204
1,58148
In my original code I do have a Run element. I had abstracted it out here and hence did not add the Run part. I changed the code accordingly, but I still don't see any error func RunSomething(ccmd *cobra.Command, args string) { fmt.Println("Hello World") }
– Sanath Kumar M
Nov 18 '18 at 15:12
add a comment |
I was using an older version of cobra which probably had this issue. The latest version does not have it anymore.
answered Nov 18 '18 at 15:23
Sanath Kumar MSanath Kumar M
12
add a comment |
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53358262%2fmarkflagrequired-in-cobra-seems-to-have-no-effect%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
2 Answers
2
active
oldest
votes
2 Answers
2
active
oldest
votes
active
oldest
votes
active
oldest
votes
You didn't get any error because your simpleCommand is not runnable. A command is runnable, if following is true (ref:here) :
// Runnable determines if the command is itself runnable.
func (c *Command) Runnable() bool {
return c.Run != nil || c.RunE != nil
}
As your simpleCommand does not define any Run or RunE, your command is not runnable and that's why you didn't get any error. Define Run or RunE, you will get the required flag error.
var sampleCommand = &cobra.Command{
Use: "sample",
Run: func(cmd *cobra.Command, args string) {
fmt.Println("here")
return
},
}
answered Nov 18 '18 at 14:49
nightfury1204nightfury1204
1,58148
In my original code I do have a Run element. I had abstracted it out here and hence did not add the Run part. I changed the code accordingly, but I still don't see any error func RunSomething(ccmd *cobra.Command, args string) { fmt.Println("Hello World") }
– Sanath Kumar M
Nov 18 '18 at 15:12
add a comment |
You didn't get any error because your simpleCommand is not runnable. A command is runnable, if following is true (ref:here) :
// Runnable determines if the command is itself runnable.
func (c *Command) Runnable() bool {
return c.Run != nil || c.RunE != nil
}
As your simpleCommand does not define any Run or RunE, your command is not runnable and that's why you didn't get any error. Define Run or RunE, you will get the required flag error.
var sampleCommand = &cobra.Command{
Use: "sample",
Run: func(cmd *cobra.Command, args string) {
fmt.Println("here")
return
},
}
answered Nov 18 '18 at 14:49
nightfury1204nightfury1204
1,58148
In my original code I do have a Run element. I had abstracted it out here and hence did not add the Run part. I changed the code accordingly, but I still don't see any error func RunSomething(ccmd *cobra.Command, args string) { fmt.Println("Hello World") }
– Sanath Kumar M
Nov 18 '18 at 15:12
add a comment |
You didn't get any error because your simpleCommand is not runnable. A command is runnable, if following is true (ref:here) :
// Runnable determines if the command is itself runnable.
func (c *Command) Runnable() bool {
return c.Run != nil || c.RunE != nil
}
As your simpleCommand does not define any Run or RunE, your command is not runnable and that's why you didn't get any error. Define Run or RunE, you will get the required flag error.
var sampleCommand = &cobra.Command{
Use: "sample",
Run: func(cmd *cobra.Command, args string) {
fmt.Println("here")
return
},
}
answered Nov 18 '18 at 14:49
nightfury1204nightfury1204
1,58148
You didn't get any error because your simpleCommand is not runnable. A command is runnable, if following is true (ref:here) :
// Runnable determines if the command is itself runnable.
func (c *Command) Runnable() bool {
return c.Run != nil || c.RunE != nil
}
As your simpleCommand does not define any Run or RunE, your command is not runnable and that's why you didn't get any error. Define Run or RunE, you will get the required flag error.
var sampleCommand = &cobra.Command{
Use: "sample",
Run: func(cmd *cobra.Command, args string) {
fmt.Println("here")
return
},
}
answered Nov 18 '18 at 14:49
nightfury1204nightfury1204
1,58148
answered Nov 18 '18 at 14:49
nightfury1204nightfury1204
1,58148
answered Nov 18 '18 at 14:49
nightfury1204nightfury1204
1,58148
answered Nov 18 '18 at 14:49
nightfury1204nightfury1204
1,58148
1,58148
In my original code I do have a Run element. I had abstracted it out here and hence did not add the Run part. I changed the code accordingly, but I still don't see any error func RunSomething(ccmd *cobra.Command, args string) { fmt.Println("Hello World") }
– Sanath Kumar M
Nov 18 '18 at 15:12
add a comment |
In my original code I do have a Run element. I had abstracted it out here and hence did not add the Run part. I changed the code accordingly, but I still don't see any error func RunSomething(ccmd *cobra.Command, args string) { fmt.Println("Hello World") }
– Sanath Kumar M
Nov 18 '18 at 15:12
In my original code I do have a Run element. I had abstracted it out here and hence did not add the Run part. I changed the code accordingly, but I still don't see any error func RunSomething(ccmd *cobra.Command, args string) { fmt.Println("Hello World") }
– Sanath Kumar M
Nov 18 '18 at 15:12
In my original code I do have a Run element. I had abstracted it out here and hence did not add the Run part. I changed the code accordingly, but I still don't see any error func RunSomething(ccmd *cobra.Command, args string) { fmt.Println("Hello World") }
– Sanath Kumar M
Nov 18 '18 at 15:12
add a comment |
I was using an older version of cobra which probably had this issue. The latest version does not have it anymore.
answered Nov 18 '18 at 15:23
Sanath Kumar MSanath Kumar M
12
add a comment |
I was using an older version of cobra which probably had this issue. The latest version does not have it anymore.
answered Nov 18 '18 at 15:23
Sanath Kumar MSanath Kumar M
12
add a comment |
I was using an older version of cobra which probably had this issue. The latest version does not have it anymore.
answered Nov 18 '18 at 15:23
Sanath Kumar MSanath Kumar M
12
I was using an older version of cobra which probably had this issue. The latest version does not have it anymore.
answered Nov 18 '18 at 15:23
Sanath Kumar MSanath Kumar M
12
answered Nov 18 '18 at 15:23
Sanath Kumar MSanath Kumar M
12
answered Nov 18 '18 at 15:23
Sanath Kumar MSanath Kumar M
12
answered Nov 18 '18 at 15:23
Sanath Kumar MSanath Kumar M
12
12
add a comment |
add a comment |
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53358262%2fmarkflagrequired-in-cobra-seems-to-have-no-effect%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
MarkFlagRequiredalso returns error, check it out– danicheeta
Nov 18 '18 at 10:18
@danicheeta Ya. I checked it. It does not throw an error.
– Sanath Kumar M
Nov 18 '18 at 15:13