FlatList onEndReached being called multiple times












1















I'm making a react native project where user can search images using Flickr API, Everything else is working fine but the problem i'm having while implementing pagination. I have used FlatList's onEndReached to detect when user has scrolled to the end on the list, but the problem is onEndReached is being called multiple times(including one during the first render). I have even disabled bounce as said here but it's still being called more than once



 export default class BrowserHome extends React.Component {
constructor(props) {
super(props);
this.state = {
isLoading: false,
tagParam: "cat",
pageNum: -1,
data: ,
photosObj: ""
};
}

componentDidMount() {
this.setState({
isLoading: true
});
try {
this.makeRequest();
} catch {
console.log("error has occurred");
}
}

makeRequest = () => {
const { tagParam, pageNum } = this.state;
let url = `https://api.flickr.com/services/rest/?
method=flickr.photos.search
&api_key=${apiKey}&format=json&tags=${tagParam}
&per_page=30&page=${pageNum + 1}&nojsoncallback=1`;
fetch(url, {
method: "GET"
})
.then(response => response.json())
.then(responseJSON => {
this.setState({
data: this.state.data.concat(responseJSON.photos.photo),
isLoading: false,
pageNum: responseJSON.photos.page
});
})
.catch(error => {
console.log(error);
this.setState({ isLoading: false });
throw error;
});
};

render() {
if (this.state.isLoading) {
return <ActivityIndicator animating={true} size="large" />;
}

return (
<View
style={{
flex: 1,
height: 200,
justifyContent: "flex-start",
width: screenSize.width,
backgroundColor: "black"
}}
>
<Text>This is browserhome</Text>
<FlatList
style={{
width: screenSize.width
}}
numColumns={3}
data={this.state.data}
keyExtractor={item => item.id}
bounces={false}
onEndReachedThreshold={1}
onEndReached={({ distanceFromEnd }) => {
this.loadMoreItem();
alert("end reached call");
}}
renderItem={({ item, index }) => (
<>
<ImageTile imageURL={this.createImageURL(item)} />
// <Text style={{ color: "white" }}>
// {index}
// {console.log(index)}
// </Text>
</>
)}
/>
</View>
);
}

createImageURL(item) {
let server = item.server,
id = item.id,
secret = item.secret;
let urlString = `https://farm${
item.farm
}.staticflickr.com/${server}/${id}_${secret}_s.jpg`;
return urlString;
}

loadMoreItem() {
this.makeRequest();
}
}









share|improve this question























  • 1. Add onMomentumScrollBegin prop to your FlatList declaration. <FlatList data={this.props.data} onEndReached={...} onEndReachedThreshold={0.5} ... onMomentumScrollBegin={() => { this.onEndReachedCalledDuringMomentum = false; }} /> 2. Modify your onEndReached callback to trigger data fetching only once per momentum. onEndReached = () => { if (!this.onEndReachedCalledDuringMomentum) { this.props.fetchData(); this.onEndReachedCalledDuringMomentum = true; } }; ```

    – Vishal Pachpande
    Feb 13 at 4:45


















1















I'm making a react native project where user can search images using Flickr API, Everything else is working fine but the problem i'm having while implementing pagination. I have used FlatList's onEndReached to detect when user has scrolled to the end on the list, but the problem is onEndReached is being called multiple times(including one during the first render). I have even disabled bounce as said here but it's still being called more than once



 export default class BrowserHome extends React.Component {
constructor(props) {
super(props);
this.state = {
isLoading: false,
tagParam: "cat",
pageNum: -1,
data: ,
photosObj: ""
};
}

componentDidMount() {
this.setState({
isLoading: true
});
try {
this.makeRequest();
} catch {
console.log("error has occurred");
}
}

makeRequest = () => {
const { tagParam, pageNum } = this.state;
let url = `https://api.flickr.com/services/rest/?
method=flickr.photos.search
&api_key=${apiKey}&format=json&tags=${tagParam}
&per_page=30&page=${pageNum + 1}&nojsoncallback=1`;
fetch(url, {
method: "GET"
})
.then(response => response.json())
.then(responseJSON => {
this.setState({
data: this.state.data.concat(responseJSON.photos.photo),
isLoading: false,
pageNum: responseJSON.photos.page
});
})
.catch(error => {
console.log(error);
this.setState({ isLoading: false });
throw error;
});
};

render() {
if (this.state.isLoading) {
return <ActivityIndicator animating={true} size="large" />;
}

return (
<View
style={{
flex: 1,
height: 200,
justifyContent: "flex-start",
width: screenSize.width,
backgroundColor: "black"
}}
>
<Text>This is browserhome</Text>
<FlatList
style={{
width: screenSize.width
}}
numColumns={3}
data={this.state.data}
keyExtractor={item => item.id}
bounces={false}
onEndReachedThreshold={1}
onEndReached={({ distanceFromEnd }) => {
this.loadMoreItem();
alert("end reached call");
}}
renderItem={({ item, index }) => (
<>
<ImageTile imageURL={this.createImageURL(item)} />
// <Text style={{ color: "white" }}>
// {index}
// {console.log(index)}
// </Text>
</>
)}
/>
</View>
);
}

createImageURL(item) {
let server = item.server,
id = item.id,
secret = item.secret;
let urlString = `https://farm${
item.farm
}.staticflickr.com/${server}/${id}_${secret}_s.jpg`;
return urlString;
}

loadMoreItem() {
this.makeRequest();
}
}









share|improve this question























  • 1. Add onMomentumScrollBegin prop to your FlatList declaration. <FlatList data={this.props.data} onEndReached={...} onEndReachedThreshold={0.5} ... onMomentumScrollBegin={() => { this.onEndReachedCalledDuringMomentum = false; }} /> 2. Modify your onEndReached callback to trigger data fetching only once per momentum. onEndReached = () => { if (!this.onEndReachedCalledDuringMomentum) { this.props.fetchData(); this.onEndReachedCalledDuringMomentum = true; } }; ```

    – Vishal Pachpande
    Feb 13 at 4:45
















1












1








1








I'm making a react native project where user can search images using Flickr API, Everything else is working fine but the problem i'm having while implementing pagination. I have used FlatList's onEndReached to detect when user has scrolled to the end on the list, but the problem is onEndReached is being called multiple times(including one during the first render). I have even disabled bounce as said here but it's still being called more than once



 export default class BrowserHome extends React.Component {
constructor(props) {
super(props);
this.state = {
isLoading: false,
tagParam: "cat",
pageNum: -1,
data: ,
photosObj: ""
};
}

componentDidMount() {
this.setState({
isLoading: true
});
try {
this.makeRequest();
} catch {
console.log("error has occurred");
}
}

makeRequest = () => {
const { tagParam, pageNum } = this.state;
let url = `https://api.flickr.com/services/rest/?
method=flickr.photos.search
&api_key=${apiKey}&format=json&tags=${tagParam}
&per_page=30&page=${pageNum + 1}&nojsoncallback=1`;
fetch(url, {
method: "GET"
})
.then(response => response.json())
.then(responseJSON => {
this.setState({
data: this.state.data.concat(responseJSON.photos.photo),
isLoading: false,
pageNum: responseJSON.photos.page
});
})
.catch(error => {
console.log(error);
this.setState({ isLoading: false });
throw error;
});
};

render() {
if (this.state.isLoading) {
return <ActivityIndicator animating={true} size="large" />;
}

return (
<View
style={{
flex: 1,
height: 200,
justifyContent: "flex-start",
width: screenSize.width,
backgroundColor: "black"
}}
>
<Text>This is browserhome</Text>
<FlatList
style={{
width: screenSize.width
}}
numColumns={3}
data={this.state.data}
keyExtractor={item => item.id}
bounces={false}
onEndReachedThreshold={1}
onEndReached={({ distanceFromEnd }) => {
this.loadMoreItem();
alert("end reached call");
}}
renderItem={({ item, index }) => (
<>
<ImageTile imageURL={this.createImageURL(item)} />
// <Text style={{ color: "white" }}>
// {index}
// {console.log(index)}
// </Text>
</>
)}
/>
</View>
);
}

createImageURL(item) {
let server = item.server,
id = item.id,
secret = item.secret;
let urlString = `https://farm${
item.farm
}.staticflickr.com/${server}/${id}_${secret}_s.jpg`;
return urlString;
}

loadMoreItem() {
this.makeRequest();
}
}









share|improve this question














I'm making a react native project where user can search images using Flickr API, Everything else is working fine but the problem i'm having while implementing pagination. I have used FlatList's onEndReached to detect when user has scrolled to the end on the list, but the problem is onEndReached is being called multiple times(including one during the first render). I have even disabled bounce as said here but it's still being called more than once



 export default class BrowserHome extends React.Component {
constructor(props) {
super(props);
this.state = {
isLoading: false,
tagParam: "cat",
pageNum: -1,
data: ,
photosObj: ""
};
}

componentDidMount() {
this.setState({
isLoading: true
});
try {
this.makeRequest();
} catch {
console.log("error has occurred");
}
}

makeRequest = () => {
const { tagParam, pageNum } = this.state;
let url = `https://api.flickr.com/services/rest/?
method=flickr.photos.search
&api_key=${apiKey}&format=json&tags=${tagParam}
&per_page=30&page=${pageNum + 1}&nojsoncallback=1`;
fetch(url, {
method: "GET"
})
.then(response => response.json())
.then(responseJSON => {
this.setState({
data: this.state.data.concat(responseJSON.photos.photo),
isLoading: false,
pageNum: responseJSON.photos.page
});
})
.catch(error => {
console.log(error);
this.setState({ isLoading: false });
throw error;
});
};

render() {
if (this.state.isLoading) {
return <ActivityIndicator animating={true} size="large" />;
}

return (
<View
style={{
flex: 1,
height: 200,
justifyContent: "flex-start",
width: screenSize.width,
backgroundColor: "black"
}}
>
<Text>This is browserhome</Text>
<FlatList
style={{
width: screenSize.width
}}
numColumns={3}
data={this.state.data}
keyExtractor={item => item.id}
bounces={false}
onEndReachedThreshold={1}
onEndReached={({ distanceFromEnd }) => {
this.loadMoreItem();
alert("end reached call");
}}
renderItem={({ item, index }) => (
<>
<ImageTile imageURL={this.createImageURL(item)} />
// <Text style={{ color: "white" }}>
// {index}
// {console.log(index)}
// </Text>
</>
)}
/>
</View>
);
}

createImageURL(item) {
let server = item.server,
id = item.id,
secret = item.secret;
let urlString = `https://farm${
item.farm
}.staticflickr.com/${server}/${id}_${secret}_s.jpg`;
return urlString;
}

loadMoreItem() {
this.makeRequest();
}
}






ios react-native reactive-programming react-native-flatlist






share|improve this question













share|improve this question











share|improve this question




share|improve this question










asked Nov 21 '18 at 9:03









Romit KumarRomit Kumar

14414




14414













  • 1. Add onMomentumScrollBegin prop to your FlatList declaration. <FlatList data={this.props.data} onEndReached={...} onEndReachedThreshold={0.5} ... onMomentumScrollBegin={() => { this.onEndReachedCalledDuringMomentum = false; }} /> 2. Modify your onEndReached callback to trigger data fetching only once per momentum. onEndReached = () => { if (!this.onEndReachedCalledDuringMomentum) { this.props.fetchData(); this.onEndReachedCalledDuringMomentum = true; } }; ```

    – Vishal Pachpande
    Feb 13 at 4:45





















  • 1. Add onMomentumScrollBegin prop to your FlatList declaration. <FlatList data={this.props.data} onEndReached={...} onEndReachedThreshold={0.5} ... onMomentumScrollBegin={() => { this.onEndReachedCalledDuringMomentum = false; }} /> 2. Modify your onEndReached callback to trigger data fetching only once per momentum. onEndReached = () => { if (!this.onEndReachedCalledDuringMomentum) { this.props.fetchData(); this.onEndReachedCalledDuringMomentum = true; } }; ```

    – Vishal Pachpande
    Feb 13 at 4:45



















1. Add onMomentumScrollBegin prop to your FlatList declaration. <FlatList data={this.props.data} onEndReached={...} onEndReachedThreshold={0.5} ... onMomentumScrollBegin={() => { this.onEndReachedCalledDuringMomentum = false; }} /> 2. Modify your onEndReached callback to trigger data fetching only once per momentum. onEndReached = () => { if (!this.onEndReachedCalledDuringMomentum) { this.props.fetchData(); this.onEndReachedCalledDuringMomentum = true; } }; ```

– Vishal Pachpande
Feb 13 at 4:45







1. Add onMomentumScrollBegin prop to your FlatList declaration. <FlatList data={this.props.data} onEndReached={...} onEndReachedThreshold={0.5} ... onMomentumScrollBegin={() => { this.onEndReachedCalledDuringMomentum = false; }} /> 2. Modify your onEndReached callback to trigger data fetching only once per momentum. onEndReached = () => { if (!this.onEndReachedCalledDuringMomentum) { this.props.fetchData(); this.onEndReachedCalledDuringMomentum = true; } }; ```

– Vishal Pachpande
Feb 13 at 4:45














1 Answer
1






active

oldest

votes


















0














You just need to set onEndReachedThreshold as a rate of visibleLength.
So you just need to set it as a number smaller than 1. ZERO for example or 0.5 then it should work!!!!!



Let me know if that worked for you.






share|improve this answer



















  • 1





    I've tried all the values, it's not working

    – Romit Kumar
    Nov 21 '18 at 9:58






  • 1





    github.com/facebook/react-native/issues/…

    – Helmer Barcos
    Nov 21 '18 at 10:00











Your Answer






StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");

StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);

StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});

function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});


}
});














draft saved

draft discarded


















StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53408470%2fflatlist-onendreached-being-called-multiple-times%23new-answer', 'question_page');
}
);

Post as a guest















Required, but never shown

























1 Answer
1






active

oldest

votes








1 Answer
1






active

oldest

votes









active

oldest

votes






active

oldest

votes









0














You just need to set onEndReachedThreshold as a rate of visibleLength.
So you just need to set it as a number smaller than 1. ZERO for example or 0.5 then it should work!!!!!



Let me know if that worked for you.






share|improve this answer



















  • 1





    I've tried all the values, it's not working

    – Romit Kumar
    Nov 21 '18 at 9:58






  • 1





    github.com/facebook/react-native/issues/…

    – Helmer Barcos
    Nov 21 '18 at 10:00
















0














You just need to set onEndReachedThreshold as a rate of visibleLength.
So you just need to set it as a number smaller than 1. ZERO for example or 0.5 then it should work!!!!!



Let me know if that worked for you.






share|improve this answer



















  • 1





    I've tried all the values, it's not working

    – Romit Kumar
    Nov 21 '18 at 9:58






  • 1





    github.com/facebook/react-native/issues/…

    – Helmer Barcos
    Nov 21 '18 at 10:00














0












0








0







You just need to set onEndReachedThreshold as a rate of visibleLength.
So you just need to set it as a number smaller than 1. ZERO for example or 0.5 then it should work!!!!!



Let me know if that worked for you.






share|improve this answer













You just need to set onEndReachedThreshold as a rate of visibleLength.
So you just need to set it as a number smaller than 1. ZERO for example or 0.5 then it should work!!!!!



Let me know if that worked for you.







share|improve this answer












share|improve this answer



share|improve this answer










answered Nov 21 '18 at 9:56









Helmer BarcosHelmer Barcos

634310




634310








  • 1





    I've tried all the values, it's not working

    – Romit Kumar
    Nov 21 '18 at 9:58






  • 1





    github.com/facebook/react-native/issues/…

    – Helmer Barcos
    Nov 21 '18 at 10:00














  • 1





    I've tried all the values, it's not working

    – Romit Kumar
    Nov 21 '18 at 9:58






  • 1





    github.com/facebook/react-native/issues/…

    – Helmer Barcos
    Nov 21 '18 at 10:00








1




1





I've tried all the values, it's not working

– Romit Kumar
Nov 21 '18 at 9:58





I've tried all the values, it's not working

– Romit Kumar
Nov 21 '18 at 9:58




1




1





github.com/facebook/react-native/issues/…

– Helmer Barcos
Nov 21 '18 at 10:00





github.com/facebook/react-native/issues/…

– Helmer Barcos
Nov 21 '18 at 10:00




















draft saved

draft discarded




















































Thanks for contributing an answer to Stack Overflow!


  • Please be sure to answer the question. Provide details and share your research!

But avoid



  • Asking for help, clarification, or responding to other answers.

  • Making statements based on opinion; back them up with references or personal experience.


To learn more, see our tips on writing great answers.




draft saved


draft discarded














StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53408470%2fflatlist-onendreached-being-called-multiple-times%23new-answer', 'question_page');
}
);

Post as a guest















Required, but never shown





















































Required, but never shown














Required, but never shown












Required, but never shown







Required, but never shown

































Required, but never shown














Required, but never shown












Required, but never shown







Required, but never shown







Popular posts from this blog

How to pass form data using jquery Ajax to insert data in database?

National Museum of Racing and Hall of Fame

Guess what letter conforming each word