Why my list only shows the last value after looping through it?





.everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty,.everyoneloves__bot-mid-leaderboard:empty{ height:90px;width:728px;box-sizing:border-box;
}







0















I have a list and have added values to it but it only shows the last value added after extracting values from it. why?



DataTable dt = ClsContractor.GetContractorsPasswordsWhereEqualsCNIC();
Contractors c = new Contractors();

DataRow dr = dt.Rows[0];
int i = 0;
foreach (DataRow r in dt.Rows)
{
string password = Utility.Decrypt(Convert.ToString(r["Password"])).Trim();
string CNIC = Convert.ToString(r["CNIC"]).Trim();
c.NewPwd = Convert.ToString(r["NewPwd"]).Trim();

if (password == CNIC)
{
c.ContractorID = Convert.ToInt32(r["ContractorID"]).ToInt32();
lstContractorsID.Add(c);
Utility.Msg_Success(Master, "Pwd: " + password + " and CNIC: " + CNIC + " matched :" + i++.ToString());

}

}









share|improve this question































    0















    I have a list and have added values to it but it only shows the last value added after extracting values from it. why?



    DataTable dt = ClsContractor.GetContractorsPasswordsWhereEqualsCNIC();
    Contractors c = new Contractors();

    DataRow dr = dt.Rows[0];
    int i = 0;
    foreach (DataRow r in dt.Rows)
    {
    string password = Utility.Decrypt(Convert.ToString(r["Password"])).Trim();
    string CNIC = Convert.ToString(r["CNIC"]).Trim();
    c.NewPwd = Convert.ToString(r["NewPwd"]).Trim();

    if (password == CNIC)
    {
    c.ContractorID = Convert.ToInt32(r["ContractorID"]).ToInt32();
    lstContractorsID.Add(c);
    Utility.Msg_Success(Master, "Pwd: " + password + " and CNIC: " + CNIC + " matched :" + i++.ToString());

    }

    }









    share|improve this question



























      0












      0








      0


      0






      I have a list and have added values to it but it only shows the last value added after extracting values from it. why?



      DataTable dt = ClsContractor.GetContractorsPasswordsWhereEqualsCNIC();
      Contractors c = new Contractors();

      DataRow dr = dt.Rows[0];
      int i = 0;
      foreach (DataRow r in dt.Rows)
      {
      string password = Utility.Decrypt(Convert.ToString(r["Password"])).Trim();
      string CNIC = Convert.ToString(r["CNIC"]).Trim();
      c.NewPwd = Convert.ToString(r["NewPwd"]).Trim();

      if (password == CNIC)
      {
      c.ContractorID = Convert.ToInt32(r["ContractorID"]).ToInt32();
      lstContractorsID.Add(c);
      Utility.Msg_Success(Master, "Pwd: " + password + " and CNIC: " + CNIC + " matched :" + i++.ToString());

      }

      }









      share|improve this question
















      I have a list and have added values to it but it only shows the last value added after extracting values from it. why?



      DataTable dt = ClsContractor.GetContractorsPasswordsWhereEqualsCNIC();
      Contractors c = new Contractors();

      DataRow dr = dt.Rows[0];
      int i = 0;
      foreach (DataRow r in dt.Rows)
      {
      string password = Utility.Decrypt(Convert.ToString(r["Password"])).Trim();
      string CNIC = Convert.ToString(r["CNIC"]).Trim();
      c.NewPwd = Convert.ToString(r["NewPwd"]).Trim();

      if (password == CNIC)
      {
      c.ContractorID = Convert.ToInt32(r["ContractorID"]).ToInt32();
      lstContractorsID.Add(c);
      Utility.Msg_Success(Master, "Pwd: " + password + " and CNIC: " + CNIC + " matched :" + i++.ToString());

      }

      }






      c# .net c#-4.0






      share|improve this question















      share|improve this question













      share|improve this question




      share|improve this question








      edited Nov 22 '18 at 9:38









      Tetsuya Yamamoto

      17.1k42342




      17.1k42342










      asked Nov 22 '18 at 9:26









      azure boyazure boy

      1467




      1467
























          1 Answer
          1






          active

          oldest

          votes


















          3














          I think it's due to the fact that you are overwriting the "Contractor c" object.



          Contractors c = new Contractors();


          should be declared inside the foreach loop.






          share|improve this answer
























            Your Answer






            StackExchange.ifUsing("editor", function () {
            StackExchange.using("externalEditor", function () {
            StackExchange.using("snippets", function () {
            StackExchange.snippets.init();
            });
            });
            }, "code-snippets");

            StackExchange.ready(function() {
            var channelOptions = {
            tags: "".split(" "),
            id: "1"
            };
            initTagRenderer("".split(" "), "".split(" "), channelOptions);

            StackExchange.using("externalEditor", function() {
            // Have to fire editor after snippets, if snippets enabled
            if (StackExchange.settings.snippets.snippetsEnabled) {
            StackExchange.using("snippets", function() {
            createEditor();
            });
            }
            else {
            createEditor();
            }
            });

            function createEditor() {
            StackExchange.prepareEditor({
            heartbeatType: 'answer',
            autoActivateHeartbeat: false,
            convertImagesToLinks: true,
            noModals: true,
            showLowRepImageUploadWarning: true,
            reputationToPostImages: 10,
            bindNavPrevention: true,
            postfix: "",
            imageUploader: {
            brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
            contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
            allowUrls: true
            },
            onDemand: true,
            discardSelector: ".discard-answer"
            ,immediatelyShowMarkdownHelp:true
            });


            }
            });














            draft saved

            draft discarded


















            StackExchange.ready(
            function () {
            StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53427636%2fwhy-my-list-only-shows-the-last-value-after-looping-through-it%23new-answer', 'question_page');
            }
            );

            Post as a guest















            Required, but never shown

























            1 Answer
            1






            active

            oldest

            votes








            1 Answer
            1






            active

            oldest

            votes









            active

            oldest

            votes






            active

            oldest

            votes









            3














            I think it's due to the fact that you are overwriting the "Contractor c" object.



            Contractors c = new Contractors();


            should be declared inside the foreach loop.






            share|improve this answer




























              3














              I think it's due to the fact that you are overwriting the "Contractor c" object.



              Contractors c = new Contractors();


              should be declared inside the foreach loop.






              share|improve this answer


























                3












                3








                3







                I think it's due to the fact that you are overwriting the "Contractor c" object.



                Contractors c = new Contractors();


                should be declared inside the foreach loop.






                share|improve this answer













                I think it's due to the fact that you are overwriting the "Contractor c" object.



                Contractors c = new Contractors();


                should be declared inside the foreach loop.







                share|improve this answer












                share|improve this answer



                share|improve this answer










                answered Nov 22 '18 at 9:32









                mb14mb14

                1259




                1259
































                    draft saved

                    draft discarded




















































                    Thanks for contributing an answer to Stack Overflow!


                    • Please be sure to answer the question. Provide details and share your research!

                    But avoid



                    • Asking for help, clarification, or responding to other answers.

                    • Making statements based on opinion; back them up with references or personal experience.


                    To learn more, see our tips on writing great answers.




                    draft saved


                    draft discarded














                    StackExchange.ready(
                    function () {
                    StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53427636%2fwhy-my-list-only-shows-the-last-value-after-looping-through-it%23new-answer', 'question_page');
                    }
                    );

                    Post as a guest















                    Required, but never shown





















































                    Required, but never shown














                    Required, but never shown












                    Required, but never shown







                    Required, but never shown

































                    Required, but never shown














                    Required, but never shown












                    Required, but never shown







                    Required, but never shown







                    Popular posts from this blog

                    Guess what letter conforming each word

                    Port of Spain

                    Run scheduled task as local user group (not BUILTIN)