Empty rows inserted into table after vba XML import
I'm trying to write a macro that import specific XML data into an existing XML map in an Excel file with predefined columns. Not all XML data is supposed to be imported into the sheet. I've used this approach below before without issue. However, I noticed that the macro took a awful long time to run and then I realized, that the table containing the XML data after the end of XML data inserted empty rows all the way to end row of the Excel sheet. When I import manually, this doesn't happen.
How do I ensure that the table holding the xml data isn't expanded to the end of the Excel sheet? Am I overlooking something?
My macro code:
Sub importXML()
'Define worksheets
Dim ws1 As Worksheet: Set ws1 = Sheets("XML_data")
Application.ScreenUpdating = False
'Finding last row in tabel
lastRow = ws1.Range("A1").Offset(ws1.Rows.Count - 1, 0).End(xlUp).Row
'Deleting old xml map data
If lastRow > 2 Then
ws1.Range("A2:H" & lastRow).EntireRow.Delete
End If
'Define separators and apply.
Application.DecimalSeparator = "."
Application.ThousandsSeparator = ","
Application.UseSystemSeparators = False
fileToOpen = Application.GetOpenFilename("XML Files (*.xml), *.xml", , "Import XML", , True)
Application.DisplayAlerts = False
If IsArray(fileToOpen) Then
For Each fil In fileToOpen
ActiveWorkbook.XmlMaps("myXmlMap").Import URL:=fil
Next fil
Else
Exit Sub
End If
Application.DisplayAlerts = True
Application.UseSystemSeparators = True
End Sub
excel xml vba excel-vba
edited Nov 19 '18 at 12:56
Pᴇʜ
21.8k42750
asked Nov 19 '18 at 11:46
reussreuss
3618
add a comment |
I'm trying to write a macro that import specific XML data into an existing XML map in an Excel file with predefined columns. Not all XML data is supposed to be imported into the sheet. I've used this approach below before without issue. However, I noticed that the macro took a awful long time to run and then I realized, that the table containing the XML data after the end of XML data inserted empty rows all the way to end row of the Excel sheet. When I import manually, this doesn't happen.
How do I ensure that the table holding the xml data isn't expanded to the end of the Excel sheet? Am I overlooking something?
My macro code:
Sub importXML()
'Define worksheets
Dim ws1 As Worksheet: Set ws1 = Sheets("XML_data")
Application.ScreenUpdating = False
'Finding last row in tabel
lastRow = ws1.Range("A1").Offset(ws1.Rows.Count - 1, 0).End(xlUp).Row
'Deleting old xml map data
If lastRow > 2 Then
ws1.Range("A2:H" & lastRow).EntireRow.Delete
End If
'Define separators and apply.
Application.DecimalSeparator = "."
Application.ThousandsSeparator = ","
Application.UseSystemSeparators = False
fileToOpen = Application.GetOpenFilename("XML Files (*.xml), *.xml", , "Import XML", , True)
Application.DisplayAlerts = False
If IsArray(fileToOpen) Then
For Each fil In fileToOpen
ActiveWorkbook.XmlMaps("myXmlMap").Import URL:=fil
Next fil
Else
Exit Sub
End If
Application.DisplayAlerts = True
Application.UseSystemSeparators = True
End Sub
excel xml vba excel-vba
edited Nov 19 '18 at 12:56
Pᴇʜ
21.8k42750
asked Nov 19 '18 at 11:46
reussreuss
3618
add a comment |
I'm trying to write a macro that import specific XML data into an existing XML map in an Excel file with predefined columns. Not all XML data is supposed to be imported into the sheet. I've used this approach below before without issue. However, I noticed that the macro took a awful long time to run and then I realized, that the table containing the XML data after the end of XML data inserted empty rows all the way to end row of the Excel sheet. When I import manually, this doesn't happen.
How do I ensure that the table holding the xml data isn't expanded to the end of the Excel sheet? Am I overlooking something?
My macro code:
Sub importXML()
'Define worksheets
Dim ws1 As Worksheet: Set ws1 = Sheets("XML_data")
Application.ScreenUpdating = False
'Finding last row in tabel
lastRow = ws1.Range("A1").Offset(ws1.Rows.Count - 1, 0).End(xlUp).Row
'Deleting old xml map data
If lastRow > 2 Then
ws1.Range("A2:H" & lastRow).EntireRow.Delete
End If
'Define separators and apply.
Application.DecimalSeparator = "."
Application.ThousandsSeparator = ","
Application.UseSystemSeparators = False
fileToOpen = Application.GetOpenFilename("XML Files (*.xml), *.xml", , "Import XML", , True)
Application.DisplayAlerts = False
If IsArray(fileToOpen) Then
For Each fil In fileToOpen
ActiveWorkbook.XmlMaps("myXmlMap").Import URL:=fil
Next fil
Else
Exit Sub
End If
Application.DisplayAlerts = True
Application.UseSystemSeparators = True
End Sub
excel xml vba excel-vba
edited Nov 19 '18 at 12:56
Pᴇʜ
21.8k42750
asked Nov 19 '18 at 11:46
reussreuss
3618
I'm trying to write a macro that import specific XML data into an existing XML map in an Excel file with predefined columns. Not all XML data is supposed to be imported into the sheet. I've used this approach below before without issue. However, I noticed that the macro took a awful long time to run and then I realized, that the table containing the XML data after the end of XML data inserted empty rows all the way to end row of the Excel sheet. When I import manually, this doesn't happen.
How do I ensure that the table holding the xml data isn't expanded to the end of the Excel sheet? Am I overlooking something?
My macro code:
Sub importXML()
'Define worksheets
Dim ws1 As Worksheet: Set ws1 = Sheets("XML_data")
Application.ScreenUpdating = False
'Finding last row in tabel
lastRow = ws1.Range("A1").Offset(ws1.Rows.Count - 1, 0).End(xlUp).Row
'Deleting old xml map data
If lastRow > 2 Then
ws1.Range("A2:H" & lastRow).EntireRow.Delete
End If
'Define separators and apply.
Application.DecimalSeparator = "."
Application.ThousandsSeparator = ","
Application.UseSystemSeparators = False
fileToOpen = Application.GetOpenFilename("XML Files (*.xml), *.xml", , "Import XML", , True)
Application.DisplayAlerts = False
If IsArray(fileToOpen) Then
For Each fil In fileToOpen
ActiveWorkbook.XmlMaps("myXmlMap").Import URL:=fil
Next fil
Else
Exit Sub
End If
Application.DisplayAlerts = True
Application.UseSystemSeparators = True
End Sub
excel xml vba excel-vba
excel xml vba excel-vba
edited Nov 19 '18 at 12:56
Pᴇʜ
21.8k42750
asked Nov 19 '18 at 11:46
reussreuss
3618
edited Nov 19 '18 at 12:56
Pᴇʜ
21.8k42750
asked Nov 19 '18 at 11:46
reussreuss
3618
edited Nov 19 '18 at 12:56
Pᴇʜ
21.8k42750
edited Nov 19 '18 at 12:56
Pᴇʜ
21.8k42750
edited Nov 19 '18 at 12:56
Pᴇʜ
21.8k42750
21.8k42750
asked Nov 19 '18 at 11:46
reussreuss
3618
asked Nov 19 '18 at 11:46
reussreuss
3618
asked Nov 19 '18 at 11:46
reussreuss
3618
3618
add a comment |
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53373980%2fempty-rows-inserted-into-table-after-vba-xml-import%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53373980%2fempty-rows-inserted-into-table-after-vba-xml-import%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
